Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833792 - games-util/joycond: installs systemd service file in /etc/systemd
Summary: games-util/joycond: installs systemd service file in /etc/systemd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-20 10:09 UTC by Andrew Udvare
Modified: 2022-03-20 22:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Udvare 2022-02-20 10:09:11 UTC
This package's CMakeLists.txt incorrectly installs the systemd service file in /etc/systemd/system. It should be installed to /lib/systemd/system .

There's a PR about this but it too uses an incorrect path for us.

https://github.com/DanielOgorchock/joycond/pull/97

Reproducible: Always

Steps to Reproduce:
1. emerge joycond
2. ls -la /etc/systemd/system/joycond.service
Actual Results:  
-rw-r--r-- 1 root root 218 2021-07-30 00:00:28 /etc/systemd/system/joycond.service

Expected Results:  
This file should not exist in /etc.

Let's patch the CMakeLists.txt file.

Also consider adding paranoia options in my PR: https://github.com/DanielOgorchock/joycond/pull/90

The above PR gets joycond.service to be an acceptable exposure level. Right now it's:

→ Overall exposure level for joycond.service: 9.6 UNSAFE 😨
Comment 1 James Le Cuirot gentoo-dev 2022-02-20 16:49:05 UTC
Ah sorry, should have noticed that. I don't use systemd on Gentoo, but I am familiar with it. I'll get it fixed up shortly.
Comment 2 Andrew Udvare 2022-02-21 17:28:10 UTC
https://github.com/DanielOgorchock/joycond/pull/97 is ready if you want to add this patch to the ebuild. I don't know if upstream ever intends to merge new things in.
Comment 3 Andrew Udvare 2022-02-23 04:12:45 UTC
The PR change works except the 'rm ...modules-load.d' line needs to be removed.
Comment 4 Larry the Git Cow gentoo-dev 2022-03-20 22:52:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8468c7ce1130e455974c4d3ce0185d157753a6a

commit e8468c7ce1130e455974c4d3ce0185d157753a6a
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2022-03-20 22:51:53 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2022-03-20 22:51:53 +0000

    games-util/joycond: Patch to install systemd files in the right locations
    
    Closes: https://bugs.gentoo.org/833792
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-util/joycond/files/joycond-systemd.patch     | 32 ++++++++++++++++++++++
 ...30.ebuild => joycond-0.1.0_p20210730-r1.ebuild} |  5 +++-
 2 files changed, 36 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2022-03-20 22:55:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=854bcc4eb92704b189020c527dd9f24f1c8f02f2

commit 854bcc4eb92704b189020c527dd9f24f1c8f02f2
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2022-03-20 22:54:58 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2022-03-20 22:54:58 +0000

    games-util/joycond: Patch to lock down the systemd service
    
    Thanks to Andrew Udvare.
    
    Closes: https://bugs.gentoo.org/833792
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../joycond/files/joycond-systemd-paranoia.patch   | 45 ++++++++++++++++++++++
 ...d-systemd.patch => joycond-systemd-paths.patch} |  0
 .../joycond/joycond-0.1.0_p20210730-r1.ebuild      |  3 +-
 3 files changed, 47 insertions(+), 1 deletion(-)