Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833509 - net-misc/turbovnc: vncviewer shouldn't be installed without java flag
Summary: net-misc/turbovnc: vncviewer shouldn't be installed without java flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Viorel Munteanu
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-02-17 02:42 UTC by Samuel Bauer
Modified: 2022-02-27 00:19 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2022-02-17 02:42:58 UTC
If you install turbovnc without java flag:

$ /usb/bin/vncviewer
libjawt.so path: /etc/java-config-2/current-system-vm/lib/amd64
Error: Unable to access jarfile /VncViewer.jar

I suggest to remove to add after line 93 in the ebuild

+    else
+        rm -f "${ED}"/usr/bin/vncviewer || die

in src_install phase when testing java use flag.


Also as the java use flag only cares of viewer, it may be good to rename this flag
<flag name=viewer>install a java vnc viewer gui</flag>
Comment 1 Larry the Git Cow gentoo-dev 2022-02-27 00:19:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ead3e37592f29f619d9bc33ae447fa71d15345ef

commit ead3e37592f29f619d9bc33ae447fa71d15345ef
Author:     Viorel Munteanu <ceamac.paragon@gmail.com>
AuthorDate: 2022-02-26 09:10:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-27 00:19:24 +0000

    net-misc/turbovnc: do not build vncviewer if !java
    
    Closes: https://bugs.gentoo.org/833509
    Signed-off-by: Viorel Munteanu <ceamac.paragon@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/24355
    Signed-off-by: Sam James <sam@gentoo.org>

 ...bovnc-2.2.7-r1.ebuild => turbovnc-2.2.7-r2.ebuild} | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)