Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833480 - net-p2p/go-ipfs: please repackage deps into vendor tarball
Summary: net-p2p/go-ipfs: please repackage deps into vendor tarball
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: David Roman
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 833961
  Show dependency tree
 
Reported: 2022-02-16 12:31 UTC by Michał Górny
Modified: 2022-04-22 17:44 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-02-16 12:31:17 UTC
Could you please repackage the dependencies into a vendor tarball?  The package's ebuilds and Manifests are currently humongous:

-rw-r--r-- 1 mgorny mgorny 100K 12-17 23:16 go-ipfs-0.10.0.ebuild
-rw-r--r-- 1 mgorny mgorny 101K 12-29 07:21 go-ipfs-0.11.0.ebuild
-rw-r--r-- 1 mgorny mgorny 683K 12-29 07:21 Manifest
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-03-25 19:28:33 UTC
ping!
Comment 2 Ionen Wolkens gentoo-dev 2022-03-25 19:44:50 UTC
On a side-note, haven't tried building but from a quick look upstream already has vendored deps in the bigger release tarball. So may not be necessary to make our own.

go-ipfs-source.tar.gz
 -> vendor/ (54MB)
Comment 3 Larry the Git Cow gentoo-dev 2022-04-13 22:19:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c768597be25a2a51cf88ad7d07b298348f69479

commit 5c768597be25a2a51cf88ad7d07b298348f69479
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-13 22:15:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-13 22:18:51 +0000

    net-p2p/go-ipfs: add 0.12.2
    
    Bug: https://bugs.gentoo.org/836010
    Bug: https://bugs.gentoo.org/833480
    Closes: https://bugs.gentoo.org/835491
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/go-ipfs/Manifest                           |  2 +
 .../files/go-ipfs-0.12.2-upgrade-quic-go.patch     | 39 ++++++++++++
 net-p2p/go-ipfs/go-ipfs-0.12.2.ebuild              | 70 ++++++++++++++++++++++
 3 files changed, 111 insertions(+)
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-13 22:32:35 UTC
(In reply to Ionen Wolkens from comment #2)
> On a side-note, haven't tried building but from a quick look upstream
> already has vendored deps in the bigger release tarball. So may not be
> necessary to make our own.
> 
> go-ipfs-source.tar.gz
>  -> vendor/ (54MB)

We can try this once no need to patch for Go 1.18
Comment 5 Larry the Git Cow gentoo-dev 2022-04-22 17:36:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=df562ee983ce7ca53c599daab561739ee02edede

commit df562ee983ce7ca53c599daab561739ee02edede
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-22 02:23:57 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-22 17:36:00 +0000

    net-p2p/go-ipfs: drop 0.10.0, 0.11.0
    
    Bug: https://bugs.gentoo.org/836010
    Bug: https://bugs.gentoo.org/833480
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/go-ipfs/Manifest              | 2050 ---------------------------------
 net-p2p/go-ipfs/go-ipfs-0.10.0.ebuild | 1941 -------------------------------
 net-p2p/go-ipfs/go-ipfs-0.11.0.ebuild | 1977 -------------------------------
 3 files changed, 5968 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2022-04-22 17:44:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a1ca9e6a5b40531c57b71e5dd6b5cad9526d93c5

commit a1ca9e6a5b40531c57b71e5dd6b5cad9526d93c5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-22 17:44:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-22 17:44:01 +0000

    net-p2p/go-ipfs: add note re vendor tarball
    
    Bug: https://bugs.gentoo.org/833480
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/go-ipfs/go-ipfs-0.12.2.ebuild | 1 +
 1 file changed, 1 insertion(+)