Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833445 - dev-libs/raft-0.11.3: disable-automagic patch breaks LZ4 usage & test/integration/uv
Summary: dev-libs/raft-0.11.3: disable-automagic patch breaks LZ4 usage & test/integra...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Joonas Niilola
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-02-16 01:40 UTC by James Beddek
Modified: 2022-02-16 06:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Beddek 2022-02-16 01:40:27 UTC
Noticed during a hang of lxc.

With the patch lxd fails to start with the following in logs:

Feb 16 14:34:23 desktop lxd[297778]: t=2022-02-16T14:34:23+1300 lvl=eror msg="Failed to start the daemon" err="Failed to start dqlite server: raft_start(): io: LZ4 not available"

One test also fails with the above patch, test/integration/uv

Not applying the patch fixes both these issues.
Comment 1 Joonas Niilola gentoo-dev 2022-02-16 06:58:37 UTC
Thanks! So much for trying to be clever. 

I'm pretty sure I tested that, but:
---
# pkg-testing-tool --test-feature-scope always --max-use-combinations 1 -p '=dev-libs/raft-0.11.3-r1'
[INFO] >>> Following testing jobs will be executed:
=dev-libs/raft-0.11.3-r1    USE: -lz4 -zfs
[INFO] >>> Running (1 of 1) =dev-libs/raft-0.11.3-r1 with USE: -lz4 -zfs

These are the packages that would be merged, in order:

Calculating dependencies  ... done!
[ebuild   R    ] dev-libs/raft-0.11.3-r1::gentoo  USE="-lz4 -test -zfs*" 0 KiB
---

Maybe I didn't...
Comment 2 Larry the Git Cow gentoo-dev 2022-02-16 06:59:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42d1b44210b5bde39972d304360546af3f307ff3

commit 42d1b44210b5bde39972d304360546af3f307ff3
Author:     James Beddek <telans@posteo.de>
AuthorDate: 2022-02-16 01:44:40 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-02-16 06:59:27 +0000

    dev-libs/raft: update lz4 patch to define LZ4_AVAILABLE
    
    fixes LZ4 usage
    fixes test failure
    
    Closes: https://bugs.gentoo.org/833445
    Signed-off-by: James Beddek <telans@posteo.de>
    Closes: https://github.com/gentoo/gentoo/pull/24206
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 ...ft-0.11.3-disable-automagic-check-for-lz4.patch | 67 +++++++++-------------
 dev-libs/raft/raft-0.11.3-r1.ebuild                | 56 ++++++++++++++++++
 2 files changed, 84 insertions(+), 39 deletions(-)