'Hardware Locality lstopo' desktop entry doesn't have a valid icon Reproducible: Always Steps to Reproduce: 1. emerge -1 sys-apps/hwloc 2. run DE if not running yet, KDE for example 3. Locate 'Hardware Locality lstopo' menu entry in main menu Actual Results: 'Hardware Locality lstopo' has placeholder icon in KDE, might have no icon in other DE/WMs Expected Results: Correct and present icon should be used. Not installing desktop entry is also an option. $ cat /usr/share/applications/lstopo.desktop # should only be used when lstopo is built with Cairo/X11 support # so that no terminal is required [Desktop Entry] Name=Hardware Locality lstopo Comment=Show hardware topology Exec=lstopo Terminal=false Type=Application Categories=System; Keywords=System;Utility; Icon=hwloc Icon 'hwloc' is specified but no icon is packaged. I've found suitable icons in upstream repository, but they're missing in tarball for current version 2.6.0: https://github.com/open-mpi/hwloc/tree/master/contrib/android/assets
(pacho, feel free to fix if you're able, as I only tend to drive-by hwloc & may forget about it)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d8d1957c3ae62f4f6677bd6ccee9f4df01ab4523 commit d8d1957c3ae62f4f6677bd6ccee9f4df01ab4523 Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2022-12-04 14:29:31 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2022-12-04 14:49:21 +0000 sys-apps/hwloc: Install icon No revbump as it is a minor change, hopefully most people will simply get it fixed in next bumps then. Use upstream android png icon over svg as it has a high enough resolution and text looks misaligned in svg icon. Closes: https://bugs.gentoo.org/833345 Signed-off-by: Pacho Ramos <pacho@gentoo.org> sys-apps/hwloc/Manifest | 1 + sys-apps/hwloc/hwloc-2.8.0-r1.ebuild | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-)
This hasnt been fixed due to the desktop file specifying the Icon name as hwloc so its not going to ignore the installed lstopo.png. This should be fixed by amending `doicon ${DISTDIR}/lstopo.png` to `newicon ${DISTDIR}/lstopo.png hwloc.png`
(In reply to Alfred Wingate from comment #3) > This hasnt been fixed due to the desktop file specifying the Icon name as > hwloc so its not going to ignore the installed lstopo.png. "so its going to ignore"*. unhelpful not slipped in.
(In reply to Alfred Wingate from comment #3) > This hasnt been fixed due to the desktop file specifying the Icon name as > hwloc so its not going to ignore the installed lstopo.png. > > This should be fixed by amending `doicon ${DISTDIR}/lstopo.png` to `newicon > ${DISTDIR}/lstopo.png hwloc.png` (In reply to Alfred Wingate from comment #4) > (In reply to Alfred Wingate from comment #3) > > This hasnt been fixed due to the desktop file specifying the Icon name as > > hwloc so its not going to ignore the installed lstopo.png. > > "so its going to ignore"*. unhelpful not slipped in. Yeah, just checked the issue again. It's still not fixed. $ equery f hwloc | grep png /usr/share/pixmaps/lstopo.png $ equery f hwloc | grep desktop /usr/share/applications/lstopo.desktop $ grep Icon /usr/share/applications/lstopo.desktop Icon=hwloc sys-apps/hwloc 2.8.0-r1
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d1243b13cbabd55458c75712bb8f65d9dc2cbfd commit 0d1243b13cbabd55458c75712bb8f65d9dc2cbfd Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2023-06-19 13:30:13 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2023-06-19 13:30:13 +0000 sys-apps/hwloc: Fix icon installation Thanks-to: Alfred Wingate Thanks-to: i.Dark_Templar Closes: https://bugs.gentoo.org/833345 Signed-off-by: Pacho Ramos <pacho@gentoo.org> sys-apps/hwloc/hwloc-2.9.1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I still had the issue, it seems that it is not resolved. After looking into things I found out this: joost@joost-ser /usr/share/pixmaps $ ls -la hwloc* -rw-r--r-- 1 root root 18008 Mar 2 01:50 hwloc -rw-r--r-- 1 root root 18008 Apr 21 13:15 hwloc.png I noticed a hwloc icon file without the png extension. I made a copy and it instantly fixed the issue here.
*** Bug 926862 has been marked as a duplicate of this bug. ***
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21867382426ea87eccf3c49ece762b4e83589edd commit 21867382426ea87eccf3c49ece762b4e83589edd Author: Andrew Ammerlaan <andrewammerlaan@gentoo.org> AuthorDate: 2024-04-25 08:45:15 +0000 Commit: Andrew Ammerlaan <andrewammerlaan@gentoo.org> CommitDate: 2024-04-25 08:48:24 +0000 sys-apps/hwloc: remove automagic behaviour of rocm/l0 And: - fixed the icon file - add doc flag to install doxygen documentation Closes: https://bugs.gentoo.org/926862 Closes: https://bugs.gentoo.org/927627 Closes: https://bugs.gentoo.org/833345 Closes: https://bugs.gentoo.org/836663 Closes: https://github.com/gentoo/gentoo/pull/25837 Co-authored-by: Alessandro Barbieri <lssndrbarbieri@gmail.com> Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org> profiles/arch/amd64/package.use.mask | 4 ++++ profiles/arch/base/package.use.mask | 4 ++++ profiles/features/musl/package.use.mask | 4 ++++ .../hwloc/{hwloc-2.9.3.ebuild => hwloc-2.9.3-r1.ebuild} | 13 +++++++++++-- sys-apps/hwloc/metadata.xml | 2 ++ 5 files changed, 25 insertions(+), 2 deletions(-)
