Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833138 - net-misc/nextcloud-client-3.4.2 fails svg conversion check
Summary: net-misc/nextcloud-client-3.4.2 fails svg conversion check
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-11 19:58 UTC by Russell Dwiggins
Modified: 2022-07-10 18:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,6.76 KB, text/x-log)
2022-02-11 19:59 UTC, Russell Dwiggins
Details
svg-convert patch (svgconvert.patch,455 bytes, patch)
2022-02-11 20:00 UTC, Russell Dwiggins
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Russell Dwiggins 2022-02-11 19:58:54 UTC
net-misc/nextcloud-client-3.4.2 seems to want to use inkscape to perform conversion of svg to png for icons. another option is available, namely rsvg-convert from  gnome-base/librsvg, but doesn't seem to get used.

Reproducible: Always

Steps to Reproduce:
1.emerge net-misc/nextcloud-client-3.4.2
2.
3.
Actual Results:  
nextcloud-client fails to build

Expected Results:  
nextcloud-client builds

There is a patch to call only rsvg-convert here:
https://github.com/nextcloud/desktop/issues/3702#issuecomment-907732686

which needs a slight modification (attached).
Comment 1 Russell Dwiggins 2022-02-11 19:59:36 UTC
Created attachment 764846 [details]
build log
Comment 2 Russell Dwiggins 2022-02-11 20:00:09 UTC
Created attachment 764847 [details, diff]
svg-convert patch
Comment 3 Bernard Cafarelli gentoo-dev 2022-02-12 00:35:58 UTC
Hmm this one is strange, the code upstream has been merged some time ago, and also it now allows for either inkscape or rsvg-convert

I just tested, both cases worked locally (though in ebuild I just keep rsvg dep as much smaller one)

Can you check if you have a /usr/bin/inkscape (and what is it actually)? The log seems to indicate cmake found and tried to use it:
-- Generate 16-Nextcloud-icon.png
[31mCMake Error at src/gui/CMakeLists.txt:311 (message):
  /usr/bin/inkscape could not generate icon: 127
Comment 4 Russell Dwiggins 2022-02-12 04:32:55 UTC
(In reply to Bernard Cafarelli from comment #3)
> Hmm this one is strange, the code upstream has been merged some time ago,
> and also it now allows for either inkscape or rsvg-convert
> 
> I just tested, both cases worked locally (though in ebuild I just keep rsvg
> dep as much smaller one)
> 
> Can you check if you have a /usr/bin/inkscape (and what is it actually)? The
> log seems to indicate cmake found and tried to use it:
> -- Generate 16-Nextcloud-icon.png
> [31mCMake Error at src/gui/CMakeLists.txt:311 (message):
>   /usr/bin/inkscape could not generate icon: 127

Actually, my inkscape was missing lib2geom.so.1.1.0. Still, if that failed, shouldn't we try rsvg-convert? or use that by default as inkscape is a mighty big dependency?
Comment 5 Larry the Git Cow gentoo-dev 2022-07-10 18:39:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=774627e5f5ff7c091a7948e904b834e308a013ab

commit 774627e5f5ff7c091a7948e904b834e308a013ab
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2022-07-10 18:39:24 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2022-07-10 18:39:56 +0000

    net-misc/nextcloud-client: also allow inkscape as svg build dep
    
    Closes: https://bugs.gentoo.org/833138
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 net-misc/nextcloud-client/nextcloud-client-3.5.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)