Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833126 - sci-physics/geant4_vmc-6.0[-test] fails to compile: OpNoviceGDMLDetectorConstruction.cc:31:10: fatal error: G4GDMLParser.hh: No such file or directory
Summary: sci-physics/geant4_vmc-6.0[-test] fails to compile: OpNoviceGDMLDetectorConst...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Oliver Freyermuth
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-02-11 13:17 UTC by Agostino Sarubbo
Modified: 2022-02-14 08:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,84.79 KB, text/plain)
2022-02-11 13:17 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-02-11 13:17:17 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sci-physics/geant4_vmc-6.0 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
If you think this is a GCC-11 related issue, please block bug 732706.
Comment 1 Agostino Sarubbo gentoo-dev 2022-02-11 13:17:19 UTC
Created attachment 764831 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-02-11 13:17:20 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


/var/tmp/portage/sci-physics/geant4_vmc-6.0/work/geant4_vmc-6-0/g4root/test/OpNovice/src/OpNoviceDetectorConstruction.cc:36:10: fatal error: G4GDMLParser.hh: No such file or directory
/var/tmp/portage/sci-physics/geant4_vmc-6.0/work/geant4_vmc-6-0/g4root/test/OpNovice/src/OpNoviceGDMLDetectorConstruction.cc:31:10: fatal error: G4GDMLParser.hh: No such file or directory
/var/tmp/portage/sci-physics/geant4_vmc-6.0/work/geant4_vmc-6-0/g4root/test/OpNovice/src/OpNoviceGDMLDetectorConstruction.cc:31:10: fatal error: G4GDMLParser.hh: No such file or directory
Comment 3 Guilherme Amadio gentoo-dev 2022-02-11 15:03:23 UTC

*** This bug has been marked as a duplicate of bug 833117 ***
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-11 15:05:11 UTC
I don't think it's a dupe:

@@@@@ PLEASE PAY ATTENTION HERE!!! @@@@@
This information may help you to understand if this is a duplicate or if this bug exists after you pushed a fix;
This ebuild was merged at the following commit:
https://github.com/gentoo/gentoo/commit/2a7bbc9e62e8c35cb385bcdb1a6d299b444b2024  (Fri Feb 11 10:47:31 UTC 2022)
@@@@@ END @@@@@
Comment 5 Agostino Sarubbo gentoo-dev 2022-02-11 15:13:00 UTC
(In reply to Sam James from comment #4)
> I don't think it's a dupe:

+1
Comment 6 Oliver Freyermuth 2022-02-11 16:03:31 UTC
Indeed, it's not a dupe — the issue is that even with USE=-test, the tests are built (but not installed), so while the change I applied previously (pulling in a test-only dependency if USE=test is set) was definitely required, it was not sufficient. 

I'll tackle this in a follow-up, thanks to the tinderbox (and the operator :-) ) for testing this combination!
Comment 7 Oliver Freyermuth 2022-02-11 16:40:37 UTC
Part of the cause was indeed a bug in upstream's CMake code. 

Gentoo PR: https://github.com/gentoo/gentoo/pull/24162
Upstream PR: https://github.com/vmc-project/geant4_vmc/pull/28
Comment 8 Larry the Git Cow gentoo-dev 2022-02-14 07:56:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c67dc83f4e17907ce7083edcd0db1c8294c7fcd5

commit c67dc83f4e17907ce7083edcd0db1c8294c7fcd5
Author:     Oliver Freyermuth <o.freyermuth@googlemail.com>
AuthorDate: 2022-02-11 16:37:05 +0000
Commit:     Guilherme Amadio <amadio@gentoo.org>
CommitDate: 2022-02-14 07:56:32 +0000

    sci-physics/geant4_vmc: Do not compile tests if USE=-test.
    
    This fixes upstream's build system to honour enabling/disabling of tests,
    and uses the now functional CMake option.
    PRed upstream at: https://github.com/vmc-project/geant4_vmc/pull/28
    
    Closes: https://bugs.gentoo.org/833126
    Closes: https://github.com/gentoo/gentoo/pull/24162
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Oliver Freyermuth <o.freyermuth@googlemail.com>
    Signed-off-by: Guilherme Amadio <amadio@gentoo.org>

 .../files/geant4_vmc-6.0-cmake-g4root-tests.patch  | 31 ++++++++++++++++++++++
 ...nt4_vmc-6.0.ebuild => geant4_vmc-6.0-r1.ebuild} |  6 +++++
 sci-physics/geant4_vmc/geant4_vmc-9999.ebuild      |  1 +
 3 files changed, 38 insertions(+)
Comment 9 Guilherme Amadio gentoo-dev 2022-02-14 08:00:23 UTC
(In reply to Sam James from comment #4)
> I don't think it's a dupe:
> 
> @@@@@ PLEASE PAY ATTENTION HERE!!! @@@@@
> This information may help you to understand if this is a duplicate or if
> this bug exists after you pushed a fix;
> This ebuild was merged at the following commit:
> https://github.com/gentoo/gentoo/commit/
> 2a7bbc9e62e8c35cb385bcdb1a6d299b444b2024  (Fri Feb 11 10:47:31 UTC 2022)
> @@@@@ END @@@@@

Sorry, my bad indeed. I looked into the logs, saw sci-physics/geant[-gdml] and thought that it had run before the fix had been merged. Thanks, Oliver!