libarchive will fail the test phase if you don't have the USE flag zlib enabled for it. Reproducible: Always Steps to Reproduce: 1.USE="-zlib" emerge -1 app-arch/libarchive 2.??? 3.Profit Actual Results: Test failure Expected Results: Probably expected behavior if it's missing a dependency I'm not sure exactly why it fails, maybe related to DEFLATE compression used in a gzip and winzip wrapper in some of the tests. Maybe we can add to the ebuild: REQUIRED_USE=" Test? ( zlib ) "
Created attachment 764810 [details] test failure
Created attachment 764811 [details] test success
Created attachment 764812 [details] build.log
Do you have a specific use case for -zlib here? I'm not sure if this is worth addressing, maybe we should just enable zlib unconditionally.
I don't have a particular use case, just happened to be testing minimal USE flags and reporting when something doesn't pass testing.
Ok, thanks! I don't think REQUIRED_USE is the way to go, I'd rather either fix the test suite or remove IUSE=zlib altogether. I'll try to find some time to look at this today.
Thank you for your work!
I've submitted fixes for some of the test failures but it looks that in some cases the internal library state gets broken and I don't really want to investigate that deeper. At this point, an archive library without zlib doesn't sound that useful (and the gzip fallback looks incomplete/broken), so I'm just going to remove the flag.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ecebf9b6aae9610454f2b94a0fc7bf429ac03d69 commit ecebf9b6aae9610454f2b94a0fc7bf429ac03d69 Author: Michał Górny <mgorny@gentoo.org> AuthorDate: 2022-02-12 10:18:42 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2022-02-12 10:20:38 +0000 app-arch/libarchive: Enable zlib unconditionally Building libarchive without zlib support is not being tested properly. The library has test failures, and quite possibly also some runtime bugs. Remove the flag and enable zlib unconditionally. Closes: https://bugs.gentoo.org/833091 Signed-off-by: Michał Górny <mgorny@gentoo.org> app-arch/libarchive/libarchive-3.5.3.ebuild | 6 +++--- app-arch/libarchive/libarchive-3.6.0.ebuild | 6 +++--- app-arch/libarchive/metadata.xml | 7 ------- 3 files changed, 6 insertions(+), 13 deletions(-)
