Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833086 - app-office/scribus-1.5.8 fails to build against app-text/poppler-22.02.0
Summary: app-office/scribus-1.5.8 fails to build against app-text/poppler-22.02.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Miroslav Šulc
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2022-02-10 19:17 UTC by Andreas Sturmlechner
Modified: 2022-02-10 19:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
app-office:scribus-1.5.8:20220210-190428.log.xz (app-office:scribus-1.5.8:20220210-190428.log.xz,35.60 KB, application/x-xz)
2022-02-10 19:19 UTC, Andreas Sturmlechner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2022-02-10 19:17:47 UTC
> ../scribus/plugins/import/pdf/slaoutput.cpp: In member function ‘virtual void SlaOutputDev::updateFont(GfxState*)’:
> ../scribus/plugins/import/pdf/slaoutput.cpp:3067:52: error: cannot convert ‘std::optional<GfxFontLoc>’ to ‘GfxFontLoc*’ in assignment
>  3067 |                 if (!(fontLoc = gfxFont->locateFont(xref, nullptr)))
>       |                                 ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
>       |                                                    |
>       |                                                    std::optional<GfxFontLoc>
> ../scribus/plugins/import/pdf/slaoutput.cpp:3086:45: error: cannot convert ‘std::string’ {aka ‘std::__cxx11::basic_string<char>’} to ‘GooString*’ in assignment
>  3086 |                         fileName = fontLoc->path;
>       |                                    ~~~~~~~~~^~~~
>       |                                             |
>       |                                             std::string {aka std::__cxx11::basic_string<char>}
> ../scribus/plugins/import/pdf/slaoutput.cpp:3134:56: error: cannot convert ‘std::unique_ptr<FoFiTrueType>’ to ‘FoFiTrueType*’ in assignment
>  3134 |                                 ff = FoFiTrueType::load(fileName->getCString());
>       |                                      ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>       |                                                        |
>       |                                                        std::unique_ptr<FoFiTrueType>
> ../scribus/plugins/import/pdf/slaoutput.cpp:3136:56: error: cannot convert ‘std::unique_ptr<FoFiTrueType>’ to ‘FoFiTrueType*’ in assignment
>  3136 |                                 ff = FoFiTrueType::make(tmpBuf, tmpBufLen);
>       |                                      ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
>       |                                                        |
>       |                                                        std::unique_ptr<FoFiTrueType>
> ../scribus/plugins/import/pdf/slaoutput.cpp:3207:64: error: cannot convert ‘std::unique_ptr<FoFiTrueType>’ to ‘FoFiTrueType*’ in assignment
>  3207 |                                         ff = FoFiTrueType::load(fileName->getCString());
>       |                                              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
>       |                                                                |
>       |                                                                std::unique_ptr<FoFiTrueType>
> ../scribus/plugins/import/pdf/slaoutput.cpp:3209:64: error: cannot convert ‘std::unique_ptr<FoFiTrueType>’ to ‘FoFiTrueType*’ in assignment
>  3209 |                                         ff = FoFiTrueType::make(tmpBuf, tmpBufLen);
>       |                                              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
>       |                                                                |
>       |                                                                std::unique_ptr<FoFiTrueType>
Comment 1 Andreas Sturmlechner gentoo-dev 2022-02-10 19:19:33 UTC
Created attachment 764808 [details]
app-office:scribus-1.5.8:20220210-190428.log.xz
Comment 3 Larry the Git Cow gentoo-dev 2022-02-10 19:38:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a7e4e34c72ef8b2df011b995ba3c85fac10a5394

commit a7e4e34c72ef8b2df011b995ba3c85fac10a5394
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2022-02-10 19:37:43 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2022-02-10 19:37:43 +0000

    app-office/scribus: added patches for poppler 2.22.0
    
    Bug: https://bugs.gentoo.org/833086
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../files/scribus-1.5.8-poppler-22.2.0-1.patch     | 129 +++++++++++++++++++++
 .../files/scribus-1.5.8-poppler-22.2.0-2.patch     |  28 +++++
 app-office/scribus/scribus-1.5.8.ebuild            |   2 +
 3 files changed, 159 insertions(+)
Comment 4 Miroslav Šulc gentoo-dev 2022-02-10 19:40:14 UTC
thanks asturm. i added the patches but did not test it against poppler 22.2.0. but with 22.01.0 it still compiles fine. keeping the bug open for now until we verify the fix is sufficient.
Comment 5 Andreas Sturmlechner gentoo-dev 2022-02-10 19:55:40 UTC
Thanks, I've already successfully built it against the latest poppler version.
Comment 6 Miroslav Šulc gentoo-dev 2022-02-10 19:59:00 UTC
thanks :-)