Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833083 - sys-firmware/sof-firmware-1.9.3-r1: Error on upgrading to stable from 1.6.1
Summary: sys-firmware/sof-firmware-1.9.3-r1: Error on upgrading to stable from 1.6.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo ALSA team [DISABLED]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-10 15:53 UTC by Brian Evans (RETIRED)
Modified: 2022-04-29 05:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans (RETIRED) gentoo-dev 2022-02-10 15:53:35 UTC
This apparently requires a "!!<sys-firmware/sof-firmware-1.9" RDEPEND to fix

>>> Emerging (1 of 1) sys-firmware/sof-firmware-1.9.3-r1::gentoo
 * sof-firmware-1.9.3.tar.gz BLAKE2B SHA512 size ;-) ...                                                                                       [ ok ]
>>> Unpacking source...
>>> Unpacking sof-firmware-1.9.3.tar.gz to /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/work
>>> Source unpacked in /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/work
>>> Preparing source in /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/work/sof-bin-v1.9.3 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/work/sof-bin-v1.9.3 ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/work/sof-bin-v1.9.3 ...
>>> Source compiled.
>>> Test phase [not enabled]: sys-firmware/sof-firmware-1.9.3-r1

>>> Install sys-firmware/sof-firmware-1.9.3-r1 into /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/image
+ for sdir in sof sof-tplg
+ ln -sT sof-v1.9.3 /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/image/lib/firmware/intel/sof
+ for sdir in sof sof-tplg
+ ln -sT sof-tplg-v1.9.3 /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/image/lib/firmware/intel/sof-tplg
+ rsync -a ./sof-tplg-v1.9.3 ./sof-v1.9.3 /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/image/lib/firmware/intel/
+ rsync -a ./tools-v1.9.3/ /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/image/usr/bin/
>>> Completed installing sys-firmware/sof-firmware-1.9.3-r1 into /var/tmp/portage/sys-firmware/sof-firmware-1.9.3-r1/image

 * Final size of build directory: 12952 KiB (12.6 MiB)
 * Final size of installed tree:  12832 KiB (12.5 MiB)

strip: x86_64-pc-linux-gnu-strip --strip-unneeded -N __gentoo_check_ldflags__ -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   /usr/bin/sof-ctl
   /usr/bin/sof-probes
   /usr/bin/sof-logger

>>> Installing (1 of 1) sys-firmware/sof-firmware-1.9.3-r1::gentoo
 *
 * Installation of a symlink is blocked by a directory:
 *   '/lib/firmware/intel/sof'
 * This symlink will be merged with a different name:
 *   '/lib/firmware/intel/sof.backup.0001'
 *

 * Messages for package sys-firmware/sof-firmware-1.9.3-r1:

 *
 * Installation of a symlink is blocked by a directory:
 *   '/lib/firmware/intel/sof'
 * This symlink will be merged with a different name:
 *   '/lib/firmware/intel/sof.backup.0001'
 *
>>> Auto-cleaning packages...

>>> No outdated packages were found on your system.

 * GNU info directory index is up-to-date.
Comment 1 Brian Evans (RETIRED) gentoo-dev 2022-02-10 16:21:00 UTC
Possible to an attempt a pkg_postinst, but there is a security risk due to firmware binary code being loaded into a driver.

pkg_postinst() {
        local sofpath="${EROOT}/lib/firmware/intel/sof"
        if [[ ! -L "${sofpath}" ]] ; then
                elog "Fixing directory to backup symlink issue"
                rmdir "${sofpath}" || die
                mv "${sofpath}".backup.0000 "${sofpath}" || die
        fi
}
Comment 2 Brian Evans (RETIRED) gentoo-dev 2022-02-10 16:26:48 UTC
This pkg_preinst is better:

pkg_preinst() {
        local sofpath="${EROOT}/lib/firmware/intel/sof"
        if [[ ! -L "${sofpath}" ]] ; then
                rm -r "${sofpath}" || die
        fi
}
Comment 3 Larry the Git Cow gentoo-dev 2022-04-29 04:40:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=38d497575d13da1cf94f195e84bf2a2d1a03aa06

commit 38d497575d13da1cf94f195e84bf2a2d1a03aa06
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-04-29 04:39:09 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-04-29 04:40:24 +0000

    sys-firmware/sof-firmware: add 2.1.1
    
    Closes: https://bugs.gentoo.org/836728
    Closes: https://bugs.gentoo.org/829734
    Closes: https://bugs.gentoo.org/833083
    Thanks-to: Brian Evans <grknight@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-firmware/sof-firmware/Manifest                 |  1 +
 .../sof-firmware/sof-firmware-2.1.1.ebuild         | 30 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)