Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 833080 - sys-devel/m4-1.4.19: avoid makeinfo regeneration
Summary: sys-devel/m4-1.4.19: avoid makeinfo regeneration
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-10 14:38 UTC by Étienne Buira
Modified: 2022-02-10 20:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (m4_build.log,111.75 KB, text/x-log)
2022-02-10 15:02 UTC, Étienne Buira
Details
emerge --info (emerge_info,5.15 KB, text/plain)
2022-02-10 15:03 UTC, Étienne Buira
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Étienne Buira 2022-02-10 14:38:06 UTC
sys-devel/m4-1.4.19 patches .texi files in doc/ (test-198-sysval), that triggers rebuild in doc/, that itself needs makeinfo

Reproducible: Always

Steps to Reproduce:
1. emerge sys-devel/m4 on box without makeinfo
2.
3.
Actual Results:  
make[2]: Entering directory '/var/tmp/portage/sys-devel/m4-1.4.19/work/m4-1.4.19/doc'
restore=: && backupdir=".am$$" && \
am__cwd=`pwd` && CDPATH="${ZSH_VERSION+.}:" && cd . && \
rm -rf $backupdir && mkdir $backupdir && \
if (/bin/sh '/var/tmp/portage/sys-devel/m4-1.4.19/work/m4-1.4.19/build-aux/missing' makeinfo --version) >/dev/null 2>&1; then \
  for f in m4.info m4.info-[0-9] m4.info-[0-9][0-9] m4.i[0-9] m4.i[0-9][0-9]; do \
    if test -f $f; then mv $f $backupdir; restore=mv; else :; fi; \
  done; \
else :; fi && \
cd "$am__cwd"; \
if /bin/sh '/var/tmp/portage/sys-devel/m4-1.4.19/work/m4-1.4.19/build-aux/missing' makeinfo   -I . \
 -o m4.info m4.texi; \
then \
  rc=0; \
  CDPATH="${ZSH_VERSION+.}:" && cd .; \
else \
  rc=$?; \
  CDPATH="${ZSH_VERSION+.}:" && cd . && \
  $restore $backupdir/* `echo "./m4.info" | sed 's|[^/]*$||'`; \
fi; \
rm -rf $backupdir; exit $rc
/var/tmp/portage/sys-devel/m4-1.4.19/work/m4-1.4.19/build-aux/missing: line 81: makeinfo: command not found
WARNING: 'makeinfo' is missing on your system.
         You should only need it if you modified a '.texi' file, or
         any other file indirectly affecting the aspect of the manual.
         You might want to install the Texinfo package:
         <https://www.gnu.org/software/texinfo/>
         The spurious makeinfo call might also be the consequence of
         using a buggy 'make' (AIX, DU, IRIX), in which case you might
         want to install GNU make:
         <https://www.gnu.org/software/make/>
make[2]: *** [Makefile:1979: m4.info] Error 127
make[2]: Leaving directory '/var/tmp/portage/sys-devel/m4-1.4.19/work/m4-1.4.19/doc'
make[1]: *** [Makefile:2018: all-recursive] Error 1
make[1]: Leaving directory '/var/tmp/portage/sys-devel/m4-1.4.19/work/m4-1.4.19'
make: *** [Makefile:1974: all] Error 2


Expected Results:  
build/merge success

Only got it under Linux, but probably kernel-independent
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-10 14:40:51 UTC
That's curious given the patch includes the generated file (and I checked a diff afterwards). Could you include the full build.log and emerge --info please?

I'll sort this later but that information will help.
Comment 2 Larry the Git Cow gentoo-dev 2022-02-10 14:46:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=83cf9e2749be378ca4bb12096c2a33093a0af998

commit 83cf9e2749be378ca4bb12096c2a33093a0af998
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-10 14:45:33 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-10 14:46:17 +0000

    sys-devel/m4: temporarily drop test patch
    
    Need to investigate the makeinfo regeneration issue and it's
    not critical so let's disable the patch for now to avoid issues for folks.
    
    Bug: https://bugs.gentoo.org/833080
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-devel/m4/m4-1.4.19.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 3 Étienne Buira 2022-02-10 15:02:47 UTC
Created attachment 764794 [details]
build.log
Comment 4 Étienne Buira 2022-02-10 15:03:17 UTC
Created attachment 764795 [details]
emerge --info
Comment 5 Étienne Buira 2022-02-10 15:09:05 UTC
About patching both source and generated files, that is really depedent on filesystem time precision, and IIRC make tends to rebuild if time difference is below fs time precision
Comment 6 Mike Gilbert gentoo-dev 2022-02-10 20:41:06 UTC
m4.info depends on version.texi, but version.texi comes after m4.info in the patch. If we re-order the chunks in the patch, that should resolve this.
Comment 7 Larry the Git Cow gentoo-dev 2022-02-10 20:48:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57b682904fc851e1fa9fb1095056544713a76df9

commit 57b682904fc851e1fa9fb1095056544713a76df9
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2022-02-10 20:46:55 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2022-02-10 20:47:03 +0000

    sys-devel/m4: re-order chunks in test-198-sysval.patch
    
    We need to ensure the source files get patched before the outputs.
    
    Closes: https://bugs.gentoo.org/833080
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-devel/m4/Manifest         | 2 +-
 sys-devel/m4/m4-1.4.19.ebuild | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)