The openscad-9999-fix-pkg-config-name-and-include-directory-search.patch appears to be no longer necessary, it was failing to apply for me so I created a local ebuild without it (nothing else changed) and openscad builds, installs, and functions correctly. It appears that the equivalent changes were introduced upstream at the end of last year: https://github.com/openscad/openscad/commit/f723d5d502e96ab5c25b11deddd8420a69167543 which is what's conflicting with the patch. Reproducible: Always Steps to Reproduce: 1. emerge media-gfx/openscad-9999 Actual Results: Build fails due to patch failing to apply. Expected Results: media-gfx/openscad-9999 builds and installs without errors
Apologies, I must have made a mistake earlier, even without the patch I can not build it locally now. There is a server error when I try and attach my build output to this bug (I'll try again later), but the relevant error is here for now: /var/tmp/portage/media-gfx/openscad-9999/work/openscad-9999/src/import_3mf.cc: In function ‘Geometry* import_3mf(const string&, const Location&)’: /var/tmp/portage/media-gfx/openscad-9999/work/openscad-9999/src/import_3mf.cc:379:53: error: cannot convert ‘std::shared_ptr<const Geometry>’ to ‘CGAL_Nef_polyhedron*’ in initialization 379 | CGAL_Nef_polyhedron *N = CGALUtils::applyUnion3D(children.begin(), children.end()); | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | std::shared_ptr<const Geometry>
I managed to track down the issue causing my failing build and I've opened a PR upstream to fix it: https://github.com/openscad/openscad/pull/4103
>>> Preparing source in /var/tmp/portage/media-gfx/openscad-9999/work/openscad-9999 ... * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/media-gfx/openscad-9999/work/openscad-9999" * Build directory (BUILD_DIR): "/var/tmp/portage/media-gfx/openscad-9999/work/openscad-9999_build" * Applying openscad-9999-fix-pkg-config-name-and-include-directory-search.patch ... patching file cmake/Modules/FindLib3MF.cmake Hunk #1 FAILED at 14. 1 out of 1 hunk FAILED -- saving rejects to file cmake/Modules/FindLib3MF.cmake.rej
Dropping the patch, I now get an error with export_3mf.cc: FAILED: CMakeFiles/OpenSCAD.dir/src/io/export_3mf.cc.o /usr/bin/x86_64-pc-linux-gnu-g++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DCGAL_DEBUG -DCGAL_USE_CORE=1 -DCGAL_USE_GMPXX -DCGAL_USE_GMPXX=1 -DEIGEN_DONT_ALIGN -DENABLE_CGAL -DENABLE_LIB3MF -DENABLE_LIBZIP -DENABLE_OPENCSG -DLIB3MF_API_2 -DMI_OVERRIDE -DOPENSCAD_DAY=22 -DOPENSCAD_MONTH=3 -DOPENSCAD_NOGUI -DOPENSCAD_OS=\"Unix\" -DOPENSCAD_SHORTVERSION=2022.03.22 -DOPENSCAD_VERSION=2022.03.22 -DOPENSCAD_YEAR=2022 -DSTACKSIZE=8388608 -DUNICODE -DUSE_MIMALLOC -D_REENTRANT -D_UNICODE -D__GCC -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999_build -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999 -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/core -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/core/customizer -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/ext/json -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/ext/lexertl/include -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/ext/libtess2/Include -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/geometry -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/geometry/cgal -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/glview -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/glview/preview -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/glview/cgal -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/gui -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/io -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/platform -I/var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/utils -isystem /var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/submodules/mimalloc/include -isystem /usr/include/eigen3 -isystem /usr/include/harfbuzz -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/freetype2 -isystem /usr/include/libxml2 -isystem /usr/include/lib3mf -O2 -pipe -march=znver2 -frecord-gcc-switches -fstack-protector-strong -fstack-check -frounding-math -frounding-math -std=c++14 -MD -MT CMakeFiles/OpenSCAD.dir/src/io/export_3mf.cc.o -MF CMakeFiles/OpenSCAD.dir/src/io/export_3mf.cc.o.d -o CMakeFiles/OpenSCAD.dir/src/io/export_3mf.cc.o -c /var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/io/export_3mf.cc /var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/io/export_3mf.cc: In function ‘bool append_3mf(const std::shared_ptr<const Geometry>&, Lib3MF::PWrapper&, Lib3MF::PModel&)’: /var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/io/export_3mf.cc:312:49: error: invalid initialization of reference of type ‘Lib3MF::PWrapper&’ {aka ‘std::shared_ptr<Lib3MF::CWrapper>&’} from expression of type ‘Lib3MF::PModel’ {aka ‘std::shared_ptr<Lib3MF::CModel>’} 312 | return append_polyset(*hybrid->toPolySet(), model); | ^~~~~ /var/tmp/portage-ondisk/portage/media-gfx/openscad-9999/work/openscad-9999/src/io/export_3mf.cc:228:65: note: in passing argument 2 of ‘bool append_polyset(const PolySet&, Lib3MF::PWrapper&, Lib3MF::PModel&)’ 228 | static bool append_polyset(const PolySet& ps, Lib3MF::PWrapper& wrapper, Lib3MF::PModel& model) | ~~~~~~~~~~~~~~~~~~^~~~~~~ I haven't found a report upstream. Will go and open an issue for it.
Coming back to this back. The patch from comment #2 has been merged and the issue I desribed in comment #4 does no longer happen on my side. So just removing the patch seems to work again. Preparing a PR now.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d52105b62053748216dc2975f55d6764ae08013 commit 0d52105b62053748216dc2975f55d6764ae08013 Author: Bernd Waibel <waebbl-gentoo@posteo.net> AuthorDate: 2022-03-24 17:02:30 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-04-15 06:18:47 +0000 media-gfx/openscad: drop outdated patch for 9999 Closes: https://bugs.gentoo.org/832944 Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net> Closes: https://github.com/gentoo/gentoo/pull/24929 Signed-off-by: Joonas Niilola <juippis@gentoo.org> ...-config-name-and-include-directory-search.patch | 31 ---------------------- media-gfx/openscad/openscad-9999.ebuild | 5 ++-- 2 files changed, 2 insertions(+), 34 deletions(-)
