Here's the equery d for qtspeech: * These packages depend on qtspeech: kde-apps/kanagram-21.12.2 (speech ? >=dev-qt/qtspeech-5.15.2:5) kde-apps/knights-21.12.2 (speech ? >=dev-qt/qtspeech-5.15.2:5) kde-apps/kpimtextedit-21.12.2 (>=dev-qt/qtspeech-5.15.2:5) kde-apps/ktp-text-ui-21.12.2 (speech ? >=dev-qt/qtspeech-5.15.2:5) kde-apps/okular-21.12.2 (speech ? >=dev-qt/qtspeech-5.15.2:5) kde-frameworks/knotifications-5.90.0 (speech ? >=dev-qt/qtspeech-5.15.2:5) kde-frameworks/ktextwidgets-5.90.0 (speech ? >=dev-qt/qtspeech-5.15.2:5) As you can see everything except kpimtextedit has a "speech" local use flag which is, in fact, off by default. kpimtextedit is the only thing on a straightforward KDE system build which requires qtspeech, and qtspeech pulls in all manner of speech related stuff that will be unused. It also, now, pulls in a package which Gentoo lists (perhaps incorrectly) as requiring this license: /usr/portage/licenses/Turkowski Which might be entertaining, it does have a smiley, but isn't acceptable by me at least. I'll file a separate bug for this; it's not the issue I'm reporting here, it just makes this issue more noticeable. Turning off -fancyview on libkleo, which should apparently be a work round, doesn't help, that might be a separate bug or the same one, I got bored trying to track it down.
You're not wrong here but the dependency is unconditional upstream (although they seem to have _temporarily_ made it conditional, albeit automagically, due to Qt 6 lacking it [0]). So, somebody (could you?) needs to: 1. Make a patch to make it a real option in the build system (not too hard) 2. Persuade upstream to accept it. [0] https://invent.kde.org/pim/kpimtextedit/-/commit/53f187315f51e7d53a03c4ed464812b388465c10
(Also, yes, please file a bug for espeak-ng if the licence is somehow avoidable, but it's also not something we obviously chose.)
(In reply to Sam James from comment #1) > 1. Make a patch to make it a real option in the build system (not too hard) I tried; I copied the ebuild approach from kde-apps/kanagram and added the 'speech' local option. I got a configure step failure that I judged "too hard" to fix (basically because I didn't understand the errors.) > 2. Persuade upstream to accept it. KDE? Possibly, if I had a fix; it's been a while since I talked to them. It's moot because I don't have a fix. It is very un-obvious to me why kdepimtextedit should itself require speech input. Can you mark this as CONFIRMED?
(In reply to Sam James from comment #2) > (Also, yes, please file a bug for espeak-ng if the licence is somehow > avoidable, but it's also not something we obviously chose.) It's https://bugs.gentoo.org/832778 That isn't directly related - I only noticed the problem because of the Turkowski license requirement and the switch of the speech-dispatcher to use espeak-ng by default (at least I think that is what happened).
I should add that I don't think this bug should be lost because the espeak-ng license requirements get changed; kdepimtextedit is the *only* thing on my system that is pulling in speech generation and there are obviously some things that might use KDE but can't speak... I'm 200% supportive of a systems approach that demands accessibility support everywhere, but I've been saying that for too many years for me to expect it to happen before I die.
(In reply to John Bowler from comment #3) > (In reply to Sam James from comment #1) > > 1. Make a patch to make it a real option in the build system (not too hard) > > I tried; I copied the ebuild approach from kde-apps/kanagram and added the > 'speech' local option. I got a configure step failure that I judged "too > hard" to fix (basically because I didn't understand the errors.) The build system itself (CMakeLists.txt) must be changed, then the ebuild must be wired up. > > > 2. Persuade upstream to accept it. > > KDE? Possibly, if I had a fix; it's been a while since I talked to them. > It's moot because I don't have a fix. It is very un-obvious to me why > kdepimtextedit should itself require speech input. Yes. I think it's simply because nobody had spoken to them about it before. It obviously does have some components which use speech (see the link I gave). > > Can you mark this as CONFIRMED? UNCONFIRMED vs CONFIRMED only matters to the developer(s) processing it. Most don't worry about it and it makes no difference to how we handle it. I was not saying _you_ had to do both 1 & 2 if you don't have such a patch. Just explaining what will need to happen here.
kde-apps/kdepim-runtime already got its flag back; it seems I missed it in kpimtextedit, or rather the change happened afterwards.
(In reply to Sam James from comment #6) > The build system itself (CMakeLists.txt) must be changed, then the ebuild > must be wired up. No patching necessary, see also https://gitweb.gentoo.org/proj/kde.git/commit/?id=2fb145fd9132c0f3cc589c8030eda8f536a45812
(In reply to Andreas Sturmlechner from comment #8) > (In reply to Sam James from comment #6) > > The build system itself (CMakeLists.txt) must be changed, then the ebuild > > must be wired up. > No patching necessary, see also > https://gitweb.gentoo.org/proj/kde.git/commit/ > ?id=2fb145fd9132c0f3cc589c8030eda8f536a45812 I wasn't sure if we wanted to encourage its use here given that upstream may be dropping it again once Qt 6 gains support (it was previously REQUIRED).
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/kde.git/commit/?id=8b04b03f6b0f71816b4de84eeff822032eee8cb5 commit 8b04b03f6b0f71816b4de84eeff822032eee8cb5 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-06 10:39:10 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-06 10:45:02 +0000 kde-apps/kpimtextedit: Re-add IUSE=speech Backporting upstream commits 2fb145fd9132c0f3cc589c8030eda8f536a45812 and 3596c0a90f590c409654a9aec2b087809cff0a79. Bug: https://bugs.gentoo.org/832776 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../kpimtextedit-21.12.2-speech-optional-1.patch | 289 +++++++++++++++++++++ .../kpimtextedit-21.12.2-speech-optional-2.patch | 25 ++ .../kpimtextedit/kpimtextedit-21.12.49.9999.ebuild | 13 +- kde-apps/kpimtextedit/metadata.xml | 1 + 4 files changed, 326 insertions(+), 2 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cefc29423b72bf03dd5f548d0da560cef04f2635 commit cefc29423b72bf03dd5f548d0da560cef04f2635 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-06 10:39:10 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-06 21:16:32 +0000 kde-apps/kpimtextedit: Re-add IUSE=speech Backporting upstream commits 2fb145fd9132c0f3cc589c8030eda8f536a45812 and 3596c0a90f590c409654a9aec2b087809cff0a79. Closes: https://bugs.gentoo.org/832776 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../kpimtextedit-21.12.2-speech-optional-1.patch | 289 +++++++++++++++++++++ .../kpimtextedit-21.12.2-speech-optional-2.patch | 25 ++ ....12.2.ebuild => kpimtextedit-21.12.2-r1.ebuild} | 13 +- kde-apps/kpimtextedit/metadata.xml | 1 + 4 files changed, 326 insertions(+), 2 deletions(-)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b9474d9f97470699189ec2aa8d3604b8f5348f53 commit b9474d9f97470699189ec2aa8d3604b8f5348f53 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-07 09:03:45 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-07 09:05:44 +0000 kde-apps/kpimtextedit: Revert "Re-add IUSE=speech" This reverts commit cefc29423b72bf03dd5f548d0da560cef04f2635. Bug: https://bugs.gentoo.org/832776 Closes: https://bugs.gentoo.org/832841 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../kpimtextedit-21.12.2-speech-optional-1.patch | 289 --------------------- .../kpimtextedit-21.12.2-speech-optional-2.patch | 25 -- ....2-r1.ebuild => kpimtextedit-21.12.2-r2.ebuild} | 13 +- kde-apps/kpimtextedit/metadata.xml | 1 - 4 files changed, 2 insertions(+), 326 deletions(-)
No luck with 21.12. If you want this dependency optional in 22.04, test with 9999 from kde overlay if it works by modifying the ebuild and rebuilding all revdeps as mentioned in bug 832841. In case of issues, please follow up with upstream on this matter.
Created attachment 764836 [details, diff] kpimtextedit-21.08.3-optional-qtspeech.patch I'm maintaining a patched kpimtextedit with optional qtspeech in my local overlay ever since it has become mandatory upstream. I'm still on (stable) version 21.08.3, but my patch seems to apply (with some fuzz) to 21.12.2, so I expect it to still work there. My (attached) patch restores the TextToSpeech handling from before upstream commit 35e5d87c7a4a ("Make it required"), which is different from (and IMHO better than) the current approach from the master branch. My patch doesn't change API/ABI, so it shouldn't break consumers. (I've been using it for years without problems.) Maybe you can convince upstream to restore that behaviour permanently. Of course the ebuild needs to be changed, too. Here's the diff for 21.08.3, I guess you can adapt that to 21.12.2 yourself: --- a/kpimtextedit-21.08.3.ebuild +++ b/kpimtextedit-21.08.3.ebuild @@ -15,13 +15,12 @@ LICENSE="LGPL-2.1+" SLOT="5" KEYWORDS="amd64 arm64 ~ppc64 ~riscv x86" -IUSE="" +IUSE="speech" RESTRICT="test" RDEPEND=" >=dev-qt/qtgui-${QTMIN}:5 - >=dev-qt/qtspeech-${QTMIN}:5 >=dev-qt/qtwidgets-${QTMIN}:5 >=kde-frameworks/kcompletion-${KFMIN}:5 >=kde-frameworks/kconfig-${KFMIN}:5 @@ -34,7 +33,15 @@ RDEPEND=" >=kde-frameworks/kxmlgui-${KFMIN}:5 >=kde-frameworks/sonnet-${KFMIN}:5 >=kde-frameworks/syntax-highlighting-${KFMIN}:5 + speech? ( >=dev-qt/qtspeech-${QTMIN}:5 ) " DEPEND="${RDEPEND} test? ( >=kde-frameworks/ktextwidgets-${KFMIN}:5 ) " + +PATCHES=( "${FILESDIR}"/${PN}-21.08.3-optional-qtspeech.patch ) + +src_configure() { + local mycmakeargs=( $(cmake_use_find_package speech Qt5TextToSpeech) ) + ecm_src_configure +}
(In reply to Alexander Miller from comment #14) > Created attachment 764836 [details, diff] [details, diff] > kpimtextedit-21.08.3-optional-qtspeech.patch > Could you send it upstream? I'll reopen this for now but asturm may wish to close it without upstream buy-in.
*You*'ll have to convince upstream, and make sure to target master branch, because 21.08.3 receives no more changes. Gentoo will not carry downstream patches for this, especially when it lead to problems in 21.12.2 already and does not apply against git master from the get-go.
Link back against your upstream Merge Request in here and we will reopen the bug to track progress and maybe backport even in advance of a new upstream release.
I added the patch mainly for the original reporter and other interested users (and thought that maybe they'd like to help convincing upstream). I know that Gentoo is reluctant to add downstream patches (even though I *don't* expect problems in 21.12.2). Sending the patch upstream was not on my priority list. But since Sam asked nicely, I had a closer look at the patches you tried to backport from current master and compared them with my patch. That changed my mind. So here you go: https://invent.kde.org/pim/kpimtextedit/-/merge_requests/14 Interested parties can add their 2¢ there.
(In reply to Alexander Miller from comment #18) > Sending the patch upstream was not on my priority list. But since Sam asked > nicely, I had a closer look at the patches you tried to backport from > current master and compared them with my patch. That changed my mind. > Really appreciate you doing that. Thanks a lot!
(In reply to Alexander Miller from comment #18) > I added the patch mainly for the original reporter Indeed; thanks for the patch, I'd basically given up and discombobulated speech-dispatcher so that it didn't have any speech engines. I should still have a KDE login, but in my experience their responsiveness is strictly limited - years ago (well over 10) I reported a bug in the KDE session manager and it only got fixed when they stopped using it.
(In reply to John Bowler from comment #20) Reporting bugs isn't the same as something with a straightforward patch that fixes a clear problem. The gitlab is specifically for MRs which fix problems whereas the Bugzilla is for bug reports. It really depends on what component, how much detail, how reproducible it is, ..., but that's offtopic here anyway. We have a good relationship with KDE upstream and I'm confident we'll get an answer one way or another. Cheers.
Upstream fix to libksieve has appeared instead: https://invent.kde.org/pim/libksieve/-/commit/4ff666c61d4c0dde3e96ad7d45c0a81cb58324a0
kde-apps/kpimtextedit and kde-apps/libksieve are fixed in master. kde-apps/messagelib is broken in master and has an MR of my own pending for that. That leaves the following applications not ready for kpimtextedit[-speech] in master: - kde-apps/akregator - kde-apps/kalarm - kde-apps/kmail Anyone up to the task may submit MRs to these packages upstream. I don't have the time to do it all.
I should add that this bug will eventually be RESOLVED/UPSTREAM again, unless someone else propels it forward. Anyone reopening it should consider joining Gentoo kde project as maintainer.
(In reply to John Bowler from comment #20) > but in my experience their responsiveness is strictly limited - years ago - (well over 10) I reported a bug in the KDE session manager and it only got > fixed when they stopped using it. To give you a counter point, my MR just got merged within 33 minutes.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/kde.git/commit/?id=e49b850b1e9c9cae33ebfde2925eda070bd9fd8d commit e49b850b1e9c9cae33ebfde2925eda070bd9fd8d Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-24 16:58:07 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-24 17:04:23 +0000 kde-apps/kmail: Add IUSE speech Bug: https://bugs.gentoo.org/832776 Bug: https://bugs.gentoo.org/832845 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../files/kmail-21.12.3-speech-optional.patch | 69 ++++++++++++++++++++++ kde-apps/kmail/kmail-21.12.49.9999.ebuild | 6 +- kde-apps/kmail/kmail-9999.ebuild | 4 +- kde-apps/kmail/metadata.xml | 3 + 4 files changed, 78 insertions(+), 4 deletions(-) https://gitweb.gentoo.org/proj/kde.git/commit/?id=b908e33f2f63f30a36b86fa5e727c9eafb718f2b commit b908e33f2f63f30a36b86fa5e727c9eafb718f2b Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-24 16:57:58 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-24 17:04:23 +0000 kde-apps/akregator: Add IUSE speech Bug: https://bugs.gentoo.org/832776 Bug: https://bugs.gentoo.org/832845 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> kde-apps/akregator/akregator-21.12.49.9999.ebuild | 6 +- kde-apps/akregator/akregator-9999.ebuild | 4 +- .../akregator-21.12.3-speech-optional-1.patch | 144 +++++++++++++++++++++ .../akregator-21.12.3-speech-optional-2.patch | 25 ++++ kde-apps/akregator/metadata.xml | 3 + 5 files changed, 178 insertions(+), 4 deletions(-) https://gitweb.gentoo.org/proj/kde.git/commit/?id=79550ce1ea1291cfc2820ba1319f9e7a5f735b35 commit 79550ce1ea1291cfc2820ba1319f9e7a5f735b35 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-24 15:44:05 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-24 17:04:23 +0000 kde-apps/messagelib: Add IUSE speech Bug: https://bugs.gentoo.org/832776 Bug: https://bugs.gentoo.org/832845 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../messagelib-21.12.3-speech-optional-1.patch | 131 +++++++++++++++++++++ .../messagelib-21.12.3-speech-optional-2.patch | 95 +++++++++++++++ .../messagelib-21.12.3-speech-optional-3.patch | 56 +++++++++ .../messagelib/messagelib-21.12.49.9999.ebuild | 6 +- kde-apps/messagelib/messagelib-9999.ebuild | 4 +- kde-apps/messagelib/metadata.xml | 3 + 6 files changed, 291 insertions(+), 4 deletions(-) https://gitweb.gentoo.org/proj/kde.git/commit/?id=6fb620db1f16b6ffe0f9f8c48d0451d16faad905 commit 6fb620db1f16b6ffe0f9f8c48d0451d16faad905 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-21 17:37:47 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-24 17:04:23 +0000 kde-apps/libksieve: Add IUSE speech Bug: https://bugs.gentoo.org/832776 Bug: https://bugs.gentoo.org/832845 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../files/libksieve-21.12.3-speech-optional.patch | 180 +++++++++++++++++++++ kde-apps/libksieve/libksieve-21.12.49.9999.ebuild | 6 +- kde-apps/libksieve/libksieve-9999.ebuild | 4 +- kde-apps/libksieve/metadata.xml | 3 + 4 files changed, 189 insertions(+), 4 deletions(-)
That leaves kde-apps/kalarm.
https://invent.kde.org/pim/kalarm/-/commit/53a299c513c447afc57c7f520ac35aea2dffc277
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/kde.git/commit/?id=32a86d5ca4fe16e46a1acf2777bd16d5ea38557d commit 32a86d5ca4fe16e46a1acf2777bd16d5ea38557d Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-02-27 23:19:37 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-02-27 23:20:49 +0000 kde-apps/kalarm: Add IUSE speech Bug: https://bugs.gentoo.org/832776 Bug: https://bugs.gentoo.org/832845 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> .../files/kalarm-21.12.3-speech-optional.patch | 124 +++++++++++++++++++++ kde-apps/kalarm/kalarm-21.12.49.9999.ebuild | 6 +- kde-apps/kalarm/kalarm-9999.ebuild | 4 +- kde-apps/kalarm/metadata.xml | 3 + 4 files changed, 133 insertions(+), 4 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b46f7ff6b974c3378c2a1ab6cf5048d9ace0a234 commit b46f7ff6b974c3378c2a1ab6cf5048d9ace0a234 Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2022-03-03 11:30:51 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2022-03-03 14:53:17 +0000 kde-apps/kpimtextedit: 21.12.3 version bump Closes: https://bugs.gentoo.org/832776 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> kde-apps/kpimtextedit/Manifest | 1 + .../kpimtextedit-21.12.3-speech-optional-1.patch | 289 +++++++++++++++++++++ .../kpimtextedit-21.12.3-speech-optional-2.patch | 25 ++ .../kpimtextedit-21.12.3-speech-optional-3.patch | 100 +++++++ kde-apps/kpimtextedit/kpimtextedit-21.12.3.ebuild | 50 ++++ kde-apps/kpimtextedit/metadata.xml | 1 + 6 files changed, 466 insertions(+)
kde*-21.12.3 fixes the problem; qtspeech and speech-dispatcher are no longer required in my system.
