Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 832756 - www-apps/gitea-1.16.0 builds but segfaults
Summary: www-apps/gitea-1.16.0 builds but segfaults
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2022-02-05 11:55 UTC by jon R-B
Modified: 2022-05-04 23:24 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch to manage pie (gitea_pie.patch,1.02 KB, patch)
2022-04-15 15:23 UTC, jon R-B
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jon R-B 2022-02-05 11:55:41 UTC
Gitea-1.16.0 builds. However it fails to launch 
When launching gitea manually (not via rc-service) this error message is presented

gitea
fatal error: minpc or maxpc invalid
runtime: panic before malloc heap initialized

runtime stack:
Segmentation fault


The corresponding output in dmesg is:
[ 5293.550266] gitea[22206]: segfault at 7ffd1c315fe8 ip 000055862c90e449 sp 00007ffd1c315ff0 error 6 in gitea[55862c8ba000+1de4000]
[ 5293.550276] Code: 8b 6c 24 10 48 83 c4 18 c3 31 c0 31 db 48 8b 6c 24 10 48 83 c4 18 c3 48 89 d1 e8 a2 61 01 00 48 89 f9 e8 7a 61 01 00 48 89 f9 <e8> 72 61 01 00 ff ca 89 d0 48 39 c7 76 2e 48 c1 e0 04 4d 8b 0c 00



Reproducible: Always

Steps to Reproduce:
1. emerge gitea-1.16
2. start gitea 
3.
Comment 1 Tomáš Mózes 2022-02-05 14:25:19 UTC
Please post the output of $(emerge --info).
Comment 2 jon R-B 2022-02-05 14:53:18 UTC
emerge --info
Portage 3.0.30 (python 3.9.10-final-0, default/linux/amd64/17.1/desktop, gcc-11.2.1, glibc-2.34-r7, 5.16.1-gentoo x86_64)
=================================================================
System uname: Linux-5.16.1-gentoo-x86_64-AMD_Ryzen_5_1600_Six-Core_Processor-with-glibc2.34
KiB Mem:    32897148 total,  15313012 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Thu, 03 Feb 2022 17:22:12 +0000
Head commit of repository gentoo: 4752b6a48b76cdcca98bd9bb98d1343f91922d23

sh bash 5.1_p16
ld GNU ld (Gentoo 2.37_p1 p2) 2.37
app-misc/pax-utils:        1.3.3::gentoo
app-shells/bash:           5.1_p16::gentoo
dev-java/java-config:      2.3.1::gentoo
dev-lang/perl:             5.34.0-r6::gentoo
dev-lang/python:           3.9.10-r1::gentoo, 3.10.2-r1::gentoo
dev-lang/rust:             1.58.1::gentoo
dev-util/cmake:            3.22.2::gentoo
dev-util/meson:            0.60.3::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/openrc:           0.44.10::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.37_p1-r2::gentoo
sys-devel/binutils-config: 5.4::gentoo
sys-devel/clang:           13.0.1::gentoo
sys-devel/gcc:             11.2.1_p20220115::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.6-r6::gentoo
sys-devel/lld:             13.0.1::gentoo
sys-devel/llvm:            13.0.1::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.16::gentoo (virtual/os-headers)
sys-libs/glibc:            2.34-r7::gentoo
sys-libs/libselinux:       3.3::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-git-verify-commit-signature: true

local
    location: /var/db/repos/local
    masters: gentoo

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE"
AR="llvm-ar"
CBUILD="x86_64-pc-linux-gnu"
CC="clang"
CFLAGS="-O3 -pipe -march=native -mtune=native -fPIC -fstack-protector-strong -D_FORTIFY_SOURCE=2 -flto=thin"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXX="clang++"
CXXFLAGS="-O3 -pipe -march=native -mtune=native -fPIC -fstack-protector-strong -D_FORTIFY_SOURCE=2 -flto=thin"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--jobs=5 --load-average=5.0 --with-bdeps y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync metadata-transfer multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/"
LANG="en_GB.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -fuse-ld=lld -rtlib=compiler-rt -unwindlib=libunwind -Wl,--as-needed -Wl,-z,relro,-z,now -pie -unwindlib=libunwind"
LINGUAS="en en_GB uk"
MAKEOPTS="-j10"
NM="llvm-nm"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
RANLIB="llvm-ranlib"
SHELL="/bin/bash"
USE="X a52 aac acl acpi aiglx alsa amd64 bash-completion binddist branding bzip2 cairo cblas-external cdda cdr clang cleartype cli corefonts crypt dri dts elogind encode eselect-ldso evdev exif ffmpeg flac fortran gcc64 gdbm gegl gif gles2 gpm graphite gstreamer gtk gui iconv icu imlib introspection ipv6 java jpeg lcms libglvnd libnotify libtirpc lto mad mng mp3 mp4 mpeg multilib ncurses nls nptl nptlonly nsplugin ogg opengl openmp oss pam pango pcre pdf pgo png ppds pulseaudio python qt5 readline samba screencast sdl seatd seccomp smbclient spell split-usr ssl startup-notification svg threads tiff truetype type1 udev udisks unicode upower usb vorbis wayland webkit wxwidgets x264 xattr xcb xml xulrunner xv xvid zlib" ABI_X86="64 32" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="f16c mmx mmxext popcnt sse sse2 sse3 sse4a ssse avx sse4_2 sse4_1 ssse3" CURL_SSL="gnutls" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64 efi-32" INPUT_DEVICES="keyboard mouse libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AMDGPU" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="vesa amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, ARFLAGS, AS, ASFLAGS, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 3 jon R-B 2022-02-06 17:25:00 UTC
This is triggered by the -PIE flag in LDFLAG's

To make use of -PIE with golang the ebuild needs to be updated:

https://gitweb.gentoo.org/repo/gentoo.git/tree/www-apps/gitea/gitea-1.16.0.ebuild?id=f76a31d84308789da99f701671b7a8ba699fce7f#n68

Needs to be:  LDFLAGS="-linkmode external -extldflags \"static ${LDFLAGS}\" ${gitea_settings[*]}"


Likewise #69 needs to be: TAGS="netgo osusergo ${gitea_tags[*]}"
Comment 4 Tomáš Mózes 2022-02-09 17:57:09 UTC
(In reply to jon R-B from comment #3)
> This is triggered by the -PIE flag in LDFLAG's
> 
> To make use of -PIE with golang the ebuild needs to be updated:
> 
> https://gitweb.gentoo.org/repo/gentoo.git/tree/www-apps/gitea/gitea-1.16.0.
> ebuild?id=f76a31d84308789da99f701671b7a8ba699fce7f#n68
> 
> Needs to be:  LDFLAGS="-linkmode external -extldflags \"static ${LDFLAGS}\"
> ${gitea_settings[*]}"
> 
> 
> Likewise #69 needs to be: TAGS="netgo osusergo ${gitea_tags[*]}"

Perhaps enabled by “static“ USE flag?
Comment 5 Sheng Yu 2022-04-15 03:55:33 UTC
For what I tested, "-buildmode=pie" is needed to build when PIE is enabled.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-15 04:05:18 UTC
Does make me wonder what other Go packages seem to do this wrong.

So, can soemone give a final patch of what's needed?
Comment 7 jon R-B 2022-04-15 12:16:13 UTC
ill write a patch shortly
Comment 8 jon R-B 2022-04-15 15:23:21 UTC
Created attachment 770915 [details, diff]
ebuild patch to manage pie

patch created and pie enabled behind USE flag.


Check performed
1) is pie still an issue - YES
2) build with USE=-pie - yes and works
3) build with USE=pie - yes and works 


file /usr/bin/gitea
/usr/bin/gitea: ELF 64-bit LSB pie executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, Go BuildID=44eDhoEcCSM7TkdcBySG/bLu6ovV1Id3D5Riq0a37/xvNDt_vL_8Mj2Dhm6MuA/VgLehzA2yztKUSyCgHHr, stripped
Comment 9 Larry the Git Cow gentoo-dev 2022-05-04 23:22:52 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9dff681e3948e79f9b77b6fb4d6b14a5ef73a850

commit 9dff681e3948e79f9b77b6fb4d6b14a5ef73a850
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-04 23:19:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-04 23:22:43 +0000

    www-apps/gitea: fix PIE crash at runtime
    
    Closes: https://bugs.gentoo.org/832756
    Thanks-to: jon R-B <jon.roadleybattin@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 www-apps/gitea/gitea-1.16.6-r1.ebuild | 118 ++++++++++++++++++++++++++++++++++
 1 file changed, 118 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13fb5b0bd1ed64c3a5910ad2e29459f60c377547

commit 13fb5b0bd1ed64c3a5910ad2e29459f60c377547
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-05-04 23:22:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-05-04 23:22:45 +0000

    www-apps/gitea: rebase PIE changes onto 1.16.7
    
    Bug: https://bugs.gentoo.org/832756
    Signed-off-by: Sam James <sam@gentoo.org>

 www-apps/gitea/gitea-1.16.7.ebuild | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)