I've noticed that 'Hardware Lister' menu entry in KDE doesn't have an icon, it only has placeholder icon. On further inspection I've noticed that desktop entry lists 'lshw' as icon, while this package packs only gtk-lshw.svg and no lshw.svg. Reproducible: Always Steps to Reproduce: 1. USE="gtk" emerge -1 sys-apps/lshw 2. run DE if not running yet, KDE for example 3. Locate 'Hardware Lister' menu entry in main menu. For me it's under 'System' menu group, i.e. group containing "konsole" and "dolphin" menu entries, for example. Actual Results: 'Hardware Lister' menu entry has placeholder icon Expected Results: 'Hardware Lister' menu entry should have proper icon $ equery f lshw | grep icons /usr/share/icons /usr/share/icons/hicolor /usr/share/icons/hicolor/scalable /usr/share/icons/hicolor/scalable/apps /usr/share/icons/hicolor/scalable/apps/gtk-lshw.svg $ cat /usr/share/applications/gtk-lshw-lshw.desktop [Desktop Entry] Name=Hardware Lister Type=Application Comment=Hardware Lister Exec=/usr/sbin/gtk-lshw TryExec=/usr/sbin/gtk-lshw Icon=lshw Categories=System;
Created attachment 764369 [details, diff] lshw-desktop.patch Patch file containing one way of fixing this issue. Either icon should be renamed to match what desktop file contains, or desktop file should be updated to reflect real icon name. This patch renames icon.
Thanks, since we're already renaming with newicon, I agree that just renaming properly is the best fix
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a69cd51a1b046bf146aafc1c667638f40289db94 commit a69cd51a1b046bf146aafc1c667638f40289db94 Author: Ben Kohler <bkohler@gentoo.org> AuthorDate: 2022-02-06 12:58:45 +0000 Commit: Ben Kohler <bkohler@gentoo.org> CommitDate: 2022-02-06 12:58:45 +0000 sys-apps/lshw: revbump for desktop file icon fix Closes: https://bugs.gentoo.org/832739 Package-Manager: Portage-3.0.30, Repoman-3.0.3 Signed-off-by: Ben Kohler <bkohler@gentoo.org> sys-apps/lshw/lshw-02.19.2b_p20210121-r3.ebuild | 83 +++++++++++++++++++++++++ 1 file changed, 83 insertions(+)
