Bug 832685 – sys-devel/mold with double prefix

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Jens Lindenmeier 2022-02-04 10:01:26 UTC]

sys-devel/mold in  EPREFIX RAP environment has a double prefix issue:

* Messages for package sys-devel/mold-1.0.2:

 * ERROR: sys-devel/mold-1.0.2::gentoo failed:
 *   Aborting due to QA concerns: double prefix files installed
 * 
 * Call stack:
 *   misc-functions.sh, line 637:  Called install_qa_check
 *   misc-functions.sh, line 132:  Called source 'install_symlink_html_docs'
 *            05prefix, line 114:  Called install_qa_check_prefix
 *            05prefix, line  19:  Called die
 * The specific snippet of code:
 *   		die "Aborting due to QA concerns: double prefix files installed"
 * 
 * If you need support, post the output of `emerge --info '=sys-devel/mold-1.0.2::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=sys-devel/mold-1.0.2::gentoo'`.
 * The complete build log is located at '/data/opt/tools/gentoo/var/tmp/portage/sys-devel/mold-1.0.2/temp/build.log'.
 * The ebuild environment file is located at '/data/opt/tools/gentoo/var/tmp/portage/sys-devel/mold-1.0.2/temp/environment'.
 * Working directory: '/data/opt/tools/gentoo/var/tmp/portage/sys-devel/mold-1.0.2/image/opt/tools/gentoo'
 * S: '/data/opt/tools/gentoo/var/tmp/portage/sys-devel/mold-1.0.2/work/mold-1.0.2'
 * 
 * The following package has failed to build, install, or execute postinst:
 * 
 *  (sys-devel/mold-1.0.2:0/0::gentoo, ebuild scheduled for merge), Log file:
 *   '/data/opt/tools/gentoo/var/tmp/portage/sys-devel/mold-1.0.2/temp/build.log'


Reproducible: Always

Steps to Reproduce:
1. emerge mold in a EPREFIX environment

[Comment 1 Jens Lindenmeier 2022-02-04 10:14:06 UTC]

Created attachment 764316 [details]
corrected mold ebuild file

[Comment 2 Fabian Groffen 2022-02-04 11:03:52 UTC]

Hi,

Thanks for your bug/patch.  For the future, can you just post a patch/diff so we can easily see what you changed to get it working.

In this case can I ask you to try if the following also works:

--- a/sys-devel/mold/mold-1.0.2.ebuild
+++ b/sys-devel/mold/mold-1.0.2.ebuild
@@ -63,7 +63,7 @@ src_install() {
                SYSTEM_TBB=1 \
                SYSTEM_MIMALLOC=1 \
                SYSTEM_XXHASH=1 \
-               DESTDIR="${ED}" \
+               DESTDIR="${D}" \
                PREFIX="${EPREFIX}/usr" \
                LIBDIR="${EPREFIX}/usr/$(get_libdir)" \
                STRIP="true" \

If this works for you, then I'll commit that instead of your change.

Thanks!

[Comment 3 Jens Lindenmeier 2022-02-04 11:17:53 UTC]

Sure Fabian, sorry for missing the patch submit rules.

I have applied your patch in turn and I can confirm it works for me. Thx for the quick reaction.

[Comment 4 Fabian Groffen 2022-02-04 11:20:46 UTC]

thank you for testing

[Comment 5 Larry the Git Cow 2022-02-04 11:21:00 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=69b84eea11856f9627a7a0d10bf05b241df55406

commit 69b84eea11856f9627a7a0d10bf05b241df55406
Author:     Fabian Groffen <[e-mail]>
AuthorDate: 2022-02-04 11:20:47 +0000
Commit:     Fabian Groffen <[e-mail]>
CommitDate: 2022-02-04 11:20:57 +0000

    sys-devel/mold: fix double Prefix, thanks Jens Lindenmeier
    
    Closes: https://bugs.gentoo.org/832685
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Fabian Groffen <[e-mail]>

 sys-devel/mold/mold-1.0.0-r1.ebuild | 4 ++--
 sys-devel/mold/mold-1.0.1-r1.ebuild | 2 +-
 sys-devel/mold/mold-1.0.2.ebuild    | 2 +-
 sys-devel/mold/mold-9999.ebuild     | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)