Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 832562 - x11-misc/slim upstream project forked
Summary: x11-misc/slim upstream project forked
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-02 08:35 UTC by Robert Pearce
Modified: 2023-03-14 19:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild for new upstream (slim-1.3.7.ebuild,3.34 KB, text/plain)
2022-02-02 08:37 UTC, Robert Pearce
Details
Revised patch for Gentoo-friendly config file (slim-1.3.7-config.diff,1.63 KB, patch)
2022-02-02 08:39 UTC, Robert Pearce
Details | Diff
Updated ebuild for new release (slim-1.3.8.ebuild,3.10 KB, text/plain)
2022-03-05 09:45 UTC, Robert Pearce
Details
Revised patch for Gentoo-friendly config file (slim-1.3.8-config.diff,1.64 KB, patch)
2022-03-05 09:46 UTC, Robert Pearce
Details | Diff
Another updated ebuild, for 1.3.9, with a small fix (slim-1.3.9.ebuild,3.24 KB, text/plain)
2022-11-21 08:22 UTC, Robert Pearce
Details
Updated config file patch for 1.3.9 release (slim-1.3.9-config.diff,1.64 KB, patch)
2022-11-21 08:24 UTC, Robert Pearce
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Pearce 2022-02-02 08:35:24 UTC
There is now a fork of the SLiM project upstream and it has issued a first release, targetted mostly at fixing the bugs as needed by Gentoo. I have an updated ebuild which I've tested on X86 and AMD64 (openRC/PAM).

Reproducible: Always

Steps to Reproduce:
N/A - ebuild bump request


Expected Results:  
The new ebuild should be cleaner and should fix a few bugs

As I say, there's a new upstream project. Full disclosure - I'm the owner. I was getting annoyed with all the -r7 stuff and the big list of patches.
Comment 1 Robert Pearce 2022-02-02 08:37:02 UTC
Created attachment 764205 [details]
Updated ebuild for new upstream

This ebuild has the revised upstream project references and the trimmed-out patch list. Also fixes a QA issue with IUSE.
Comment 2 Robert Pearce 2022-02-02 08:39:01 UTC
Created attachment 764206 [details, diff]
Revised patch for Gentoo-friendly config file

When I forked the upstream, I decided not to make it too Gentoo-specific, so some parts of the default slim.conf still want a tweak.
Comment 3 Andreas Sturmlechner gentoo-dev 2022-02-02 11:09:24 UTC
The -rX stuff really is irrelevant.

Does it fix any of the known bugs?

https://bugs.gentoo.org/buglist.cgi?quicksearch=x11-misc%2Fslim&list_id=6039363
Comment 4 Robert Pearce 2022-02-02 12:00:30 UTC
I believe it fixes 803476, 732430, 756181, plus 828669 (which I think was already fixed).
Bug 832303 I would have to check - I know I spotted the problem (as compiler warnings) when forking, but can't remember off-hand whether I fixed it before or after making the release.
The others are all on my screen at home for me to look at.
Comment 5 Robert Pearce 2022-03-05 09:45:18 UTC
Created attachment 766328 [details]
Updated ebuild for new release

I've released version 1.3.8 upstream, which additionally fixes bug 832303 and bug 580458, as well as some other issues no identified as Gentoo bugs. This is the new ebuild
Comment 6 Robert Pearce 2022-03-05 09:46:23 UTC
Created attachment 766329 [details, diff]
Revised patch for Gentoo-friendly config file

The upstream config file has some formatting changes so the Gentoo-isation patch needed a tweak
Comment 7 Robert Pearce 2022-11-21 08:22:46 UTC
Created attachment 835361 [details]
Another updated ebuild, for 1.3.9, with a small fix

Here's another ebuild, for a new release. It also has a minor bugfix - the "branding" prepare step was replacing the word "default" in a comment.
Comment 8 Robert Pearce 2022-11-21 08:24:31 UTC
Created attachment 835367 [details, diff]
Updated config file patch for 1.3.9 release

To go with the v1.3.9 release, the Gentoo-friendliness patch of the config file needs minor adjustment
Comment 9 Ștefan Talpalaru 2023-03-02 19:09:28 UTC
I added 1.4.0 to my overlay: https://github.com/stefantalpalaru/gentoo-overlay
Comment 10 Larry the Git Cow gentoo-dev 2023-03-14 19:30:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33127b6d177f2d123c333c239a4ca13bfafd8124

commit 33127b6d177f2d123c333c239a4ca13bfafd8124
Author:     Robert Pearce <gentoo@flitspace.org.uk>
AuthorDate: 2023-02-21 08:01:47 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2023-03-14 19:28:15 +0000

    x11-misc/slim: Added ebuilds for the resurrected upstream project
    
    Fixed issues from pkgcheck
    List myself as a proxy maintainer
    
    Correct several issues pointed out in review by ceamac and added a -9999 ebuild
    in light of discussion
    
    Closes: https://bugs.gentoo.org/832562
    Closes: https://bugs.gentoo.org/727544
    Closes: https://bugs.gentoo.org/832303
    Closes: https://bugs.gentoo.org/580458
    Closes: https://bugs.gentoo.org/803476
    Closes: https://bugs.gentoo.org/732430
    Closes: https://bugs.gentoo.org/756181
    Signed-off-by: Robert Pearce <gentoo@flitspace.org.uk>
    Closes: https://github.com/gentoo/gentoo/pull/29838
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 x11-misc/slim/Manifest                             |   2 +
 x11-misc/slim/files/slim-1.3.9-config.diff         |  49 ++++++++++
 .../slim/files/slim-1.3.9-greeter-session.diff     |  12 +++
 x11-misc/slim/files/slim-1.4.0-config.diff         |  48 ++++++++++
 x11-misc/slim/metadata.xml                         |  11 ++-
 x11-misc/slim/slim-1.3.9.ebuild                    |  98 +++++++++++++++++++
 x11-misc/slim/slim-1.4.0.ebuild                    | 104 +++++++++++++++++++++
 x11-misc/slim/slim-9999.ebuild                     | 104 +++++++++++++++++++++
 8 files changed, 426 insertions(+), 2 deletions(-)