Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 832552 - net-misc/oidc-agent-4.2.6 fails to compile: argp.h:546: undefined reference to argp_state_help
Summary: net-misc/oidc-agent-4.2.6 fails to compile: argp.h:546: undefined reference t...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo musl team
URL: https://github.com/indigo-dc/oidc-age...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-02-02 08:03 UTC by Agostino Sarubbo
Modified: 2022-02-03 18:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,194.05 KB, text/plain)
2022-02-02 08:03 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-02-02 08:03:16 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: net-misc/oidc-agent-4.2.6 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc
Comment 1 Agostino Sarubbo gentoo-dev 2022-02-02 08:03:19 UTC
Created attachment 764180 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-02-02 08:03:20 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


/usr/include/argp.h:546: undefined reference to `argp_state_help'
/var/tmp/portage/net-misc/oidc-agent-4.2.6/work/oidc-agent-4.2.6/src/oidc-agent/oidc-agent_options.c:157: undefined reference to `argp_state_help'
/var/tmp/portage/net-misc/oidc-agent-4.2.6/work/oidc-agent-4.2.6/src/oidc-agent/oidcp/oidcp.c:56: undefined reference to `argp_parse'
collect2: error: ld returned 1 exit status
Comment 3 Marek Szuba archtester gentoo-dev 2022-02-03 17:14:01 UTC
As far as I can see there are three glibcisms in oidc-agent code:

* the aforementioned use of argp - solved by depending on sys-libs/argp-standalone and appending -largp to LDFLAGS (upstream build scripts do not use LIBS)

* the use of GNU extensions without explicitly defining _GNU_SOURCE - solved by appending -D_GNU_SOURCE to CFLAGS

* the use of internal glibc type "__sighandler_t" in one of the tools - solved by using "sighandler_t" instead

Have I missed anything, Musl people?
Comment 4 Larry the Git Cow gentoo-dev 2022-02-03 17:31:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bcc6a6173c0312eb7288092942412c4fd2f63740

commit bcc6a6173c0312eb7288092942412c4fd2f63740
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2022-02-03 17:29:59 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2022-02-03 17:30:57 +0000

    net-misc/oidc-agent: support building against musl
    
    Closes: https://bugs.gentoo.org/832552
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 net-misc/oidc-agent/files/oidc-agent-4.2.6_sighandler_t.patch | 11 +++++++++++
 net-misc/oidc-agent/oidc-agent-4.2.6.ebuild                   | 10 ++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-03 18:28:44 UTC
(In reply to Marek Szuba from comment #3)
> As far as I can see there are three glibcisms in oidc-agent code:
> 
> * the aforementioned use of argp - solved by depending on
> sys-libs/argp-standalone and appending -largp to LDFLAGS (upstream build
> scripts do not use LIBS)
> 
> * the use of GNU extensions without explicitly defining _GNU_SOURCE - solved
> by appending -D_GNU_SOURCE to CFLAGS
> 
> * the use of internal glibc type "__sighandler_t" in one of the tools -
> solved by using "sighandler_t" instead
> 
> Have I missed anything, Musl people?

lgtm