Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 832164 - app-admin/helm, app-emacs/helm and media-sound/helm share the same upstream tarball name
Summary: app-admin/helm, app-emacs/helm and media-sound/helm share the same upstream t...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-27 16:02 UTC by Agostino Sarubbo
Modified: 2022-11-27 18:25 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,38.96 KB, text/plain)
2022-01-27 16:02 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-01-27 16:02:26 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-admin/helm-3.8.0 fails to compile.
Discovered on: amd64 (internal ref: ci)

NOTE:
If you think this is a GCC-11 related issue, please block bug 732706.
Comment 1 Agostino Sarubbo gentoo-dev 2022-01-27 16:02:28 UTC
Created attachment 763753 [details]
build.log

build log and emerge --info
Comment 2 sg313 2022-01-28 09:29:33 UTC
The distfile seems to contain app-emacs/helm:

$ ebuild `equery which app-admin/helm` prepare
[...]
>>> Unpacking helm-3.8.0.tar.gz to /var/tmp/portage/app-admin/helm-3.8.0/work
 * Tidying go.mod/go.sum
go: go.mod file not found in current directory or any parent directory; see 'go help modules'
>>> Source unpacked in /var/tmp/portage/app-admin/helm-3.8.0/work
>>> Preparing source in /var/tmp/portage/app-admin/helm-3.8.0/work/helm-3.8.0 ...
>>> Source prepared.
$ ls /var/tmp/portage/app-admin/helm-3.8.0/work/helm-3.8.0
Cask              helm-command.el        helm-eshell.el           helm-grep.el      helm-mode.el         helm-source.el
COPYING           helm-config.el         helm-eval.el             helm-help.el      helm-multi-match.el  helm-sys.el
doc               helm-core-pkg.el       helm-external.el         helm-id-utils.el  helm-net.el          helm-tags.el
emacs-helm.sh     helm-dabbrev.el        helm-fd.el               helm-imenu.el     helm-occur.el        helm-types.el
helm-adaptive.el  helm-easymenu.el       helm-files.el            helm-info.el      helm-pkg.el          helm-utils.el
helm-bookmark.el  helm.el                helm-find.el             helm-lib.el       helm-regexp.el       helm-x-files.el
helm-buffers.el   helm-elisp.el          helm-font.el             helm-locate.el    helm-ring.el         images
helm-color.el     helm-elisp-package.el  helm-for-files.el        helm-man.el       helm-semantic.el     Makefile
helm-comint.el    helm-epa.el            helm-global-bindings.el  helm-misc.el      helm-shell.el        README.md
Comment 3 sg313 2022-01-28 09:37:57 UTC
Note that currently, both app-emacs/helm and app-admin/helm have ebuilds with version 3.8.0 in the tree.

Both ebuilds give the distfile the same name:

app-admin/helm/helm-3.8.0.ebuild:
  SRC_URI="https://github.com/helm/helm/archive/v${MY_PV}.tar.gz -> ${P}.tar.gz
    ${EGO_SUM_SRC_URI}"

app-emacs/helm/helm-3.8.0.ebuild:
  SRC_URI="https://github.com/emacs-helm/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"
Comment 4 Larry the Git Cow gentoo-dev 2022-01-28 16:14:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc16a9f88429b4b58e10060d348f7580e484837f

commit dc16a9f88429b4b58e10060d348f7580e484837f
Author:     William Hubbs <williamh@gentoo.org>
AuthorDate: 2022-01-28 16:12:42 +0000
Commit:     William Hubbs <williamh@gentoo.org>
CommitDate: 2022-01-28 16:14:14 +0000

    app-admin/helm: rename generated upstream tarball
    
    We have 3 packages named "helm" in the tree and they all use the same
    upstream tarball name.
    Starting with 3.8.0, I am renaming the upstream tarball on our mirrors.
    
    Bug: https://bugs.gentoo.org/832164
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: William Hubbs <williamh@gentoo.org>

 app-admin/helm/Manifest          | 2 +-
 app-admin/helm/helm-3.8.0.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 5 William Hubbs gentoo-dev 2022-01-28 16:23:54 UTC
I have fixed this for app-admin/helm, but we need to fix one of the
other packages.

I can do it if you want, or feel free to fix one then close this bug.

Thanks,

William
Comment 6 Ulrich Müller gentoo-dev 2022-01-28 19:42:52 UTC
(In reply to William Hubbs from comment #5)
> I have fixed this for app-admin/helm, but we need to fix one of the
> other packages.

Do we? Their version numbers seem to be distinct enough, 3.8.0 vs 0.9.0.

Note that this will also cause collisions if both packages install documentation in /usr/share/doc/${PF}/ (app-emacs/helm doesn't, though).
Comment 7 Ulrich Müller gentoo-dev 2022-11-27 18:25:11 UTC
Closing per comment #6. The tarball was renamed for app-admin/helm, and there is no collision for the other two packages.

(Also dropping the PMASKED keyword again, because it is confusing when only one of the packages is masked.)