Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 831728 - dev-libs/protobuf-3.19.1: fails to build on HPPA (error: static assertion failed 707 | static_assert(alignof(T) <= 8, "");)
Summary: dev-libs/protobuf-3.19.1: fails to build on HPPA (error: static assertion fai...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: HPPA Linux
: Normal normal
Assignee: Arfrever Frehtes Taifersar Arahesis
URL: https://github.com/protocolbuffers/pr...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-21 13:01 UTC by Sam James
Modified: 2022-01-29 16:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (file_831728.txt,26.96 KB, text/plain)
2022-01-21 13:01 UTC, Sam James
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-01-21 13:01:22 UTC
Created attachment 762997 [details]
build.log

/var/tmp/portage/dev-libs/protobuf-3.19.1/work/protobuf-3.19.1/src/google/protobuf/descriptor.cc: In instantiation of ‘T* google::protobuf::{anonymous}::TableArena::Create(Args&& ...) [with T = google::protobuf::FileDescriptorTables; Args = {}]’:
/var/tmp/portage/dev-libs/protobuf-3.19.1/work/protobuf-3.19.1/src/google/protobuf/descriptor.cc:1868:46:   required from here
/var/tmp/portage/dev-libs/protobuf-3.19.1/work/protobuf-3.19.1/src/google/protobuf/descriptor.cc:707:30: error: static assertion failed
  707 |     static_assert(alignof(T) <= 8, "");
      |                   ~~~~~~~~~~~^~~~
/bin/sh ../libtool  --tag=CXX   --mode=compile hppa2.0-unknown-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I/var/tmp/portage/dev-libs/protobuf-3.19.1/work/protobuf-3.19.1/src -I..   -DGOOGLE_PROTOBUF_NO_RTTI -pthread -DHAVE_PTHREAD=1 -DHAVE_ZLIB=1 -Wall -Wno-sign-compare  -O2 -pipe -march=2.0 -fdiagnostics-color=always -frecord-gcc-switches -c -o google/protobuf/duration.pb.lo /var/tmp/portage/dev-libs/protobuf-3.19.1/work/protobuf-3.19.1/src/google/protobuf/duration.pb.cc
make[2]: *** [Makefile:4145: google/protobuf/descriptor.lo] Error 1
make[2]: *** Waiting for unfinished jobs....

----
Portage 3.0.28 (python 3.9.9-final-0, default/linux/hppa/17.0, gcc-10.3.0, glibc-2.33-r7, 5.10.88 parisc64)
=================================================================
System uname: Linux-5.10.88-parisc64-PA8900_-Shortfin-with-glibc2.33
KiB Mem:     8224044 total,   5055524 free
KiB Swap:    4194300 total,   4194300 free
Timestamp of repository gentoo: Fri, 21 Jan 2022 12:14:56 +0000
Head commit of repository gentoo: 53d117daf2cfab4626d6c00f772e9f830e9734b8

Timestamp of repository sam_c: Sun, 16 Jan 2022 01:21:33 +0000
Head commit of repository sam_c: 64323b77b96cfd2a7ad5e359be0503fdb64dfe70

sh dash 0.5.11.5
ld GNU ld (Gentoo 2.37_p1 p0) 2.37
app-misc/pax-utils:        1.3.3::gentoo
app-shells/bash:           5.1_p8::gentoo
dev-lang/perl:             5.34.0-r6::gentoo
dev-lang/python:           3.9.9-r1::gentoo, 3.10.0_p1-r1::gentoo
dev-util/meson:            0.59.4::gentoo
sys-apps/baselayout:       2.7-r3::gentoo
sys-apps/openrc:           0.44.10::gentoo
sys-apps/sandbox:          2.25::gentoo
sys-devel/autoconf:        2.69-r5::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.4::gentoo
sys-devel/binutils:        2.37_p1::gentoo
sys-devel/binutils-config: 5.4::gentoo
sys-devel/gcc:             10.3.0-r2::gentoo, 11.2.0::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.6-r6::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.33-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/gentoo.git
    priority: -1000
    eclass-overrides: local sam_c
    sync-git-verify-commit-signature: yes
    sync-git-clone-extra-opts: -b stable -c gc.reflogExpire=0 -c gc.reflogExpireUnreachable=0 -c gc.rerereresolved=0 -c gc.rerereunresolved=0 -c gc.pruneExpire=now

local
    location: /var/db/repos/local
    masters: gentoo
    eclass-overrides: local sam_c

sam_c
    location: /var/db/repos/sam_c
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/sam_c.git
    masters: gentoo
    eclass-overrides: local sam_c

ACCEPT_KEYWORDS="hppa"
ACCEPT_LICENSE="@FREE"
CBUILD="hppa2.0-unknown-linux-gnu"
CFLAGS="-O2 -pipe -march=2.0 -fdiagnostics-color=always -frecord-gcc-switches"
CHOST="hppa2.0-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=2.0 -fdiagnostics-color=always -frecord-gcc-switches"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -march=2.0 -fdiagnostics-color=always -frecord-gcc-switches"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=2.0 -fdiagnostics-color=always -frecord-gcc-switches"
GENTOO_MIRRORS="http://mirror.bytemark.co.uk/gentoo/ http://www.mirrorservice.org/sites/distfiles.gentoo.org/ http://mirrors.soeasyto.com/distfiles.gentoo.org/ http://mirrors.gethosted.online/gentoo"
LANG="en_GB.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0"
LINGUAS="en en_GB"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="PIC acl bash-completion big-endian bzip2 caps cli crypt filecaps firewalld fortran gdbm gmp hardened hppa hunspell iconv ipv6 libglvnd ncurses nls nptl openmp pam pcre pie readline seccomp split-usr ssl system-av1 system-binutils system-boost system-bootstrap system-cairo system-clang system-digest system-ffmpeg system-harfbuzz system-heimdal system-icu system-jpeg system-leveldb system-libevent system-libs system-libyaml system-lz4 system-mitkrb5 system-sqlite system-ssl system-tbb system-uulib system-webp system-zlib unicode verify-sig wayland xattr zlib zsh-completion" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en en-GB" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="fbdev dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, MAKEOPTS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 David Seifert gentoo-dev 2022-01-21 20:29:47 UTC
on my Ryzen:
alignof(std::mutex):      8
alignof(pthread_mutex_t): 8
alignof(max_align_t):     16

on a HP C8000:
alignof(std::mutex):      16
alignof(pthread_mutex_t): 16
alignof(max_align_t):     8

That is, on HPPA any struct/class that includes a std::mutex as member automatically becomes an over-aligned type. Over-aligned types have a history of being hard to deal with in C and C++, because std::malloc only guarantees the alignment of its returned pointer to alignof(std::max_align_t). As such, up to and including C++14, such types could not be used in standard containers like std::vector, as they lacked the mechanisms to request correctly aligned memory for such types (C++17 has fixed this).

The alignment to 16 bytes is not a bug, this is due to PA-RISC's requirement for 16 byte aligned words and doublewords for memory locking (https://parisc.wiki.kernel.org/images-parisc/7/73/Parisc2.0.pdf, p106 last paragraph).

I have tried protobuf by just sed'ing out the offending static_assert on a C8000, and the code compiled fine for me. I haven't done any in-depth tests to check whether the code works fine.
Comment 2 Larry the Git Cow gentoo-dev 2022-01-29 15:20:05 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f96bd0cd2896fc8ea3a83404c90acd7a76991367

commit f96bd0cd2896fc8ea3a83404c90acd7a76991367
Author:     Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
AuthorDate: 2022-01-22 02:00:00 +0000
Commit:     Yixun Lan <dlan@gentoo.org>
CommitDate: 2022-01-29 15:19:12 +0000

    dev-libs/protobuf: Delete static assertion failing on HPPA.
    
    Closes: https://bugs.gentoo.org/831728
    Signed-off-by: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
    Signed-off-by: Yixun Lan <dlan@gentoo.org>

 dev-libs/protobuf/protobuf-3.18.2.ebuild | 3 +++
 dev-libs/protobuf/protobuf-3.19.3.ebuild | 3 +++
 2 files changed, 6 insertions(+)
Comment 3 Larry the Git Cow gentoo-dev 2022-01-29 15:56:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34bbc3007bfdb78941fd5f23f97ff2c6c2b3a73f

commit 34bbc3007bfdb78941fd5f23f97ff2c6c2b3a73f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-01-29 15:55:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-01-29 15:55:59 +0000

    dev-libs/protobuf: mark broken HPPA versions as -hppa
    
    Newer versions are fixed but let's do this to avoid accidentally upgrading
    to them on HPPA systems. 3.19.3 is fine.
    
    Bug: https://bugs.gentoo.org/831728
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/protobuf/protobuf-3.18.2.ebuild | 3 ++-
 dev-libs/protobuf/protobuf-3.19.1.ebuild | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2022-01-29 16:14:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05b7b53f41c8719fb84b8b1efcf8904c031b21d4

commit 05b7b53f41c8719fb84b8b1efcf8904c031b21d4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-01-29 16:14:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-01-29 16:14:32 +0000

    dev-python/protobuf-python: mark -hppa fo 3.18.2/3.19.1 to match protobuf
    
    Bug: https://bugs.gentoo.org/831728
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-python/protobuf-python/protobuf-python-3.18.2.ebuild | 2 +-
 dev-python/protobuf-python/protobuf-python-3.19.1.ebuild | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)