Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 831356 - dev-python/js2py-0.71 - Test phase succeeds even when test failures occur
Summary: dev-python/js2py-0.71 - Test phase succeeds even when test failures occur
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Maciej Barć
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-01-17 13:49 UTC by James Le Cuirot
Modified: 2024-06-24 23:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2022-01-17 13:49:46 UTC
I ran the tests on m68k, where they were many failures, but the package installed anyway. Seemingly the exit status from run.py cannot be trusted.

The ebuild also creates a file called node_failed.txt to write the failures to, but this file remained empty. Instead, another file called failed.txt was populated with the failures. I therefore don't think the "touch" line is needed any more.
Comment 1 Alex Fan archtester 2022-01-19 07:04:31 UTC
I ran into the same issue on amd64 and riscv.
Comment 2 Larry the Git Cow gentoo-dev 2024-06-24 23:01:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a103afad637fb46659a8b1d6ef048be8721b13b

commit 2a103afad637fb46659a8b1d6ef048be8721b13b
Author:     Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
AuthorDate: 2024-06-24 22:32:22 +0000
Commit:     Maciej Barć <xgqt@gentoo.org>
CommitDate: 2024-06-24 23:01:45 +0000

    dev-python/js2py: revbump to 0.74-r1
    
    These changes:
      - fix CVE-2024-28397
      - fix ignoring of test failures
      - restrict the test feature since
        multiple tests are broken
    
    Bug: https://bugs.gentoo.org/831356
    Signed-off-by: Aliaksei Urbanski <aliaksei.urbanski@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/37285
    Signed-off-by: Maciej Barć <xgqt@gentoo.org>

 .../js2py/files/js2py-0.74-CVE-2024-28397.patch    | 21 +++++++++++++++++++
 .../{js2py-0.74.ebuild => js2py-0.74-r1.ebuild}    | 24 ++++++++++++++--------
 2 files changed, 36 insertions(+), 9 deletions(-)