Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 831327 - sys-apps/fwupd-1.7.4[uefi] does not builds with sys-libs/efivar-38
Summary: sys-apps/fwupd-1.7.4[uefi] does not builds with sys-libs/efivar-38
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-16 19:34 UTC by Piotr Karbowski (RETIRED)
Modified: 2022-01-17 16:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Karbowski (RETIRED) gentoo-dev 2022-01-16 19:34:27 UTC
Relevant part of build log

In file included from ../fwupd-1.7.4/plugins/uefi-capsule/fu-plugin-uefi-capsule.c:19:
../fwupd-1.7.4/plugins/uefi-capsule/fu-uefi-common.h:32:3: error: conflicting types for ‘efi_time_t’; have ‘struct <anonymous>’
   32 | } efi_time_t;
      |   ^~~~~~~~~~
In file included from /usr/include/efivar/efivar.h:21,
                 from ../fwupd-1.7.4/plugins/uefi-capsule/fu-uefi-bootmgr.h:12,
                 from ../fwupd-1.7.4/plugins/uefi-capsule/fu-plugin-uefi-capsule.c:17:
/usr/include/efivar/efivar-types.h:81:3: note: previous declaration of ‘efi_time_t’ with type ‘efi_time_t’
   81 | } efi_time_t __attribute__((__aligned__(1)));
      |   ^~~~~~~~~~


Downgrade to sys-libs/efivar-37 let it being built.
Comment 1 Mike Gilbert gentoo-dev 2022-01-16 20:24:34 UTC
This should be reported upstream to the fwupd developers.

As a temporary workaround, we could add "-DEFIVAR_NO_EFI_TIME_T=1" to CFLAGS/CPPFLAGS to disable the new header in efivar.

https://github.com/rhboot/efivar/commit/011f3e5212d4bde5f651795435ccf0f77bd2633d
Comment 2 Mike Gilbert gentoo-dev 2022-01-16 20:25:40 UTC
To clarify, we could add "-DEFIVAR_NO_EFI_TIME_T=1" to CFLAGS/CPPFLAGS in the fwupd ebuild. This would disable the new functionality in efivar's headers.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2022-01-16 21:09:38 UTC
(In reply to Mike Gilbert from comment #1)
> This should be reported upstream to the fwupd developers.

Thanks, done.
Comment 4 Larry the Git Cow gentoo-dev 2022-01-17 16:08:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79dabb3646d62da12da567c70b2ca83f328b2574

commit 79dabb3646d62da12da567c70b2ca83f328b2574
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2022-01-17 16:07:24 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2022-01-17 16:08:07 +0000

    sys-apps/fwupd: Fixed build against sys-libs/efivar-38
    
    Closes: https://bugs.gentoo.org/831327
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-apps/fwupd/files/fwupd-1.7.4-efivar38.patch | 55 +++++++++++++++++++++++++
 sys-apps/fwupd/fwupd-1.7.4.ebuild               |  4 ++
 2 files changed, 59 insertions(+)