Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830841 - media-sound/pulseaudio with USE="equalizer" should depends on PyQt5 and dbus-python
Summary: media-sound/pulseaudio with USE="equalizer" should depends on PyQt5 and dbus-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Igor V. Kovalenko
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-01-09 11:22 UTC by Francois Chenier
Modified: 2023-03-22 01:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francois Chenier 2022-01-09 11:22:08 UTC
When we compile media-sound/pulseaudio with USE="equalizer", generated file /usr/bin/qpaeq (the equalizer frontend) depends on dev-python/PyQt5 and dev-python/dbus-python. Trivial finding ...

belgix@darwin ~ $ cat /usr/bin/qpaeq | head -n 30
#!/usr/bin/env python3
#    qpaeq is a equalizer interface for pulseaudio's equalizer sinks
#    Copyright (C) 2009  Jason Newton <nevion@gmail.com
#
#    This program is free software: you can redistribute it and/or modify
#    it under the terms of the GNU Lesser General Public License as
#    published by the Free Software Foundation, either version 2.1 of the
#    License, or (at your option) any later version.
#
#    This program is distributed in the hope that it will be useful,
#    but WITHOUT ANY WARRANTY; without even the implied warranty of
#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
#    GNU Lesser General Public License for more details.
#
#    You should have received a copy of the GNU Lesser General Public License
#    along with this program.  If not, see <http://www.gnu.org/licenses/>.


import os,math,sys
try:
    from PyQt5 import QtWidgets,QtCore
    import dbus.mainloop.pyqt5
    import dbus
except ImportError as e:
    sys.stderr.write('There was an error importing needed libraries\n'
                     'Make sure you have qt5 and dbus-python installed\n'
                     'The error that occurred was:\n'
                     '\t%s\n' % (str(e)))
    sys.exit(-1)


Reproducible: Always
Comment 1 Sergey Okhapkin 2022-07-08 20:06:33 UTC
Also the ebuild 16.X doesn't install qpaeq because it runs with -Dclient=false option, but /src/utils/meson.build installs qpaeq only if

if get_option('client')

How to install qpaeq in the right gentoo way?
Comment 2 Igor V. Kovalenko 2022-07-08 21:28:02 UTC
(In reply to Sergey Okhapkin from comment #1)
> Also the ebuild 16.X doesn't install qpaeq because it runs with
> -Dclient=false option, but /src/utils/meson.build installs qpaeq only if
> 
> if get_option('client')
> 
> How to install qpaeq in the right gentoo way?
Yep looks like a bug in meson buildsys, as there is no point in installing quapeq for client-only build because it will need pulseaudio daemon modules to be loaded.
Comment 4 Larry the Git Cow gentoo-dev 2022-12-24 07:11:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fda42b7c24ba9f541849772cb5a967d17f5ad04

commit 3fda42b7c24ba9f541849772cb5a967d17f5ad04
Author:     Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
AuthorDate: 2022-12-13 16:11:58 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-24 07:07:01 +0000

    media-sound/pulseaudio-daemon: Add missing USE equalizer deps
    
    Closes: https://bugs.gentoo.org/830841
    Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/28654
    Signed-off-by: Sam James <sam@gentoo.org>

 ...io-daemon-16.1-r4.ebuild => pulseaudio-daemon-16.1-r5.ebuild} | 9 +++++++++
 profiles/arch/ia64/package.use.mask                              | 4 ++++
 profiles/arch/sparc/package.use.mask                             | 4 ++++
 3 files changed, 17 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2022-12-24 10:21:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7006e072472fdfb33880c81bb9559a350508ed1c

commit 7006e072472fdfb33880c81bb9559a350508ed1c
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-24 10:20:18 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-24 10:21:11 +0000

    Revert "media-sound/pulseaudio-daemon: Add missing USE equalizer deps"
    
    This reverts commit 3fda42b7c24ba9f541849772cb5a967d17f5ad04.
    
    I'd missed a comment from leio in linked PR which means we need
    to rework this.
    
    Bug: https://bugs.gentoo.org/830841
    Closes: https://bugs.gentoo.org/888131
    Closes: https://github.com/gentoo/gentoo/pull/28779
    See: https://github.com/gentoo/gentoo/pull/28654
    Signed-off-by: Sam James <sam@gentoo.org>

 ...io-daemon-16.1-r5.ebuild => pulseaudio-daemon-16.1-r6.ebuild} | 9 ---------
 profiles/arch/ia64/package.use.mask                              | 4 ----
 profiles/arch/sparc/package.use.mask                             | 4 ----
 3 files changed, 17 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-03-22 01:20:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6bb66e860c04c330b99fb94df3a9df4eb3e9e6ca

commit 6bb66e860c04c330b99fb94df3a9df4eb3e9e6ca
Author:     Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
AuthorDate: 2022-12-24 12:02:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-03-22 01:19:03 +0000

    media-sound/qpaeq: new package, add 16.1
    
    Split qpaeq from media-sound/pulseaudio-daemon to own package.
    
    Closes: https://bugs.gentoo.org/830841
    Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/28782
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/qpaeq/Manifest          |  1 +
 media-sound/qpaeq/metadata.xml      | 16 ++++++++++
 media-sound/qpaeq/qpaeq-16.1.ebuild | 60 +++++++++++++++++++++++++++++++++++++
 3 files changed, 77 insertions(+)