Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830671 - media-fonts/fonts-meta: add "emoji" use flag
Summary: media-fonts/fonts-meta: add "emoji" use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alexey
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2022-01-06 08:00 UTC by Joonas Niilola
Modified: 2022-03-05 07:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joonas Niilola gentoo-dev 2022-01-06 08:00:23 UTC
I'd like to add "emoji" use flag with
  || (
  	media-fonts/noto-emoji
  	media-fonts/joypixels
  )

However noto-emoji is currently under "free" fonts, and joypixel's license is a bit... restrictive to say the least. I wonder what's the right approach here.
  emoji? (
  	free? ( media-fonts/noto-emoji )
  	!free? ( media-fonts/joypixels )
  )

(feel like this is an overcomplication, but would work)

We'll need to stabilize joypixels first though, and why not bump to latest version while at it.
Comment 1 Alexey 2022-01-06 11:28:51 UTC
Why does it need to be one or another?

"!free?" is a different meaning than what USE=free does now in fonts-meta. If you want to install joypixels, no need to remove all the other free fonts. In fact, joypixels and noto-emoji could be installed in parallel, to be able to select via fontconfig which icons to use for every code point.

Maybe something like this?

emoji? (
    free? ( media-fonts/noto-emoji )
    nonfree? ( media-fonts/joypixels )
)
Comment 2 Joonas Niilola gentoo-dev 2022-01-08 13:57:02 UTC
(In reply to Alexey from comment #1)
> Why does it need to be one or another?
> 
> "!free?" is a different meaning than what USE=free does now in fonts-meta.
> If you want to install joypixels, no need to remove all the other free
> fonts. 

We wouldn't touch the contents of other deps in "free? ( .. )", just take noto-emoji out and place it under "emoji? ( .. )"  instead. So something like:

emoji? || (
	media-fonts/noto-emoji
  	media-fonts/joypixels
)
free? (
	media-fonts/heuristica
	media-fonts/liberation-fonts
	media-fonts/noto
	media-fonts/wqy-microhei
	latin? (
		...


> In fact, joypixels and noto-emoji could be installed in parallel, to
> be able to select via fontconfig which icons to use for every code point.

They still could, obviously, just need a manual emerge for one or another. 

> 
> Maybe something like this?
> 
> emoji? (
>     free? ( media-fonts/noto-emoji )
>     nonfree? ( media-fonts/joypixels )
> )

I like the idea of "nonfree", to be expanded outside joypixels, though.
Comment 3 Joonas Niilola gentoo-dev 2022-01-08 13:58:18 UTC
(In reply to Joonas Niilola from comment #2)
> (In reply to Alexey from comment #1)

> emoji? || (
> 	media-fonts/noto-emoji
>   	media-fonts/joypixels
> )

This should've been the 

  emoji? (
  	free? ( media-fonts/noto-emoji )
  	!free? ( media-fonts/joypixels )
  )

example instead.
Comment 4 Alexey 2022-01-08 14:01:48 UTC
My problem with "!free?" is that to be able to install joypixels via fonts-meta, the user will need to set USE=-free, therefore removing media-fonts/heuristica and the rest of free fonts, making fonts-meta useless.
Comment 5 Joonas Niilola gentoo-dev 2022-01-08 14:06:07 UTC
That's a good point, I guess the whole ebuild should be reworked so it installs some core stuff by default without any USEs. (I kind of thought it did just that)
Comment 6 Alexey 2022-01-08 14:31:24 UTC
Yeah. I'm not sure if there is any need for IUSE=free at all.
Comment 7 Larry the Git Cow gentoo-dev 2022-03-05 07:20:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bd5c593709347ae78f063d377251bcfa6b5f6a88

commit bd5c593709347ae78f063d377251bcfa6b5f6a88
Author:     Joonas Niilola <juippis@gentoo.org>
AuthorDate: 2022-02-26 14:52:40 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2022-03-05 07:20:45 +0000

    media-fonts/fonts-meta: bump to v2
    
     - add more latin fonts, remove some personally preferred options,
     - add l10n_ru for a minimal cyrillic support,
     - combine japan, korean and chinese fonts under 'cjk' for tree
       consistency,
     - drop "free" USE flag and provide some of the "core" fonts under
       'latin' USE. May be subject to change.
    
    Closes: https://bugs.gentoo.org/830671
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/24361

 media-fonts/fonts-meta/fonts-meta-2.ebuild | 126 +++++++++++++++++++++++++++++
 media-fonts/fonts-meta/metadata.xml        |   1 +
 2 files changed, 127 insertions(+)