Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830578 - [kde overlay] kde-frameworks/krunner-9999 broken due to 1cc0d3e34
Summary: [kde overlay] kde-frameworks/krunner-9999 broken due to 1cc0d3e34
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Overlays (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL: https://invent.kde.org/frameworks/kru...
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks:
 
Reported: 2022-01-04 08:24 UTC by Duncan
Modified: 2022-11-16 18:38 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2022-01-04 08:24:47 UTC
gentoo/kde's:

* commit 1cc0d3e34
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: Mon Jan 3 15:39:54 2022 +0100
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: Mon Jan 3 15:40:03 2022 +0100

    kde-frameworks/krunner: Set EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.73.0

    Fixes build. See also upstream commit
    1b1e11882d1733165450554f3e3cf1688a88d636

... broke building plasma-workspace, plasma-desktop and kdeplasma-addons.  I originally filed it as an upstream bug:

https://bugs.kde.org/show_bug.cgi?id=447908

... but then got thinking about the above commit and decided to try reversing it.  Sure enough, after a quick manual test revert to the previous 5.65.0 and rebuilding krunner (framework), plasma-workspace built again, and I expect the others will as well.

So I RESOLVED/DOWNSTREAM the kde bug and (after a sync didn't pull down anything further for the kde overlay) am filing this one.  Seems we either jumped the gun a bit and the three three plasma-related packages listed above aren't ready for it (yet), or they need a gentoo/kde-side fix to match the above gentoo/kde-side commit to krunner.

Here's the first plasma-workspace build error.  See the kde bug for the others.

FAILED: runners/sessions/CMakeFiles/krunner_sessions.dir/sessionrunner.cpp.o 
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DKCOREADDONS_LIB
-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x055800
-DKITEMMODELS_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054F00
-DKPLUGINFACTORY_PLUGIN_CLASS_INTERNAL_NAME=krunner_sessions_factory
-DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0x050f00
-DQT_GUI_LIB -DQT_NO_DEBUG -DQT_NO_URL_CAST_FROM_STRING -DQT_WIDGETS_LIB
-DTRANSLATION_DOMAIN=\"plasma_runner_sessions\" -D_GNU_SOURCE
-D_LARGEFILE64_SOURCE -Dkrunner_sessions_EXPORTS
-I/tmp/portage/kde-plasma/plasma-workspace-9999/work/plasma-workspace-9999_build/runners/sessions
-I/tmp/portage/kde-plasma/plasma-workspace-9999/work/plasma-workspace-9999/runners/sessions
-I/tmp/portage/kde-plasma/plasma-workspace-9999/work/plasma-workspace-9999_build/runners/sessions/krunner_sessions_autogen/include
-I/tmp/portage/kde-plasma/plasma-workspace-9999/work/plasma-workspace-9999_build
-isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem
/usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore -isystem
/usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtDBus -isystem
/usr/include/KF5/KRunner -isystem /usr/include/KF5 -isystem
/usr/include/KF5/KI18n -isystem /usr/include/kworkspace5 -isystem
/usr/include/KF5/KCoreAddons  -DQT_NO_DEBUG -march=native -O2 -fgcse-sm
-fgcse-las -fgcse-after-reload -ftree-vectorize -fdiagnostics-color
-fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align
-Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith-Wundef
-Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Werror=init-self
-Wvla -Wdate-time -Wsuggest-override -Wlogical-op -fdiagnostics-color=always
-fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=gnu++17 -MD
-MT runners/sessions/CMakeFiles/krunner_sessions.dir/sessionrunner.cpp.o -MF
runners/sessions/CMakeFiles/krunner_sessions.dir/sessionrunner.cpp.o.d -o
runners/sessions/CMakeFiles/krunner_sessions.dir/sessionrunner.cpp.o -c
/tmp/portage/kde-plasma/plasma-workspace-9999/work/plasma-workspace-9999/runners/sessions/sessionrunner.cpp
In file included from
/tmp/portage/kde-plasma/plasma-workspace-9999/work/plasma-workspace-9999/runners/sessions/sessionrunner.h:10,
from
/tmp/portage/kde-plasma/plasma-workspace-9999/work/plasma-workspace-9999/runners/sessions/sessionrunner.cpp:7:
/include/KF5/KRunner/krunner/abstractrunner.h:14:10: fatal error: KConfigGroup:
No such file or directory
14 | #include <KConfigGroup>
Comment 1 Andreas Sturmlechner gentoo-dev 2022-01-04 12:28:02 UTC
Thanks for testing. I'll see if I can fix those revdeps in time for KF-5.90 release, otherwise revert the option.
Comment 2 Andreas Sturmlechner gentoo-dev 2022-01-04 12:45:44 UTC
Looks like someone already started working on your upstream bug.
Comment 3 Larry the Git Cow gentoo-dev 2022-01-04 14:48:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=6af1705ac2969bf72a93c34078befbc8c9af899c

commit 6af1705ac2969bf72a93c34078befbc8c9af899c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-01-04 14:45:57 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-01-04 14:47:53 +0000

    kde-frameworks/krunner: Revert excluding deprecations for 5.90.0
    
    Breaking revdeps in this version without further patching and thus
    not sensible in a stable candidate release. Revisit for >=5.91.
    
    Bug: https://bugs.gentoo.org/830578
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-frameworks/krunner/krunner-5.90.0.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Andreas Sturmlechner gentoo-dev 2022-01-04 14:56:59 UTC
I have kept 9999 as-is for the time being so you get the chance to test MR #85 once landed upstream. Bonus points for testing -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.91.0 when that happens, as it seems it would enable us to get rid of KIO and KService dependencies as well.
Comment 5 Andreas Sturmlechner gentoo-dev 2022-01-04 20:18:35 UTC
(merged upstream now)
Comment 6 Larry the Git Cow gentoo-dev 2022-01-08 21:14:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=c23498f241a10c039210adec528c2701768f595d

commit c23498f241a10c039210adec528c2701768f595d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-01-08 15:00:00 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-01-08 21:14:14 +0000

    kde-frameworks/krunner: Revert -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.73.0
    
    For lack of testing reports and further upstream changes making this
    dependency change obsolete. Revisit some time in >=5.91.
    
    Closes: https://bugs.gentoo.org/830578
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-frameworks/krunner/krunner-9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Larry the Git Cow gentoo-dev 2022-11-06 21:49:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=bf0d465deef8241521754f9029d4be4cd6b1ecab

commit bf0d465deef8241521754f9029d4be4cd6b1ecab
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-11-06 21:05:28 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-11-06 21:19:20 +0000

    kde-frameworks/krunner: Set -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.91.0
    
    Allows us to drop kde-frameworks/kio, kde-frameworks/kservice,
    kde-frameworks/plasma, upstream commit fcc5502d2b71714c6ce823341b176d5e5da5f029
    
    Bug: https://bugs.gentoo.org/830578
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-frameworks/krunner/krunner-9999.ebuild | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Comment 8 Larry the Git Cow gentoo-dev 2022-11-16 18:38:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=57f5d0660fd51250279709ec2ffe5eee07d968d2

commit 57f5d0660fd51250279709ec2ffe5eee07d968d2
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2022-11-16 18:36:38 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2022-11-16 18:37:53 +0000

    kde-frameworks/krunner: Revert -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.91.0
    
    Too many issues.
    
    This reverts commit bf0d465deef8241521754f9029d4be4cd6b1ecab.
    
    Bug: https://bugs.gentoo.org/830578
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-frameworks/krunner/krunner-9999.ebuild | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)