Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 830520 - dev-libs/serdisplib-2.02-r1 fails to compile: serdisp_gpevents.h:75:18: error: expected identifier or ( before unsigned
Summary: dev-libs/serdisplib-2.02-r1 fails to compile: serdisp_gpevents.h:75:18: error...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Conrad Kostecki
URL: https://sourceforge.net/p/serdisplib/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-01-03 09:38 UTC by Agostino Sarubbo
Modified: 2022-02-11 14:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,48.77 KB, text/plain)
2022-01-03 09:38 UTC, Agostino Sarubbo 		Details
serdisplib-2.02-musl.patch (serdisplib-2.02-musl.patch,954 bytes, patch)
2022-02-10 21:09 UTC, Conrad Kostecki 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-01-03 09:38:30 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-libs/serdisplib-2.02-r1 fails to compile.
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc
Comment 1 Agostino Sarubbo gentoo-dev 2022-01-03 09:38:32 UTC 
Created attachment 761187 [details]
build.log

build log and emerge --info
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-02-09 13:20:31 UTC 
../include/serdisplib/serdisp_gpevents.h:75:18: error: expected identifier or '(' before 'unsigned'
   75 |   #define ushort unsigned short
      |                  ^~~~~~~~

They should just ditch 'ushort' and write 'unsigned short' everywhere.
Comment 3 Conrad Kostecki gentoo-dev 2022-02-10 21:09:40 UTC 
Created attachment 764809 [details, diff]
serdisplib-2.02-musl.patch
Comment 4 Conrad Kostecki gentoo-dev 2022-02-11 14:46:09 UTC 
Proposed patch by floppym: https://gist.github.com/floppym/689f380b8f1e8bd08207c8c7aa18038f
Comment 5 Larry the Git Cow gentoo-dev 2022-02-11 14:53:19 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=28147e538fd61399ba364a65bc51a12289e622ff

commit 28147e538fd61399ba364a65bc51a12289e622ff
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2022-02-11 14:49:08 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2022-02-11 14:53:08 +0000

    dev-libs/serdisplib: fix compilation with musl
    
    Closes: https://bugs.gentoo.org/830520
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 dev-libs/serdisplib/files/serdisplib-2.02-musl.patch | 19 +++++++++++++++++++
 dev-libs/serdisplib/serdisplib-2.02-r2.ebuild        |  1 +
 2 files changed, 20 insertions(+)