Bug 829964 – media-gfx/krita-5.0.0: missing dependency on dev-qt/qtsql

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Doppler 2021-12-25 15:02:46 UTC]

When trying to build krita without the qtsql package, I end up with a build failure like this:

CMake Error at /usr/lib64/cmake/Qt5/Qt5Config.cmake:28 (find_package):
  Could not find a package configuration file provided by "Qt5Sql" with any
  of the following names:

    Qt5SqlConfig.cmake
    qt5sql-config.cmake

  Add the installation prefix of "Qt5Sql" to CMAKE_PREFIX_PATH or set
  "Qt5Sql_DIR" to a directory containing one of the above files.  If "Qt5Sql"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:348 (find_package)

It clearly indicates that the qtsql package should be installed. And, when performing a build after manually installing it, Qt5Sql is listed under "-- The following REQUIRED packages have been found:"

Reproducible: Always

Steps to Reproduce:
1. Attempt to install krita 5.0.0 on a system without qtsql pulled in as a dependency for some other software
Actual Results:  
qtsql is pulled in as a dependency and the build succeeds

Expected Results:  
The build fails due to a missing hard dependency

[Comment 1 Doppler 2021-12-25 19:35:41 UTC]

Created attachment 760201 [details, diff]
Fix

Fairly trivial, though this patch should do it.

[Comment 2 Doppler 2021-12-25 23:46:40 UTC]

Created attachment 760203 [details, diff]
Fix with no typoes

[Comment 3 Andreas Sturmlechner 2021-12-26 16:04:11 UTC]

Commit introducing it see URL, no idea yet what it is for.

[Comment 4 Andreas Sturmlechner 2021-12-27 14:20:25 UTC]

Seems to be related to slightly later commit 0e7683d3c0f74468f23270141c28f8c7fd8f2685, "Add begin of the resource cache db implementation".

[Comment 5 Larry the Git Cow 2021-12-28 17:01:45 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=04f7dbbabb01d1341f81f03ed1fba7307522e90e

commit 04f7dbbabb01d1341f81f03ed1fba7307522e90e
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2021-12-28 17:01:01 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2021-12-28 17:01:01 +0000

    media-gfx/krita: Add missing DEPEND
    
    Upstream commits:
    e544ef889f164e4db3021fab7942421c8798885b
    0e7683d3c0f74468f23270141c28f8c7fd8f2685
    
    Reported-by: Doppler <[e-mail]>
    Bug: https://bugs.gentoo.org/829964
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 media-gfx/krita/krita-9999.ebuild | 1 +
 1 file changed, 1 insertion(+)

[Comment 6 Larry the Git Cow 2021-12-29 16:34:57 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d9d5c938890de6f96c7754fe7b4827508f3cbe5

commit 5d9d5c938890de6f96c7754fe7b4827508f3cbe5
Author:     Andreas Sturmlechner <[e-mail]>
AuthorDate: 2021-12-28 17:01:01 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2021-12-29 15:41:22 +0000

    media-gfx/krita: Add missing DEPEND
    
    Upstream commits:
    e544ef889f164e4db3021fab7942421c8798885b
    0e7683d3c0f74468f23270141c28f8c7fd8f2685
    
    Reported-by: Doppler <[e-mail]>
    Bug: https://bugs.gentoo.org/829964
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 media-gfx/krita/krita-5.0.0.ebuild | 1 +
 1 file changed, 1 insertion(+)