Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 829261 - media-gfx/shotwell-0.30.14 rebuild fails with 'EXPORT_DIALOG_DEFAULT_SCALE' undeclared here
Summary: media-gfx/shotwell-0.30.14 rebuild fails with 'EXPORT_DIALOG_DEFAULT_SCALE' u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Nicolas Bock
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-15 12:26 UTC by Albert W. Hopkins
Modified: 2021-12-17 17:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log.gz (build.log.gz,18.14 KB, application/gzip)
2021-12-15 12:31 UTC, Albert W. Hopkins
Details
Workaround patch (shotwell-exportdialog-default-scale.patch,570 bytes, patch)
2021-12-17 00:29 UTC, Albert W. Hopkins
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Albert W. Hopkins 2021-12-15 12:26:35 UTC
Something (perhaps commit 2584db8) is causing shotwell to be rebuilt on a couple of my systems. However the rebuild fails with

```
...
[303/358] x86_64-pc-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.14/src -I../shotwell-0.30.14/vapi -Isrc/plugins -I../shotwell-0.30.14/src/plugins -I. -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/orc-0.4 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -march=native -mtune=tigerlake -pipe -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c
FAILED: src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o 
x86_64-pc-linux-gnu-gcc -Isrc/shotwell.p -Isrc -I../shotwell-0.30.14/src -I../shotwell-0.30.14/vapi -Isrc/plugins -I../shotwell-0.30.14/src/plugins -I. -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/gee-0.8 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/fribidi -I/usr/include/uuid -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/gio-unix-2.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/at-spi-2.0 -I/usr/include/gphoto2 -I/usr/include/libexif -I/usr/include/gstreamer-1.0 -I/usr/include/orc-0.4 -I/usr/include/gudev-1.0 -I/usr/include/libraw -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -DHAVE_CONFIG_H=1 -include config.h -O2 -march=native -mtune=tigerlake -pipe -pthread -MD -MQ src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -MF src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o.d -o src/shotwell.p/meson-generated_dialogs_ExportDialog.c.o -c src/shotwell.p/dialogs/ExportDialog.c
src/shotwell.p/dialogs/ExportDialog.c:146:43: error: 'EXPORT_DIALOG_DEFAULT_SCALE' undeclared here (not in a function); did you mean 'EXPORT_DIALOG_GET_CLASS'?
  146 | static gint export_dialog_current_scale = EXPORT_DIALOG_DEFAULT_SCALE;
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                           EXPORT_DIALOG_GET_CLASS
```

emerge --info:

```
Portage 3.0.30 (python 3.10.1-final-0, default/linux/amd64/17.1/no-multilib, gcc-11.2.1, glibc-2.34-r3, 5.15.8-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.15.8-gentoo-x86_64-Intel-R-_Xeon-R-_CPU_E5-2630_0_@_2.30GHz-with-glibc2.34
KiB Mem:    32877328 total,   1668152 free
KiB Swap:   13609976 total,  13606648 free
Timestamp of repository gentoo: Wed, 15 Dec 2021 12:03:15 +0000
Timestamp of repository marduk: Sat, 11 Dec 2021 22:52:10 +0000
sh bash 5.1_p12
ld GNU ld (Gentoo 2.37_p1 p1) 2.37
app-misc/pax-utils:        1.3.3::gentoo
app-shells/bash:           5.1_p12::gentoo
dev-lang/perl:             5.34.0-r5::gentoo
dev-lang/python:           3.9.9::gentoo, 3.10.1::gentoo
dev-lang/rust:             1.57.0::gentoo
dev-util/cmake:            3.22.1::gentoo
dev-util/meson:            0.60.2-r1::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          249.6-r1::gentoo
sys-devel/autoconf:        2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.37_p1-r1::gentoo
sys-devel/binutils-config: 5.4::gentoo
sys-devel/clang:           13.0.0::gentoo
sys-devel/gcc:             11.2.1_p20211127::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.6-r6::gentoo
sys-devel/lld:             13.0.0::gentoo
sys-devel/llvm:            13.0.0::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.34-r3::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://gbp/repos/lighthouse/gentoo
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: False
    sync-rsync-verify-max-age: 24

marduk
    location: /var/db/repos/marduk
    sync-type: rsync
    sync-uri: rsync://gbp/repos/lighthouse/marduk
    masters: gentoo
    priority: 50
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: False

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="@FREE @BINARY-REDISTRIBUTABLE Google-TOS google-chrome google-talkplugin"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="     -O2     -march=native     -mtune=tigerlake     -pipe "
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="     -O2     -march=native     -mtune=tigerlake     -pipe "
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="     --autounmask=n     --binpkg-changed-deps     --binpkg-respect-use     --buildpkg     --changed-deps=y     --color=y     --getbinpkg     --jobs=4     --keep-going     --oneshot     --quiet-build     --quiet-unmerge-warn     --rebuilt-binaries=y     --verbose-conflicts     --with-bdeps=n "
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg buildpkg-live config-protect-if-modified distlocks fixlafiles multilib-strict news noinfo notitles parallel-fetch preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms skiprocheck strict unknown-features-warn unmerge-logs unmerge-orphans xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="/usr/share/doc"
L10N="en"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="     --jobs=5     --load-average=5.64 "
PKGDIR="/var/cache/binpkgs"
PORTAGE_BINHOST="https://gbp/binpkgs/lighthouse/"
PORTAGE_COMPRESS=""
PORTAGE_COMPRESS_FLAGS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl aes amd64 asm avx avx2 avx512bw avx512cd avx512dq avx512f avx512vbmi avx512vl f16c fma3 glamor introspection ipv6 jpeg2k libglvnd mmx mmxext nls nptl opentype pam pclmul popcnt rdrand seccomp sha split-usr sse sse2 sse3 sse4_1 sse4_2 ssse3 systemd udev unicode urandom utf8 vaapi vulkan wayland xattr" ABI_X86="64" APACHE2_MODULES="auth_digest authn_core authn_file authz authz_core authz_groupfile authz_host authz_user dav dav_fs dir group_file mime socache_shmcb unixd" APACHE2_MPMS="prefork" CAMERAS="*" CPU_FLAGS_X86="aes avx avx2 avx512f avx512dq avx512cd avx512bw avx512vl avx512vbmi f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 ssse3" CURL_SSL="openssl" ELIBC="glibc" FFTOOLS="*" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en" LLVM_TARGETS="AArch64 AMDGPU ARM AVR BPF Hexagon Lanai MSP430 Mips NVPTX PowerPC RISCV Sparc SystemZ WebAssembly X86 XCore" LUA_SINGLE_TARGET="lua5-4" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9 python3_10" RUBY_TARGETS="ruby27 ruby30" USERLAND="GNU" VIDEO_CARDS="intel i965 iris"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, F77FLAGS, FC, GCOV, GPROF, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BUNZIP2_COMMAND, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SHELL, SIZE, STRINGS, STRIP, YACC, YFLAGS

=================================================================
                        Package Settings
=================================================================

media-gfx/shotwell-0.30.14::gentoo was built with the following:
USE="udev -opencv"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg config-protect-if-modified distlocks fixlafiles multilib-strict news noinfo notitles parallel-fetch preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms skiprocheck strict unknown-features-warn unmerge-logs unmerge-orphans xattr"
```
Comment 1 Albert W. Hopkins 2021-12-15 12:31:07 UTC
Created attachment 759146 [details]
build.log.gz
Comment 2 hangglider 2021-12-15 22:42:23 UTC
Same here - just got it to compile after taking the #define for EXPORT_DIALOG_DEFAULT_SCALE from line 150 to just before the failing line.
Comment 3 nathanlkoch 2021-12-16 23:22:37 UTC
Having same issue.
Comment 4 Albert W. Hopkins 2021-12-17 00:29:05 UTC
Created attachment 759379 [details, diff]
Workaround patch

Not *the* fix but this is my workaround user patch that gets it to build.
Comment 5 Mart Raudsepp gentoo-dev 2021-12-17 07:42:12 UTC
Looks like this fails with vala-0.52.8 only, whereas vala-0.52.7, 0.50.10 and 0.54.4 work fine
Comment 6 Larry the Git Cow gentoo-dev 2021-12-17 17:50:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0658e156d37df070621d9c49189289fcc26f9e8

commit a0658e156d37df070621d9c49189289fcc26f9e8
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2021-12-17 17:47:18 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2021-12-17 17:48:03 +0000

    media-gfx/shotwell: fix compatibility with vala-0.52.8
    
    Closes: https://bugs.gentoo.org/829261
    Package-Manager: Portage-3.0.20, Repoman-3.0.2
    Signed-off-by: Mart Raudsepp <leio@gentoo.org>

 media-gfx/shotwell/files/0.30.14-vala-0.52.8-compat.patch | 13 +++++++++++++
 media-gfx/shotwell/shotwell-0.30.14.ebuild                |  5 +++++
 2 files changed, 18 insertions(+)