Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 828511 - www-client/firefox +pgo but -lto does not build with PGO
Summary: www-client/firefox +pgo but -lto does not build with PGO
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-07 12:34 UTC by Sylvia
Modified: 2021-12-10 00:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log.gz,787.24 KB, application/gzip)
2021-12-07 12:35 UTC, Sylvia
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sylvia 2021-12-07 12:34:16 UTC
Building firefox (esr) with clang (13) and USE "pgo"
Xvfb is started as user portage.
But no -fprofile CFLAGS/CXXFLAGS are attempted to use and no profiling steps are taken, its just like normal build (without "pgo)



---------
www-client/firefox-91.4.0::gentoo was built with the following:
USE="clang dbus eme-free gmp-autoupdate hwaccel openh264 pgo pulseaudio system-harfbuzz system-jpeg -debug -geckodriver -hardened -jack -lto -screencast (-selinux) -sndio -system-av1 -system-icu -system-libevent -system-libvpx -system-webp -wayland -wifi" ABI_X86="(64)" L10N="ru -ach -af -an -ar -ast -az -be -bg -bn -br -bs -ca -ca-valencia -cak -cs -cy -da -de -dsb -el -en-CA -en-GB -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -ia -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mk -mr -ms -my -nb -ne -nl -nn -oc -pa -pl -pt-BR -pt-PT -rm -ro -sco -si -sk -sl -son -sq -sr -sv -szl -ta -te -th -tl -tr -trs -uk -ur -uz -vi -xh -zh-CN -zh-TW"
CFLAGS="-fomit-frame-pointer -march=znver1 -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -mmovbe -maes -msha -mpclmul -mpopcnt -mfma -mbmi -mbmi2 -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mrdrnd -mf16c -mfsgsbase -mrdseed -mprfchw -madx -mfxsr -mxsave -mxsaveopt -mclflushopt -mxsavec -mxsaves -mmwaitx -mclzero -mtune=znver1 -pipe"
CXXFLAGS="-fomit-frame-pointer -march=znver1 -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -mmovbe -maes -msha -mpclmul -mpopcnt -mfma -mbmi -mbmi2 -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mrdrnd -mf16c -mfsgsbase -mrdseed -mprfchw -madx -mfxsr -mxsave -mxsaveopt -mclflushopt -mxsavec -mxsaves -mmwaitx -mclzero -mtune=znver1 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg cgroup config-protect-if-modified distlocks ebuild-locks fakeroot fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news nodoc noinfo pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
LDFLAGS="-s -Wl,--compress-debug-sections=zlib -Wl,-rpath=/usr/lib64/firefox,--enable-new-dtags"



Reproducible: Always
Comment 1 Sylvia 2021-12-07 12:35:02 UTC
Created attachment 757618 [details]
build.log

build.log
Comment 2 Jonas Stein gentoo-dev 2021-12-07 23:01:18 UTC
please paste the emerge info as described on https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
Comment 3 Sylvia 2021-12-08 14:06:07 UTC
# emerge --info firefox
Portage 3.0.28 (python 3.9.9-final-0, default/linux/amd64/17.1, gcc-11.2.0, glibc-2.33-r7, 5.10.84-darkness x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.10.84-darkness-x86_64-AMD_Ryzen_5_3600_6-Core_Processor-with-glibc2.33
KiB Mem:    32873700 total,  31869180 free
KiB Swap:   12582900 total,  12582900 free
Timestamp of repository gentoo: Wed, 08 Dec 2021 12:00:01 +0000
Head commit of repository gentoo: f0d33bb17d62d2dfe59e5f280ef222f176b6328e
sh bash 5.1_p8
ld GNU ld (Gentoo 2.37_p1 p0) 2.37
ccache version 4.2.1 [disabled]
app-shells/bash:          5.1_p8::gentoo
dev-lang/perl:            5.34.0-r3::gentoo
dev-lang/python:          2.7.18_p13::gentoo, 3.8.12_p1::gentoo, 3.9.9::gentoo, 3.10.0_p1::gentoo
dev-lang/rust:            1.56.1::gentoo
dev-util/cmake:           3.22.1::gentoo
sys-apps/baselayout:      2.7-r3::gentoo
sys-apps/openrc:          0.44.9::gentoo
sys-apps/sandbox:         2.25::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:       1.16.4::gentoo
sys-devel/binutils:       2.37_p1::gentoo
sys-devel/gcc:            8.5.0-r1::gentoo, 9.4.0::gentoo, 10.3.1_p20211126::gentoo, 11.2.0::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.15-r1::gentoo (virtual/os-headers)
sys-libs/glibc:           2.33-r7::gentoo
Repositories:

gentoo
    location: /ext/portage/portage
    sync-type: rsync
    sync-uri: rsync://10.100.100.101/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: no
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -fomit-frame-pointer -g0 -mmmx -mfpmath=sse -msse3 -mssse3 -msse4 -msse4.2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /var/lib/i2pd/certificates"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -fomit-frame-pointer -g0 -mmmx -mfpmath=sse -msse3 -mssse3 -msse4 -msse4.2"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build=n --buildpkg-exclude "virtual/*" --keep-going=y --autounmask=n"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup config-protect-if-modified distlocks ebuild-locks fakeroot fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news nodoc noinfo pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2"
GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/ http://mirror.netcologne.de/gentoo/ http://mirror.leaseweb.com/gentoo/ http://mirrors.dotsrc.org/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,--as-needed -Wl,-O1 -Wl,-s -s -Wl,-fuse-ld=gold"
LINGUAS="en ru"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_BUNZIP2_COMMAND="lbunzip2 -v -n6"
PORTAGE_BZIP2_COMMAND="lbzip2 -9 -v -n6"
PORTAGE_COMPRESS="lzma"
PORTAGE_COMPRESS_FLAGS="-9e"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 amdgpu bluetooth bzip2 cairo cdda cddb cdparanoia cdr cleartype cli consolekit crypt cups curl dbus dri dri3 dvd dvdr elogind encode exif expat ffmpeg fontconfig ftp gdbm gif gles2 gmp gtk gzip hddtemp iconv idn ipv6 joystick jpeg kde lame lcms libglvnd libinput libtirpc lm-sensors lz4 lzma lzo mmap mmx mmxext mng mp3 mp4 mpeg mplayer mtp multilib musepack musicbrainz mysql ncurses nls nptl ogg openal opencore-amr opengl openmp opus orc pam pcre png policykit pulseaudio qt3support qt4 readline rss samba scanner sdl seccomp sndfile sox speex split-usr sql sqlite3 sse sse2 sse3 sse4 sse4_1 sse4_2 ssl ssse3 svg taglib tcpd theora threads truetype udev unicode usb v4l2 vaapi vorbis vulkan wavpack webp x264 xattr xv zlib" ABI_X86="64 32" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sha sse sse2 sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en ru" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python2_7 python3_7 python3_8 python3_9" QEMU_SOFTMMU_TARGETS="x86_64 i386 arm" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="nvidia nouveau amdgpu" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS

=================================================================
                        Package Settings
=================================================================

www-client/firefox-91.4.0::gentoo was built with the following:
USE="clang dbus eme-free gmp-autoupdate hwaccel openh264 pgo pulseaudio system-harfbuzz system-jpeg -debug -geckodriver -hardened -jack -lto -screencast (-selinux) -sndio -system-av1 -system-icu -system-libevent -system-libvpx -system-webp -wayland -wifi" ABI_X86="(64)" L10N="ru -ach -af -an -ar -ast -az -be -bg -bn -br -bs -ca -ca-valencia -cak -cs -cy -da -de -dsb -el -en-CA -en-GB -eo -es-AR -es-CL -es-ES -es-MX -et -eu -fa -ff -fi -fr -fy -ga -gd -gl -gn -gu -he -hi -hr -hsb -hu -hy -ia -id -is -it -ja -ka -kab -kk -km -kn -ko -lij -lt -lv -mk -mr -ms -my -nb -ne -nl -nn -oc -pa -pl -pt-BR -pt-PT -rm -ro -sco -si -sk -sl -son -sq -sr -sv -szl -ta -te -th -tl -tr -trs -uk -ur -uz -vi -xh -zh-CN -zh-TW"
CFLAGS="-fomit-frame-pointer -march=znver1 -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -mmovbe -maes -msha -mpclmul -mpopcnt -mfma -mbmi -mbmi2 -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mrdrnd -mf16c -mfsgsbase -mrdseed -mprfchw -madx -mfxsr -mxsave -mxsaveopt -mclflushopt -mxsavec -mxsaves -mmwaitx -mclzero -mtune=znver1 -pipe"
CXXFLAGS="-fomit-frame-pointer -march=znver1 -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -mmovbe -maes -msha -mpclmul -mpopcnt -mfma -mbmi -mbmi2 -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mrdrnd -mf16c -mfsgsbase -mrdseed -mprfchw -madx -mfxsr -mxsave -mxsaveopt -mclflushopt -mxsavec -mxsaves -mmwaitx -mclzero -mtune=znver1 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg cgroup config-protect-if-modified distlocks ebuild-locks fakeroot fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news nodoc noinfo pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
LDFLAGS="-s -Wl,--compress-debug-sections=zlib -Wl,-rpath=/usr/lib64/firefox,--enable-new-dtags"


-------

Additional settings are applied from packages.env:

# cat /etc/portage/env/plainld /etc/portage/env/znver1-clang 
LDFLAGS="-s"
CXXFLAGS="-O2 -fomit-frame-pointer -march=znver1 -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mcx16 -msahf -mmovbe -maes -msha -mpclmul -mpopcnt -mfma -mbmi -mbmi2 -mavx -mavx2 -msse4.2 -msse4.1 -mlzcnt -mrdrnd -mf16c -mfsgsbase -mrdseed -mprfchw -madx -mfxsr -mxsave -mxsaveopt -mclflushopt -mxsavec -mxsaves -mmwaitx -mclzero -mtune=znver1"
CFLAGS="${CXXFLAGS} -pipe"
export PATH=/usr/lib/llvm/13/bin:${PATH}
export CC=clang
export CXX=clang++
export CXXFLAGS=${CFLAGS}
export AR="llvm-ar"
export NM="llvm-nm"
export RANLIB="llvm-ranlib"
Comment 4 Thomas Deutschmann (RETIRED) gentoo-dev 2021-12-09 15:32:38 UTC
Nice catch. We only activate PGO when you also set USE=lto (https://gitweb.gentoo.org/repo/gentoo.git/tree/www-client/firefox/firefox-95.0.ebuild?id=9f7c4921012897868c8f254d9a042b51de43e120#n798). That's because USE=pgo is a waste of time when running on code which wasn't inlined.

We somehow lost

> REQUIRED_USE="pgo? ( lto )"

between 80.0.1-r1 and 81.0.
Comment 5 Sylvia 2021-12-09 17:02:18 UTC
+lto


that makes the trick!

Configure options

--enable-application=browser --host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu MOZILLA_OFFICIAL=1 --update-channel=esr MOZBUILD_STATE_PATH=/var/tmp/portage/www-client/firefox-91.4.0/work/firefox_build MOZ_PGO=1 --enable-optimize=-O2 --with-toolchain-prefix=x86_64-pc-linux-gnu- CC=clang LD=x86_64-pc-linux-gnu-ld CXX=clang++ HOST_CC=clang HOST_CXX=clang++ --disable-debug-symbols --enable-linker=lld AR=llvm-ar NM=llvm-nm PKG_CONFIG=x86_64-pc-linux-gnu-pkg-config LLVM_PROFDATA=llvm-profdata --enable-lto=cross --disable-cargo-incremental --with-libclang-path=/usr/lib/llvm/13/lib64 --enable-system-ffi --enable-rust-simd --with-system-graphite2 --with-system-harfbuzz --disable-eme --with-mozilla-api-keyfile=/var/tmp/portage/www-client/firefox-91.4.0/work/firefox-91.4.0/api-mozilla.key --with-google-location-service-api-keyfile=/var/tmp/portage/www-client/firefox-91.4.0/work/firefox-91.4.0/api-location.key --with-google-safebrowsing-api-keyfile=/var/tmp/portage/www-client/firefox-91.4.0/work/firefox-91.4.0/api-google.key --disable-geckodriver --with-unsigned-addon-scopes=app,system --with-system-jpeg --with-system-nss XARGS=/usr/bin/xargs --disable-install-strip --with-system-zlib --disable-sndio --disable-crashreporter --enable-dbus --disable-necko-wifi --enable-official-branding --enable-system-pixman --disable-updater --libdir=/usr/lib64 --prefix=/usr --without-system-libevent --with-system-png --x-includes=/usr/include --x-libraries=/usr/lib64


genlop -nt

     Tue Dec  7 15:22:09 2021 >>> www-client/firefox-91.4.0
       merge time: 20 minutes and 27 seconds.

     Thu Dec  9 19:53:58 2021 >>> www-client/firefox-91.4.0
       merge time: 51 minutes and 31 seconds.
Comment 6 Larry the Git Cow gentoo-dev 2021-12-10 00:18:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59fc86b7e57279170f6f4a79fe542ef120653587

commit 59fc86b7e57279170f6f4a79fe542ef120653587
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-12-10 00:07:03 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-12-10 00:18:46 +0000

    www-client/firefox: re-add REQUIRED_USE for USE=lto when USE=pgo
    
    Closes: https://bugs.gentoo.org/828511
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 www-client/firefox/firefox-91.4.0.ebuild | 1 +
 www-client/firefox/firefox-95.0.ebuild   | 1 +
 2 files changed, 2 insertions(+)