Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 828495 - app-misc/jdupes-1.20.2 dedupe support missing
Summary: app-misc/jdupes-1.20.2 dedupe support missing
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jakov Petrina
URL: https://github.com/jbruchon/jdupes
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-12-07 09:26 UTC by Andreas Thalhammer
Modified: 2021-12-08 11:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Thalhammer 2021-12-07 09:26:07 UTC
In the current ebuild for jdupes (app-misc/jdupes/jdupes-1.20.2.ebuild) the built version won't have support for deduplication.

The Makefile in the source lists it as ENABLE_DEDUPE=1, along with other options like LOW_MEMORY=1 and HARDEN=1 (build time options).

Reproducible: Always

Steps to Reproduce:
1. ACCEPT_KEYWORDS="~amd64" emerge -av app-misc/jdupes
2. jdupes -1 -B -C 4096 .
This program was built without dedupe support
Actual Results:  
jdupes currently lacks the --dedupe (or -B) option because ENABLE_DEDUPE=1 isn't used when building jdupes.

Expected Results:  
It would be expected for a deduplication program to actually support deduplication. At least it should be a default, preferably a useflag that should be enabled by default.

I've altered the existing ebuild app-misc/jdupes/jdupes-1.20.2.ebuild by adding IUSE and changing src_compile() as follows:

IUSE="+dedupe lowmem hardened"

src_compile() {
        tc-export CC
        local myconf=(
                $(usex dedupe 'ENABLE_DEDUPE=1' '')
                $(usex lowmem 'LOW_MEMORY=1' '')
                $(usex hardened 'HARDEN=1' '')
        )
        emake ${myconf[@]}
}

Now the -B (--dedupe) option is available. On my system hardened is enabled system-wide (USE=hardened), so it used HARDEN=1 as well. The program runs as expected.
Comment 1 Larry the Git Cow gentoo-dev 2021-12-08 11:26:22 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d8a8d9fe769fbf94f8fdf9bd2e1dcfaf5027c07

commit 4d8a8d9fe769fbf94f8fdf9bd2e1dcfaf5027c07
Author:     Jakov Petrina <jakov.petrina@sartura.hr>
AuthorDate: 2021-12-08 10:32:26 +0000
Commit:     Jakov Smolić <jsmolic@gentoo.org>
CommitDate: 2021-12-08 11:26:09 +0000

    app-misc/jdupes: add missing USE flags
    
    This change introduces several USE flags enabling support for deduplication
    (enabled by default), low memory scenario handling, and compile-time hardening.
    
    Closes: https://bugs.gentoo.org/828495
    Thanks-to: Andreas Thalhammer <andreas.thalhammer@linux.com>
    Signed-off-by: Jakov Petrina <jakov.petrina@sartura.hr>
    Closes: https://github.com/gentoo/gentoo/pull/23223
    Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>

 app-misc/jdupes/jdupes-1.20.2-r1.ebuild | 44 +++++++++++++++++++++++++++++++++
 app-misc/jdupes/jdupes-9999.ebuild      |  9 ++++++-
 app-misc/jdupes/metadata.xml            |  4 +++
 3 files changed, 56 insertions(+), 1 deletion(-)