Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 828485 - app-office/libreoffice Retire build-nocheck
Summary: app-office/libreoffice Retire build-nocheck
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Office Team
URL: https://github.com/LibreOffice/core/c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-07 01:16 UTC by jospezial
Modified: 2022-02-12 00:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jospezial 2021-12-07 01:16:20 UTC
https://github.com/LibreOffice/core/commit/243c05ac27e3ffd94343630e668a53cf3ad18744
"Retire build-nocheck

Build target was kept for backward compat in 'rework the default make
target', so lets retire it after 1.5 years.

Use 'make build' instead (which is since the default target anyway)."


libreoffice-9999.ebuild contains
local target
	use test && target="build" || target="build-nocheck"

	# this is not a proper make script
	make ${target} || die

Please remove "build-nocheck" and simplify or remove that lines if possible.
Comment 1 jospezial 2021-12-08 06:18:36 UTC
As you can see there, we can do the change on all libreoffice ebuilds in Gentoo:
https://github.com/LibreOffice/core/commit/a58e086ededb8442938e81f971dfae36ef7eb076
Comment 2 jospezial 2021-12-08 07:18:58 UTC
The lines can be exchanged with: default

src_compile() {
        # more and more LO stuff tries to use OpenGL, including tests during build
        # bug 501508, bug 540624, bug 545974 and probably more
        addpredict /dev/dri
        addpredict /dev/ati
        addpredict /dev/nvidiactl

        default
}

>>> Source configured.
>>> Compiling source in /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 ...
make -j2 
Automatic fetching of external tarballs is disabled.
mkdir -p /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/instdir
/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/solenv/bin/install-gdb-printers -a /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/instdir -c
make -j 2  -j2 -f /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/Makefile.gbuild build  
make[1]: warning: -j2 forced in submake: resetting jobserver mode.
make[1]: Entering directory '/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999'
mkdir -p /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/workdir/Headers/Library/
mkdir -p /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/workdir/LinkTarget/Library/
mkdir -p /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/workdir/CustomTarget/officecfg/
[CAT] officecfg_qa_allheaders.hxx
mv /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/workdir/CustomTarget/officecfg/registry/officecfg/officecfg_qa_allheaders.hxx.tmp /var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999/workdir/CustomTarget/officecfg/registry/officecfg/officecfg_qa_allheaders.hxx
[XSL] CustomTarget/officecfg/registry/officecfg/Inet.hxx
S=/var/tmp/portage/app-office/libreoffice-9999/work/libreoffice-9999 && I=$S/instdir && W=$S/workdir &&  mkdir -p $W/CustomTarget/officecfg/registry/officecfg/ && xsltproc --nonet  --stringparam ns1 Inet -o $W/CustomTarget/officecfg/registry/officecfg/Inet.hxx $S/officecfg/registry/cppheader.xsl $S/officecfg/registry/schema/org/openoffice/Inet.xcs
...
Comment 3 jospezial 2022-02-11 04:41:02 UTC
ping!
Comment 4 Larry the Git Cow gentoo-dev 2022-02-12 00:34:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=786426e9a5bf51c1664ae1367ad2a99c87c245ed

commit 786426e9a5bf51c1664ae1367ad2a99c87c245ed
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2022-02-12 00:33:50 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2022-02-12 00:33:50 +0000

    app-office/libreoffice: Fix build target
    
    Closes: https://bugs.gentoo.org/828485
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 app-office/libreoffice/libreoffice-7.3.0.3.ebuild  |  6 +-----
 app-office/libreoffice/libreoffice-7.3.9999.ebuild | 10 +++-------
 app-office/libreoffice/libreoffice-9999.ebuild     | 10 +++-------
 3 files changed, 7 insertions(+), 19 deletions(-)