Currently the requires.txt file contains mutagen, pycryptodomex, and websockets. We have mutagen as an optfeature, so I guess we should remove that from requires.txt websockets does appear to be optional in the code, so we should also remove that from requires.txt We provide pycryptodome instead of pycryptodomex, both are compatible with the project, so we should change that line to pycryptodome instead in requires.txt I ran into issues building firefox-95 today since it runs pip check which errors due to these inconsistencies. (locally I changed the installed requires.txt and installed the other python packages to stop breaking pip check) Reproducible: Always
Haven't tried it (build.log?), but if something like this can cause firefox to fail that seem like primarily a firefox issue, there could be many other packages that have incorrect requires and while it'd be nice to fix them it shouldn't cause firefox to fail. That aside, mutagen and websockets is more of an upstream issue which you should report there instead (they do mention they are supposed to be optional). I could sed s/domex/dome/ here though (wouldn't hurt to remove the others at same time until fixed upstream I guess). wrt websockets optfeature, it's intentionally left out because it's scarcely used by yt-dlp at the moment and felt it wasn't postinst elog noise (maybe I'll add an ebuild note as a reminder though).
At the end of the day, we probably shouldn't have portage installed packages causing pip check to complain. I'm not sure why Firefox requires pip check to return cleanly now, but it does. That could be patched, but I still feel like we shouldn't have portage installed python packages failing pip check, just feels wrong to me.
(In reply to Michael Cook from comment #2) > At the end of the day, we probably shouldn't have portage installed packages > causing pip check to complain. I'm not sure why Firefox requires pip check > to return cleanly now, but it does. That could be patched, but I still feel > like we shouldn't have portage installed python packages failing pip check, > just feels wrong to me. At least in the context where dependencies are actually missing, when upstream has incorrect ranges, or optional dependencies in there it's harmless and more something they should fix (and again, report there rather than here). Anyway, I'll still quickfix it on this side for now.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=75f046be742f40bb4425cfb20f7af06e0f8bbd73 commit 75f046be742f40bb4425cfb20f7af06e0f8bbd73 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2021-12-06 20:01:40 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2021-12-06 20:20:01 +0000 net-misc/yt-dlp: make pip check happier mutagen and websockets are optional, and we use pycryptodome rather than domex on Gentoo. Closes: https://bugs.gentoo.org/828466 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> .../yt-dlp/{yt-dlp-2021.12.1.ebuild => yt-dlp-2021.12.1-r1.ebuild} | 7 +++++++ 1 file changed, 7 insertions(+) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b285b063791d805301b0b811fa274a3b2a3fb0b commit 3b285b063791d805301b0b811fa274a3b2a3fb0b Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2021-12-06 20:03:35 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2021-12-06 20:20:02 +0000 net-misc/yt-dlp: stabilize 2021.12.1-r1 ALLARCHES One day earlier than planned but there is no known reason not to, saves backporting for bug #828466. Bug: https://bugs.gentoo.org/828466 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> net-misc/yt-dlp/yt-dlp-2021.12.1-r1.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
