Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 828098 - dev-vcs/git - Improve OpenRC script git-daemon
Summary: dev-vcs/git - Improve OpenRC script git-daemon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-03 18:15 UTC by Brian Evans (RETIRED)
Modified: 2021-12-06 09:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
git-daemon-r1.initd (git-daemon-r1.initd,385 bytes, text/plain)
2021-12-03 18:16 UTC, Brian Evans (RETIRED) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans (RETIRED) gentoo-dev 2021-12-03 18:15:46 UTC 
The attached script updates a couple things which effectively is the same as the current model however it follows the modular nature of the declarative syntax.

Split out the -b and -m start-stop-daemon options into command_background="yes"
Comment 1 Brian Evans (RETIRED) gentoo-dev 2021-12-03 18:16:31 UTC 
Created attachment 757342 [details]
git-daemon-r1.initd

Updated script

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 2 Larry the Git Cow gentoo-dev 2021-12-06 09:01:36 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f0c4602e9576233e24bc7da1eaca379421c6aee

commit 6f0c4602e9576233e24bc7da1eaca379421c6aee
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-12-06 08:55:08 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-12-06 09:01:17 +0000

    dev-vcs/git: Improve OpenRC script git-daemon
    
    Thanks-to: Brian Evans <grknight@gentoo.org>
    Closes: https://bugs.gentoo.org/828098
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 dev-vcs/git/files/git-daemon-r2.initd |  14 +
 dev-vcs/git/git-2.34.1-r1.ebuild      | 667 ++++++++++++++++++++++++++++++++++
 dev-vcs/git/git-9999-r1.ebuild        |   2 +-
 dev-vcs/git/git-9999-r2.ebuild        |   2 +-
 dev-vcs/git/git-9999-r3.ebuild        |   2 +-
 dev-vcs/git/git-9999.ebuild           |   2 +-
 6 files changed, 685 insertions(+), 4 deletions(-)
Comment 3 Joakim Tjernlund 2021-12-06 09:22:34 UTC 
Should pidfile still be /var/run/... and not just /run/...