Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 828094 - net-p2p/syncthing - Improve OpenRC scripts
Summary: net-p2p/syncthing - Improve OpenRC scripts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-03 17:15 UTC by Brian Evans (RETIRED)
Modified: 2021-12-09 12:03 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
syncthing.initd (syncthing.initd,1.14 KB, text/plain)
2021-12-03 17:15 UTC, Brian Evans (RETIRED)
Details
strelaysrv.initd (strelaysrv.initd,677 bytes, text/plain)
2021-12-03 17:16 UTC, Brian Evans (RETIRED)
Details
stdiscosrv.initd (stdiscosrv.initd,686 bytes, text/plain)
2021-12-03 17:16 UTC, Brian Evans (RETIRED)
Details
stdiscosrv.initd (stdiscosrv.initd,686 bytes, text/plain)
2021-12-03 17:18 UTC, Brian Evans (RETIRED)
Details
syncthing.initd (syncthing.initd,1.15 KB, text/plain)
2021-12-03 17:18 UTC, Brian Evans (RETIRED)
Details
strelaysrv.initd (strelaysrv.initd,685 bytes, text/plain)
2021-12-03 17:20 UTC, Brian Evans (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans (RETIRED) gentoo-dev 2021-12-03 17:15:01 UTC
The attached scripts updates a couple things which effectively is the same as the current model however it follows the modular nature of the declarative syntax.

Split up start_stop_daemon args where possible into predefined options like user=, directory=, output_log=, error_log=, and command_background
Comment 1 Brian Evans (RETIRED) gentoo-dev 2021-12-03 17:15:36 UTC
Created attachment 757331 [details]
syncthing.initd

Updated syncthing script

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 2 Brian Evans (RETIRED) gentoo-dev 2021-12-03 17:16:24 UTC
Created attachment 757332 [details]
strelaysrv.initd

Updated strelaysvc script

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 3 Brian Evans (RETIRED) gentoo-dev 2021-12-03 17:16:48 UTC
Created attachment 757333 [details]
stdiscosrv.initd

Updated stdiscosrv script

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 4 Brian Evans (RETIRED) gentoo-dev 2021-12-03 17:18:12 UTC
Created attachment 757334 [details]
stdiscosrv.initd

Updated stdiscosrv script

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 5 Brian Evans (RETIRED) gentoo-dev 2021-12-03 17:18:27 UTC
Created attachment 757335 [details]
syncthing.initd

Updated syncthing script

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 6 Brian Evans (RETIRED) gentoo-dev 2021-12-03 17:20:18 UTC
Created attachment 757336 [details]
strelaysrv.initd

Updated strelaysvc script

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-12-03 17:25:19 UTC
Another case where a git format-patch attachment would be easier ;)

(Just commit locally then git format-patch origin/master)
Comment 8 Marek Szuba archtester gentoo-dev 2021-12-06 15:47:23 UTC
Have you by any chance uploaded stdiscosrv.init for the second time instead of syncthing.initd, grknight?
Comment 9 Brian Evans (RETIRED) gentoo-dev 2021-12-06 15:51:33 UTC
(In reply to Marek Szuba from comment #8)
> Have you by any chance uploaded stdiscosrv.init for the second time instead
> of syncthing.initd, grknight?

Fixed the tagging. Comment 1 and Comment 2 had incorrect user= instead of command_user=.  Comment 4 was just a mistake
Comment 10 Larry the Git Cow gentoo-dev 2021-12-09 12:03:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=48af17ebb943d1f906ae9647bd9b943513734764

commit 48af17ebb943d1f906ae9647bd9b943513734764
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-12-09 11:14:29 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-12-09 12:03:17 +0000

    net-p2p/syncthing: add 1.18.5
    
    Includes improved OpenRC scripts as well as updated user/group
    configuration for st{disco,relay}srv.
    
    Closes: https://bugs.gentoo.org/828094
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 net-p2p/syncthing/Manifest                         |   1 +
 net-p2p/syncthing/files/stdiscosrv.initd-r1        |  27 +
 net-p2p/syncthing/files/strelaysrv.initd-r1        |  27 +
 .../files/syncthing-1.18.4-tool_users.patch        |  25 +
 net-p2p/syncthing/files/syncthing.initd-r1         |  32 +
 net-p2p/syncthing/syncthing-1.18.5.ebuild          | 883 +++++++++++++++++++++
 6 files changed, 995 insertions(+)