Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 828078 - net-misc/ntpsec - Improve OpenRC script for ntpd
Summary: net-misc/ntpsec - Improve OpenRC script for ntpd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-03 15:01 UTC by Brian Evans (RETIRED)
Modified: 2022-06-03 05:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ntpd.rc-r2 (ntpd.rc-r2,493 bytes, text/plain)
2021-12-03 15:02 UTC, Brian Evans (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Evans (RETIRED) gentoo-dev 2021-12-03 15:01:43 UTC
The attached script updates a couple things which effectively is the same as the current model however it follows the modular nature of the declarative syntax.

Removes the duplicating start_stop_daemon_args since --pidfile is automatic with pidfile=
Only have ntpd create the pidfile when forking via command_args_background
Add command_args_foreground for the option not to fork
Comment 1 Brian Evans (RETIRED) gentoo-dev 2021-12-03 15:02:08 UTC
Created attachment 757262 [details]
ntpd.rc-r2

Updated script for ntpd

Signed-off-by: Brian Evans <grknight@gentoo.org>
Comment 2 Larry the Git Cow gentoo-dev 2022-06-03 05:32:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=729d3c0a57feff2c9edb4e87136535c133877e4b

commit 729d3c0a57feff2c9edb4e87136535c133877e4b
Author:     Brian Evans <grknight@gentoo.org>
AuthorDate: 2022-06-03 05:20:50 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-06-03 05:29:32 +0000

    net-misc/ntpsec: Improve OpenRC script for ntpd
    
    The attached script updates a couple things which effectively is
    the same as the current model however it follows the modular nature of the
    declarative syntax.
    
    Changes:
    * Removes the duplicating start_stop_daemon_args since --pidfile is automatic
      with pidfile=
    * Only have ntpd create the pidfile when forking via command_args_background
    * Add command_args_foreground for the option not to fork
    
    Closes: https://bugs.gentoo.org/828078
    Signed-off-by: Brian Evans <grknight@gentoo.org>
    Signed-off-by: Sam James <sam@gentoo.org>

 net-misc/ntpsec/files/ntpd.rc-r3       |  23 +++++
 net-misc/ntpsec/ntpsec-1.2.1-r4.ebuild | 177 +++++++++++++++++++++++++++++++++
 2 files changed, 200 insertions(+)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-03 05:37:18 UTC
Thanks!