Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 827882 - dev-python/GitPython: dependency on dev-python/typing-extensions needs updating
Summary: dev-python/GitPython: dependency on dev-python/typing-extensions needs updating
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-30 08:57 UTC by Bob Dröge
Modified: 2021-11-30 10:01 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Dröge 2021-11-30 08:57:57 UTC
After installing dev-python/GitPython with a more recent Python (3.9), "pip check" shows that it's missing a dependency:

$ pip check
gitpython 3.1.24 requires typing-extensions, which is not installed.

The dependency on dev-python/typing-extensions only gets installed for Python 3.7:
https://github.com/gentoo/gentoo/blob/master/dev-python/GitPython/GitPython-3.1.24.ebuild#L31

Though that was correct for GitPython 3.1.18, see:
https://github.com/gitpython-developers/GitPython/blob/3.1.18/requirements.txt
It's no longer correct for newer versions of GitPython, as it also needs it for Python < 3.10 (I even suspect it just always needs this...):
https://github.com/gitpython-developers/GitPython/blob/3.1.24/requirements.txt

Could the ebuild file be updated?

Reproducible: Always

Steps to Reproduce:
1. emerge dev-python/GitPython
2. pip check
3.
Actual Results:  
gitpython 3.1.24 requires typing-extensions, which is not installed.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-11-30 09:17:21 UTC
Hmm, it seems that upstream actually reverted the use of py3.10 typing_extensions but didn't revert the requirement.
Comment 2 Larry the Git Cow gentoo-dev 2021-11-30 10:01:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4af18f3fc8c26ddeb34496710b890734796ecc6b

commit 4af18f3fc8c26ddeb34496710b890734796ecc6b
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-11-30 09:49:46 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-11-30 10:01:27 +0000

    dev-python/GitPython: Strip wrong typing-extensions requirement
    
    Closes: https://bugs.gentoo.org/827882
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 ...itPython-3.1.24.ebuild => GitPython-3.1.24-r1.ebuild} | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)