Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 827852 - autotools.eclass: update WANT_AUTOCONF=latest for sys-devel/autoconf-2.71
Summary: autotools.eclass: update WANT_AUTOCONF=latest for sys-devel/autoconf-2.71
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-11-29 16:22 UTC by Marek Szuba
Modified: 2023-12-27 20:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Szuba archtester gentoo-dev 2021-11-29 16:22:54 UTC
autoconf-2.71 has now got the same set of stable keywords as 2.69 yet for the time being WANT_AUTOCONF=latest still mentions the latter rather than the former.
Comment 1 Larry the Git Cow gentoo-dev 2022-01-22 22:22:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d2d4a44b2eb9a7a93a1b3d7b847674c75cdc0de

commit 6d2d4a44b2eb9a7a93a1b3d7b847674c75cdc0de
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-01-15 21:41:17 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-01-22 22:22:25 +0000

    autotools.eclass: update for autoconf 2.71
    
    Closes: https://bugs.gentoo.org/827852
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/autotools.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2023-12-27 20:57:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=00a85ac2928bf83ec841a08904b2e80008276ce2

commit 00a85ac2928bf83ec841a08904b2e80008276ce2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-12-27 19:12:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-12-27 20:57:06 +0000

    autotools.eclass: rework WANT_AUTOCONF handling
    
    For automake, we enumerate each of the automake slots in _WANT_AUTOMAKE and
    use this to handle setting WANT_AUTOMAKE accordingly if the ebuild (or user,
    I suppose) haven't set WANT_AUTOMAKE themselves. This means that we can easily
    rollover to the latest installed on a system (and we also pull it in via _WANT_AUTOMAKE
    which is used for dependencies) because WANT_AUTOMAKE is based on the slots in
    _WANT_AUTOMAKE intersected with whatever is installed on the system.
    
    For autoconf, we weren't doing any of that, and were just hardcoding whatever
    the latest slot is! That's error prone on bumps but it also wasn't really possible
    to get right as-is without marking a new slot stable because of the entanglement
    between the dependencies, WANT_AUTOCONF, and no intersection being done
    (WANT_AUTOCONF wasn't dynamic at all).
    
    We now implement a similar scheme for autoconf as we already had for automake. This
    fixes the case where WANT_AUTOCONF="latest" in an ebuild (the default), autoconf:2.71
    isn't installed, but autoconf:2.72 is.
    
    This sometimes worked before if the latest dep was slotted rather than unslotted
    like it is now (see below for why that's not easy to just fix) because the new slot
    would never get pulled in and hence the older slot which aligned with WANT_AUTOCONF's
    hardcoded value would be available.
    
    (I still think we should consider slotmoving older autoconfs but that's something
    to discuss and possibly do another time. See TODO.)
    
    Bug: https://bugs.gentoo.org/827852
    Bug: https://bugs.gentoo.org/893434
    Closes: https://bugs.gentoo.org/920822
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/autotools.eclass | 73 +++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 67 insertions(+), 6 deletions(-)