Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 823832 - dev-python/argh-0.26.2-r2 fails tests
Summary: dev-python/argh-0.26.2-r2 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on: 827860
Blocks: 796119
  Show dependency tree
 
Reported: 2021-11-15 16:51 UTC by Paolo Pedroni
Modified: 2021-12-13 18:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
argh-0.26.2-r2:20211115-164858.log.gz (argh-0.26.2-r2:20211115-164858.log.gz,5.59 KB, application/gzip)
2021-11-15 16:51 UTC, Paolo Pedroni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Pedroni 2021-11-15 16:51:19 UTC
Created attachment 751248 [details]
argh-0.26.2-r2:20211115-164858.log.gz

============================================================= FAILURES ==============================================================
________________________________________________________ test_invalid_choice ________________________________________________________

    def test_invalid_choice():
        def cmd(args):
            return 1
    
        # root level command
    
        p = DebugArghParser()
        p.add_commands([cmd])
    
>       assert run(p, 'bar', exit=True).startswith('invalid choice')
E       assert False
E        +  where False = <built-in method startswith of str object at 0x7f0b776305e0>('invalid choice')
E        +    where <built-in method startswith of str object at 0x7f0b776305e0> = "argument {cmd}: invalid choice: 'bar' (choose from 'cmd')".startswith
E        +      where "argument {cmd}: invalid choice: 'bar' (choose from 'cmd')" = run(DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True), 'bar', exit=True)

cmd        = <function test_invalid_choice.<locals>.cmd at 0x7f0b779fbf70>
p          = DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True)

test/test_integration.py:380: AssertionError
______________________________________________________ test_explicit_cmd_name _______________________________________________________

    def test_explicit_cmd_name():
    
        @argh.named('new-name')
        def orig_name():
            return 'ok'
    
        p = DebugArghParser()
        p.add_commands([orig_name])
>       assert run(p, 'orig-name', exit=True).startswith('invalid choice')
E       assert False
E        +  where False = <built-in method startswith of str object at 0x7f0b779f3cb0>('invalid choice')
E        +    where <built-in method startswith of str object at 0x7f0b779f3cb0> = "argument {new-name}: invalid choice: 'orig-name' (choose from 'new-name')".startswith
E        +      where "argument {new-name}: invalid choice: 'orig-name' (choose from 'new-name')" = run(DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True), 'orig-name', exit=True)

orig_name  = <function test_explicit_cmd_name.<locals>.orig_name at 0x7f0b77632700>
p          = DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True)

test/test_integration.py:514: AssertionError
====================================================== short test summary info ======================================================
SKIPPED [1] test/test_assembling.py:89: supported since Python 3.4
SKIPPED [1] test/test_assembling.py:106: supported since Python 3.4
XFAIL test/test_integration.py::test_guessing_integration
  TODO
XFAIL test/test_integration.py::test_simple_function_multiple
XFAIL test/test_integration.py::test_simple_function_nested
XFAIL test/test_integration.py::test_class_method_as_command
FAILED test/test_integration.py::test_invalid_choice - assert False
FAILED test/test_integration.py::test_explicit_cmd_name - assert False
======================================== 2 failed, 73 passed, 2 skipped, 4 xfailed in 0.73s =========================================
pytest-xprocess reminder::Be sure to terminate the started process by running 'pytest --xkill' if you have not explicitly done so in your fixture with 'xprocess.getinfo(<process_name>).terminate()'.
 * ERROR: dev-python/argh-0.26.2-r2::gentoo failed (test phase):
 *   pytest failed with python3.9

# emerge --info =dev-python/argh-0.26.2-r2
Portage 3.0.28 (python 3.9.7-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-11.2.0, glibc-2.33-r7, 5.10.76-gentoo-r1 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.10.76-gentoo-r1-x86_64-AMD_Phenom-tm-_II_X6_1100T_Processor-with-glibc2.33
KiB Mem:    16391528 total,   3190028 free
KiB Swap:   12550140 total,  12296932 free
Timestamp of repository gentoo: Mon, 15 Nov 2021 07:15:01 +0000
Head commit of repository gentoo: 7e3cafa190e0e2ddf5e34e8a140ea49bde932ebb
sh dash 0.5.11.3-r1
ld GNU gold (Gentoo 2.37_p1 p0 2.37) 1.16
distcc 3.4 x86_64-pc-linux-gnu [disabled]
ccache version 4.4.2 [disabled]
app-shells/bash:          5.1_p8::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.34.0-r3::gentoo
dev-lang/python:          2.7.18_p13::gentoo, 3.9.7_p1::gentoo
dev-lang/rust:            1.56.1::gentoo
dev-util/ccache:          4.4.2::gentoo
dev-util/cmake:           3.20.5::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/sandbox:         2.25::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.71-r1::gentoo
sys-devel/automake:       1.16.4::gentoo
sys-devel/binutils:       2.37_p1::gentoo
sys-devel/gcc:            11.2.0::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.33-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.europe.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

kde
    location: /var/lib/layman/kde
    sync-type: laymansync
    sync-uri: https://anongit.gentoo.org/git/proj/kde.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=6"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=6"
DISTDIR="/var/cache/distfiles"
EMERGE_DEFAULT_OPTS="--keep-going y --with-bdeps y"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=6"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup compress-build-logs config-protect-if-modified distlocks ebuild-locks ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-elog split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -frecord-gcc-switches -march=amdfam10 -flto=6"
GENTOO_MIRRORS="http://mirror.init7.net/gentoo/ http://mirror.leaseweb.com/gentoo/ https://mirror.init7.net/gentoo/ http://ftp.uni-hannover.de/gentoo/"
LANG="it_IT.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -Wl,--sort-common -flto=6"
LINGUAS="it it_IT"
MAKEOPTS="-j12 -l6"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac aalib acl acpi activities adns alsa amd64 ao audiofile bash-completion bluetooth branding brotli bzip2 cairo caps cdda cddb cdparanoia cdr cli crypt css cups curl dbus declarative dga djvu dri dts dvd dvdr emboss encode exif expat fbcon ffmpeg fftw flac fontconfig fortran ftp gd gdbm geoip gif gimp gmp gnutls gphoto2 gpm graphviz gtk gui guile handbook iconv icu idn ieee1394 imagemagick imlib introspection ipv6 java javascript jbig jemalloc jpeg jpeg2k kde kipi kwallet lame lcms libass libglvnd libnotify libsamplerate libtirpc lm-sensors lua lzma lzo mad magic mmap mng mp3 mp4 mpeg mplayer multilib musicbrainz ncurses nls nptl offensive ogg openal opengl openmp pam pango pch pcre pdf plasma png policykit postscript ppds pulseaudio qml qt5 rdesktop readline recode samba sctp sdl seccomp sndfile sockets speex spell split-usr sqlite sqlite3 ssl startup-notification svg symlink syslog systemd sysvipc taglib telemetry test theora threads tidy tiff truetype udev udisks unicode upower usb v4l vaapi vala vdpau verify-sig vim-syntax vnc vorbis wavpack wayland webp widgets win32codecs wmf wxwidgets x264 xattr xcb xine xinerama xml xpm xscreensaver xv xvid yahoo zip zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2019" ALSA_CARDS="hda-intel virmidi" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="3dnow 3dnowext mmx mmxext popcnt sse sse2 sse3 sse4a" CURL_SSL="gnutls" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="pc" INPUT_DEVICES="libinput" KERNEL="linux" L10N="it en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS

=================================================================
                        Package Settings
=================================================================

dev-python/argh-0.26.2-r2::gentoo was built with the following:
USE="test" ABI_X86="(64)" PYTHON_TARGETS="python3_9 (-pypy3) (-python3_10) -python3_8"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup compress-build-logs config-protect-if-modified distcc distlocks ebuild-locks ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms split-elog split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
Comment 1 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2021-11-30 08:49:02 UTC
Happens also on hppa
Comment 2 Rolf Eike Beer archtester 2021-12-01 17:01:02 UTC
I have 4 of them on sparc:

____________________________ test_add_subparsers_when_default_command_exists__supported _____________________________


    @pytest.mark.skipif(sys.version_info < (3,4), reason='supported since Python 3.4')
    def test_add_subparsers_when_default_command_exists__supported():
    
        def one(): return 1
        def two(): return 2
    
        p = argh.ArghParser()
        p.set_default_command(one)
        p.add_commands([two])
    
        ns_one = p.parse_args([])
        ns_two = p.parse_args(['two'])
    
        assert ns_one.get_function() == one
>       assert ns_two.get_function() == two
E       assert <function test_add_subparsers_when_default_command_exists__supported.<locals>.one at 0xf5c66cd0> == <function test_add_subparsers_when_default_command_exists__supported.<locals>.two at 0xf5c66d60>
E         +<function test_add_subparsers_when_default_command_exists__supported.<locals>.one at 0xf5c66cd0>
E         -<function test_add_subparsers_when_default_command_exists__supported.<locals>.two at 0xf5c66d60>

ns_one     = ArghNamespace(_functions_stack=[<function test_add_subparsers_when_default_command_exists__supported.<locals>.one at 0xf5c66cd0>])
ns_two     = ArghNamespace(_functions_stack=[<function test_add_subparsers_when_default_command_exists__supported.<locals>.two at 0xf5c66d60>, <function test_add_subparsers_when_default_command_exists__supported.<locals>.one at 0xf5c66cd0>])
one        = <function test_add_subparsers_when_default_command_exists__supported.<locals>.one at 0xf5c66cd0>
p          = ArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True)
two        = <function test_add_subparsers_when_default_command_exists__supported.<locals>.two at 0xf5c66d60>

test/test_assembling.py:136: AssertionError
_____________________________ test_set_default_command_when_subparsers_exist__supported _____________________________

____________________________ test_add_subparsers_when_default_command_exists__supported _____________________________

    @pytest.mark.skipif(sys.version_info < (3,4), reason='supported since Python 3.4')
    def test_set_default_command_when_subparsers_exist__supported():
        def one(): return 1
        def two(): return 2
    
        p = argh.ArghParser()
        p.add_commands([one])
        p.set_default_command(two)
    
        ns_two = p.parse_args([])
        ns_one = p.parse_args(['one'])
    
>       assert ns_one.get_function() == one
E       assert <function test_set_default_command_when_subparsers_exist__supported.<locals>.two at 0xf5ca8b68> == <function test_set_default_command_when_subparsers_exist__supported.<locals>.one at 0xf5ca8b20>
E         +<function test_set_default_command_when_subparsers_exist__supported.<locals>.two at 0xf5ca8b68>
E         -<function test_set_default_command_when_subparsers_exist__supported.<locals>.one at 0xf5ca8b20>

ns_one     = ArghNamespace(_functions_stack=[<function test_set_default_command_when_subparsers_exist__supported.<locals>.one at 0xf5ca8b20>, <function test_set_default_command_when_subparsers_exist__supported.<locals>.two at 0xf5ca8b68>])
ns_two     = ArghNamespace(_functions_stack=[<function test_set_default_command_when_subparsers_exist__supported.<locals>.two at 0xf5ca8b68>])
one        = <function test_set_default_command_when_subparsers_exist__supported.<locals>.one at 0xf5ca8b20>
p          = ArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True)
two        = <function test_set_default_command_when_subparsers_exist__supported.<locals>.two at 0xf5ca8b68>

test/test_assembling.py:151: AssertionError
________________________________________________ test_invalid_choice ________________________________________________

    def test_invalid_choice():
        def cmd(args):
            return 1
    
        # root level command
    
        p = DebugArghParser()
        p.add_commands([cmd])
    
>       assert run(p, 'bar', exit=True).startswith('invalid choice')
E       assert False
E        +  where False = <built-in method startswith of str object at 0xf5e72338>('invalid choice')
E        +    where <built-in method startswith of str object at 0xf5e72338> = "argument {cmd}: invalid choice: 'bar' (choose from 'cmd')".startswith
E        +      where "argument {cmd}: invalid choice: 'bar' (choose from 'cmd')" = run(DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True), 'bar', exit=True)

cmd        = <function test_invalid_choice.<locals>.cmd at 0xf5c8d220>
p          = DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True)

test/test_integration.py:380: AssertionError
______________________________________________ test_explicit_cmd_name _______________________________________________

    def test_explicit_cmd_name():
    
        @argh.named('new-name')
        def orig_name():
            return 'ok'
    
        p = DebugArghParser()
        p.add_commands([orig_name])
>       assert run(p, 'orig-name', exit=True).startswith('invalid choice')
E       assert False
E        +  where False = <built-in method startswith of str object at 0xf5cad910>('invalid choice')
E        +    where <built-in method startswith of str object at 0xf5cad910> = "argument {new-name}: invalid choice: 'orig-name' (choose from 'new-name')".startswith
E        +      where "argument {new-name}: invalid choice: 'orig-name' (choose from 'new-name')" = run(DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True), 'orig-name', exit=True)

orig_name  = <function test_explicit_cmd_name.<locals>.orig_name at 0xf5ca8da8>
p          = DebugArghParser(prog='__main__.py', usage=None, description=None, formatter_class=<class 'argh.constants.CustomFormatter'>, conflict_handler='error', add_help=True)
Comment 3 Rolf Eike Beer archtester 2021-12-01 17:01:42 UTC
No, on the other machine: I have seen it on _hppa_, not sparc.
Comment 4 Larry the Git Cow gentoo-dev 2021-12-01 17:47:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f194f12a2e30aad7da347848f7b0187e188f983

commit 6f194f12a2e30aad7da347848f7b0187e188f983
Author:     Arthur Zamarin <arthurzam@gentoo.org>
AuthorDate: 2021-12-01 17:44:23 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2021-12-01 17:47:04 +0000

    dev-python/argh: partial tests fix
    
    Fix two of 4 tests failures. Other two happen only on python-3.9.8
    and not any later version, so will auto fix itself with time. See
    bug for more info.
    
    Bug: https://bugs.gentoo.org/823832
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 dev-python/argh/argh-0.26.2-r2.ebuild              |  6 ++++-
 .../argh/files/argh-0.26.2-fix-py3.9-msgs.patch    | 31 ++++++++++++++++++++++
 2 files changed, 36 insertions(+), 1 deletion(-)
Comment 5 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2021-12-01 17:47:53 UTC
OK, found the issue upstream (see [0], especially last two comments).
We have here two classes of errors:

1. the two reported by Paolo: wrote a patch and will fix it now.
2. the extra two found by Rolf [1] happens only on python3.9 (not on 3.8 or 3.10) and only for 3.9.8 from this change [2] which was reverted [3] for python-3.9.9.

I prefer to wait for stabilization of 3.9.9 and removal of 3.9.8 to fix this issue second group. Meanwhile, you can skip those two failures 


[0] https://github.com/neithere/argh/issues/148
[1] test_set_default_command_when_subparsers_exist__supported ,test_add_subparsers_when_default_command_exists__supported
[2] https://github.com/python/cpython/commit/a18d52269ab6071a605d6c72f6af585a4c533ca4
[3] https://github.com/python/cpython/commit/587ff7f50bcbfd8346c6d5db459a1628a350c04d
Comment 6 Arthur Zamarin archtester Gentoo Infrastructure gentoo-dev Security 2021-12-13 18:58:01 UTC
Closing as python-3.9.9 is stabilized and 3.9.8 was cleaned.
Thank you all for the help and investigation.