Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 823047 - www-client/netsurf: netsurf.desktop: Add the ability to open URL
Summary: www-client/netsurf: netsurf.desktop: Add the ability to open URL
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Philipp Ammann
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-11-11 10:09 UTC by Andrey Volkov
Modified: 2022-03-16 01:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Volkov 2021-11-11 10:09:29 UTC
Currently .desktop files of www-client/netsurf are generated via make_desktop_entry() with Exec=/usr/bin/netsurf-gtk3

To open the URL, it is possible to use the %u argument, just like it is in firefox.desktop.

Reproducible: Always




--- a/www-client/netsurf/netsurf-3.10-r4.ebuild
+++ b/www-client/netsurf/netsurf-3.10-r4.ebuild
@@ -123,7 +123,7 @@ src_install() {
                # See earlier comments about rsvg.h.
                _emake NETSURF_USE_RSVG=NO TARGET=framebuffer DESTDIR="${D}" install
                elog "framebuffer binary has been installed as netsurf-fb"
-               make_desktop_entry "${EPREFIX}"/usr/bin/netsurf-fb \
+               make_desktop_entry "${EPREFIX}/usr/bin/netsurf-fb %u" \
                                                   NetSurf-framebuffer \
                                                   netsurf \
                                                   "Network;WebBrowser"
@@ -131,7 +131,7 @@ src_install() {
        if use gtk2 ; then
                _emake TARGET=gtk2 DESTDIR="${D}" install
                elog "netsurf gtk2 version has been installed as netsurf-gtk2"
-               make_desktop_entry "${EPREFIX}"/usr/bin/netsurf-gtk2 \
+               make_desktop_entry "${EPREFIX}/usr/bin/netsurf-gtk2 %u" \
                                                   NetSurf-gtk2 \
                                                   netsurf \
                                                   "Network;WebBrowser"
@@ -139,7 +139,7 @@ src_install() {
        if use gtk ; then
                _emake TARGET=gtk3 DESTDIR="${D}" install
                elog "netsurf gtk3 version has been installed as netsurf-gtk3"
-               make_desktop_entry "${EPREFIX}"/usr/bin/netsurf-gtk3 \
+               make_desktop_entry "${EPREFIX}/usr/bin/netsurf-gtk3 %u" \
                                                   NetSurf-gtk3 \
                                                   netsurf \
                                                   "Network;WebBrowser"
Comment 1 Larry the Git Cow gentoo-dev 2022-03-16 01:01:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33a835fe4c5824b7d30e825ae445ea59abf79552

commit 33a835fe4c5824b7d30e825ae445ea59abf79552
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-03-16 00:13:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-03-16 01:01:14 +0000

    www-client/netsurf: enhance desktop files
    
    Closes: https://bugs.gentoo.org/823047
    Thanks-to: Andrey Volkov <volkov@ekb-info.ru>
    Signed-off-by: Sam James <sam@gentoo.org>

 www-client/netsurf/netsurf-3.10-r5.ebuild | 154 ++++++++++++++++++++++++++++++
 1 file changed, 154 insertions(+)