https://github.com/u-235/kchmviewer/releases/tag/v8.1-rc It's technically a fork, so I don't know why they didn't rename it, but the build system is slightly less messy and upstream is slightly less dead and it doesn't require 3 patches simply to build right on arrival. Reproducible: Always
Created attachment 750252 [details] ebuild ported to cmake
Not going to happen. For something that got a new release only last May you'll have to come up with more convincing arguments to switch to a fork, especially when that bring with it bundling of dev-libs/chmlib which we do not appreciate at all.
youtube-dl had a release only last June and it's considered stagnated and people switched to a fork. Anyway. I wasn't trying to sell you the fork or turn this report into a full changelog for the new version. The changes can be seen here: https://github.com/u-235/kchmviewer/commits/master
More to the point. Does it really come with a bundled chmlib? I didn't notice: equery f kchmviewer * Searching for kchmviewer ... * Contents of app-text/kchmviewer-8.1: /usr /usr/bin /usr/bin/kchmviewer /usr/share /usr/share/applications /usr/share/applications/kchmviewer.desktop /usr/share/doc /usr/share/doc/kchmviewer-8.1 /usr/share/doc/kchmviewer-8.1/ChangeLog.bz2 /usr/share/doc/kchmviewer-8.1/README.md.bz2 /usr/share/icons /usr/share/icons/hicolor /usr/share/icons/hicolor/128x128 /usr/share/icons/hicolor/128x128/apps /usr/share/icons/hicolor/128x128/apps/kchmviewer.png /usr/share/locale /usr/share/locale/cs /usr/share/locale/cs/LC_MESSAGES /usr/share/locale/cs/LC_MESSAGES/kchmviewer.mo /usr/share/locale/de /usr/share/locale/de/LC_MESSAGES /usr/share/locale/de/LC_MESSAGES/kchmviewer.mo /usr/share/locale/fr /usr/share/locale/fr/LC_MESSAGES /usr/share/locale/fr/LC_MESSAGES/kchmviewer.mo /usr/share/locale/hu /usr/share/locale/hu/LC_MESSAGES /usr/share/locale/hu/LC_MESSAGES/kchmviewer.mo /usr/share/locale/it /usr/share/locale/it/LC_MESSAGES /usr/share/locale/it/LC_MESSAGES/kchmviewer.mo /usr/share/locale/nl /usr/share/locale/nl/LC_MESSAGES /usr/share/locale/nl/LC_MESSAGES/kchmviewer.mo /usr/share/locale/pt_BR /usr/share/locale/pt_BR/LC_MESSAGES /usr/share/locale/pt_BR/LC_MESSAGES/kchmviewer.mo /usr/share/locale/ru /usr/share/locale/ru/LC_MESSAGES /usr/share/locale/ru/LC_MESSAGES/kchmviewer.mo /usr/share/locale/sv /usr/share/locale/sv/LC_MESSAGES /usr/share/locale/sv/LC_MESSAGES/kchmviewer.mo /usr/share/locale/tr /usr/share/locale/tr/LC_MESSAGES /usr/share/locale/tr/LC_MESSAGES/kchmviewer.mo /usr/share/locale/uk /usr/share/locale/uk/LC_MESSAGES /usr/share/locale/uk/LC_MESSAGES/kchmviewer.mo /usr/share/locale/zh_CN /usr/share/locale/zh_CN/LC_MESSAGES /usr/share/locale/zh_CN/LC_MESSAGES/kchmviewer.mo /usr/share/locale/zh_TW /usr/share/locale/zh_TW/LC_MESSAGES /usr/share/locale/zh_TW/LC_MESSAGES/kchmviewer.mo
(In reply to Michael from comment #3) > youtube-dl had a release only last June and it's considered stagnated and > people switched to a fork. That's irrelevant here. kchmviewer has a long history and the forking dev should be encouraged to re-open their PRs instead of perpetuating fork-it-on-github mentality. Upstream was still merging PRs after u-235 had closed theirs.
https://github.com/gyunaev/kchmviewer/pull/6 As far as I'm concerned, this is the fork of a person that was not able to follow-up to substantial review comments and change requests by the upstream dev.
(In reply to Andreas Sturmlechner from comment #6) > https://github.com/gyunaev/kchmviewer/pull/6 > > As far as I'm concerned, this is the fork of a person that was not able to > follow-up to substantial review comments and change requests by the upstream > dev. That might or might not be true, to me it seems more like upstream is dragging their feet accepting trivial changes that fix compilation: https://bugs.gentoo.org/806316 Could you address that thing about bundled chmlib? I don't see it installed. It is in their git repo, linked, but other than that... where is it?
(In reply to Michael from comment #7) > That might or might not be true, to me it seems more like upstream is > dragging their feet accepting trivial changes that fix compilation: > https://bugs.gentoo.org/806316 That fix is directly taken from upstream git master.
As are both other patches we apply to 8.0.
If you are interested in having some of the fixes of the fork, you may try and point at the specific commits of those fixes so me or someone else could look at backporting them to our package or even forward them in a sanitised way to the real upstream.
(In reply to Andreas Sturmlechner from comment #10) > If you are interested in having some of the fixes of the fork, you may try > and point at the specific commits of those fixes so me or someone else could > look at backporting them to our package or even forward them in a sanitised > way to the real upstream. Easier said than done, unfortunately. I looked into commit history and couldn't easily find where they fixed the translations of even building with cmake. Not saying it's impossible, it's just not easy, due to the way they commit. It's a bit messy, which you rightfully pointed out to me on IRC.
(In reply to Michael from comment #11) > or even building with cmake. That's not our priority as long as upstream's qmake works. If the fork's fix for translations really requires porting to cmake first though, tough luck.
I pondered generating and installing .mo files from the ebuild, but no, translations without KLocale from kdelibs4support also require code changes, much of which in the fork I consider useless because it still cares about Qt4 support and even goes back on minimum Qt5 requirements. Additionally from release notes: "However, the translation files are outdated and only Russian translation is up to date." I wouldn't spend more time on that right now. The fork now at least did the decent thing of renaming their project into "uchmviewer", with that I consider it a separate (new) package request.
For completeness, made somewhat of a ping at upstream kchmviewer: https://github.com/gyunaev/kchmviewer/issues/20
8.2 is released https://github.com/u-235/uchmviewer/releases/tag/v8.2-rc
