Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 822969 - games-util/lutris-0.5.9.1: doesn't work when x11-libs/gdk-pixbuf is built without jpeg
Summary: games-util/lutris-0.5.9.1: doesn't work when x11-libs/gdk-pixbuf is built wit...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Andrew Ammerlaan
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-11-10 18:45 UTC by WGH
Modified: 2022-04-12 09:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description WGH 2021-11-10 18:45:28 UTC
games-util/lutris-0.5.9.1 doesn't work at all, as unhandled exception breaks everything, and no games are shown in the list.

The error that gets printed to the console:

2021-10-22 03:57:22,238: Unable to load icon from image bg2
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/lutris/gui/lutriswindow.py", line 455, in update_store
    self.game_store.add_game(game)
  File "/usr/lib/python3/dist-packages/lutris/gui/views/store.py", line 158, in add_game
    game.get_pixbuf(),
  File "/usr/lib/python3/dist-packages/lutris/gui/views/store_item.py", line 108, in get_pixbuf
    return get_pixbuf_for_game(
  File "/usr/lib/python3/dist-packages/lutris/gui/widgets/utils.py", line 128, in get_pixbuf_for_game
    return get_pixbuf(image_abspath, size, fallback=get_default_icon(size), is_installed=is_installed)
  File "/usr/lib/python3/dist-packages/lutris/gui/widgets/utils.py", line 59, in get_pixbuf
    pixbuf = pixbuf.scale_simple(width, height, GdkPixbuf.InterpType.NEAREST)
AttributeError: 'NoneType' object has no attribute 'scale_simple'

The earlier games-util/lutris-0.5.8.4 kinda works, but renders uninitialized memory noise instead of game icons.

The fix is to rebuild x11-libs/gdk-pixbuf with jpeg USE flag. I think lutris should depend on it.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2022-03-30 11:51:30 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5bdc866c6fd38850f8feb9561054e523b607dd6f

commit 5bdc866c6fd38850f8feb9561054e523b607dd6f
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-03-30 10:18:23 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-03-30 11:50:53 +0000

    games-util/lutris: add 0.5.10_beta2
    
    Bug: https://github.com/lutris/lutris/issues/4175
    Bug: https://bugs.gentoo.org/835897
    Bug: https://bugs.gentoo.org/822969
    Bug: https://bugs.gentoo.org/836332
    Bug: https://bugs.gentoo.org/820860
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/24815
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 games-util/lutris/Manifest                         |  1 +
 .../lutris-0.5.10_beta2-fix-install-requires.patch | 13 ++++
 .../lutris-0.5.10_beta2-fix-launching-steam.patch  | 22 ++++++
 games-util/lutris/lutris-0.5.10_beta2.ebuild       | 88 ++++++++++++++++++++++
 4 files changed, 124 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2022-04-12 09:08:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b6a34b0e5a405e241df5af0aec3f90c3c81d8d5

commit 0b6a34b0e5a405e241df5af0aec3f90c3c81d8d5
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2022-04-12 08:55:00 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2022-04-12 09:08:33 +0000

    games-util/lutris: drop 0.5.9.1-r1, 0.5.10_beta2-r1
    
    Closes: https://bugs.gentoo.org/835897
    Closes: https://bugs.gentoo.org/822969
    Closes: https://bugs.gentoo.org/820860
    Closes: https://bugs.gentoo.org/706432
    Closes: https://bugs.gentoo.org/837863
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 games-util/lutris/Manifest                         |  2 -
 .../lutris-0.5.10_beta2-fix-install-requires.patch | 13 ----
 .../lutris-0.5.10_beta2-fix-launching-steam.patch  | 22 ------
 games-util/lutris/lutris-0.5.10_beta2-r1.ebuild    | 86 ----------------------
 games-util/lutris/lutris-0.5.9.1-r1.ebuild         | 83 ---------------------
 5 files changed, 206 deletions(-)