Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 822732 - app-arch/pixz lacks a man page, though the source git provides one
Summary: app-arch/pixz lacks a man page, though the source git provides one
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-11-09 21:40 UTC by korte
Modified: 2022-10-20 04:03 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
modified ebuild with additional line for the man page (pixz-1.0.7-r1.ebuild,1.16 KB, text/plain)
2022-02-02 15:20 UTC, korte
Details

Note You need to log in before you can comment on or make changes to this bug.
Description korte 2021-11-09 21:40:30 UTC
I emerged pixz and didn't get a man page. The project has a man page at https://github.com/vasi/pixz/blob/master/src/pixz.1.asciidoc

app-text/asciidoc-9.0.5-r1::gentoo was installed.

If I got the discussion in #gentoo right, the live version has a man page and there could be a dependency problem.

Reproducible: Always
Comment 1 genBTC 2021-11-09 23:03:28 UTC
I looked into this for a while and the situation is very strange.
My final determination was this:

an additional dependency (app-text/asciidoc) is required just to generate a manpage, but one is provided pre-generated (named pixz.1) and is just not being installed.

there's a substantial amount of the author's conditional logic in the package related to this "man handling" as is, but the end result is that all lines for manpages in the Makefile scripts get auto-commented out. 

This applies to pixz-1.0.7.ebuild:
My simplest solution: 
in the .ebuild src_configure() section right before ending "econf" command:
add:

export man_MANS=pixz.1


This will cause the make install script to install this pre-generated "pixz.1" manpage file.
(this variable came from the authors own automake "src/Makefile.am")

The 9999 version from git does not have this problem, and this only applies to 1.0.7 release.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-09 23:14:17 UTC
(CCing gyakovlev as he's interested in pixz iirc?)
Comment 3 korte 2022-02-02 15:19:16 UTC
(In reply to genBTC from comment #1)
> This applies to pixz-1.0.7.ebuild:
> My simplest solution: 
> in the .ebuild src_configure() section right before ending "econf" command:
> add:
> 
> export man_MANS=pixz.1
> 

Works for me:

git diff pixz-1.0.7.ebuild pixz-1.0.7-r1.ebuild |cat
diff --git a/pixz-1.0.7.ebuild b/pixz-1.0.7-r1.ebuild
index cb614f5..f96c204 100644
--- a/pixz-1.0.7.ebuild
+++ b/pixz-1.0.7-r1.ebuild
@@ -43,6 +43,7 @@ src_configure() {
       	# Workaround silly logic that breaks cross-compiles.
       	# https://github.com/vasi/pixz/issues/67
       	export ac_cv_file_src_pixz_1=$([[ -f src/pixz.1 ]] && echo yes || echo no)
+       export man_MANS=pixz.1
       	econf
 }
Comment 4 korte 2022-02-02 15:20:26 UTC
Created attachment 764229 [details]
modified ebuild with additional line for the man page
Comment 5 Larry the Git Cow gentoo-dev 2022-10-17 23:41:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1cc9cb4c6e2e6eacefeb33da4cb3eff53973cfbd

commit 1cc9cb4c6e2e6eacefeb33da4cb3eff53973cfbd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-17 23:38:25 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-17 23:39:36 +0000

    app-arch/pixz: install man page
    
    Closes: https://bugs.gentoo.org/822732
    Signed-off-by: Sam James <sam@gentoo.org>

 .../pixz/{pixz-1.0.7.ebuild => pixz-1.0.7-r1.ebuild}    | 15 ++++++++++-----
 app-arch/pixz/pixz-9999.ebuild                          | 17 +++++++++++------
 2 files changed, 21 insertions(+), 11 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77f6e35a94d7f1ba07ff3759d4fdcc37d83650e3

commit 77f6e35a94d7f1ba07ff3759d4fdcc37d83650e3
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-17 23:40:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-17 23:40:00 +0000

    app-arch/pixz: drop obsolete man page workaround in 9999
    
    Bug: https://bugs.gentoo.org/822732
    Signed-off-by: Sam James <sam@gentoo.org>

 app-arch/pixz/pixz-9999.ebuild | 9 ---------
 1 file changed, 9 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2022-10-20 04:03:55 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8c0612f34306ce87915986def93614aae5802870

commit 8c0612f34306ce87915986def93614aae5802870
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-10-20 04:02:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-10-20 04:03:30 +0000

    app-arch/pixz: partially restore man page workaround for 9999
    
    Bug: https://github.com/vasi/pixz/issues/94
    Bug: https://bugs.gentoo.org/822732
    Signed-off-by: Sam James <sam@gentoo.org>

 app-arch/pixz/pixz-1.0.7-r1.ebuild | 3 ++-
 app-arch/pixz/pixz-9999.ebuild     | 7 +++++++
 2 files changed, 9 insertions(+), 1 deletion(-)