/bin/sh ./libtool --tag=CC --mode=link clang -m32 -Wall -march=native -O3 -falign-functions=32 -pipe -fno-lto -fdata-sections -ffunction-sections -fno-builtin-calloc -fno-builtin-malloc -fno-builtin-realloc `expr src/sandbox : .*_static >/dev/null && echo -all-static` -Wl,-O1 -Wl,--as-needed -fno-lto -Wl,--as-needed -Wl,--gc-sections -Wl,--no-undefined -o src/sandbox src/sandbox-environ.o src/sandbox-namespaces.o src/sandbox-options.o src/sandbox-sandbox.o libsbutil/libsbutil.la -ldl /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:724:2: error: expected expression char *args = flatten_args(argv); ^ /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:725:63: error: use of undeclared identifier 'args'; did you mean 'argv'? sb_eqawarn("Unable to trace static ELF: %s: %s\n", filename, args); ^~~~ argv /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:705:55: note: 'argv' declared here bool trace_possible(const char *filename, char *const argv[], const void *data) ^ /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:726:7: error: use of undeclared identifier 'args'; did you mean 'argv'? free(args); ^~~~ argv
PF16W6Y2 ~ # emerge --info Portage 3.0.28 (python 3.9.7-final-0, default/linux/amd64/17.1/desktop/gnome/systemd, gcc-11.2.0, glibc-2.33-r7, 5.15.0-gentoo x86_64) ================================================================= System uname: Linux-5.15.0-gentoo-x86_64-Intel-R-_Core-TM-_i7-8850H_CPU_@_2.60GHz-with-glibc2.33 KiB Mem: 32564828 total, 1095236 free KiB Swap: 33554428 total, 21153276 free Timestamp of repository gentoo: Wed, 03 Nov 2021 07:52:07 +0000 Head commit of repository gentoo: f42b5ec958ca12dc5fd7f1fd117c78884d811c7a Head commit of repository audio-overlay: 67c8fbcd0681d09261860c2f1bac1e9cb8fab08e Head commit of repository lto-overlay: dde13f77f390545d64b1a64430f23b4bf10b65eb Head commit of repository mv: f889c332974e8a5a9705104d710ff10d7bf0bb6f sh bash 5.1_p8 ld GNU ld (Gentoo 2.36.1 p4) 2.36.1 ccache version 4.4.2 [disabled] app-shells/bash: 5.1_p8::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.34.0-r5::gentoo dev-lang/python: 2.7.18_p13::gentoo, 3.8.12_p1::gentoo, 3.9.7_p1::gentoo, 3.10.0_p1::gentoo dev-lang/rust: 1.56.1::gentoo dev-util/ccache: 4.4.2::gentoo dev-util/cmake: 3.21.4::gentoo sys-apps/baselayout: 2.8::gentoo sys-apps/sandbox: 2.28::gentoo sys-devel/autoconf: 2.13-r1::gentoo, 2.71-r1::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.36.1-r2::gentoo, 2.37_p1::gentoo sys-devel/gcc: 8.4.0-r2::gentoo, 10.3.0-r2::gentoo, 11.2.0::gentoo sys-devel/gcc-config: 2.4::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.15::gentoo (virtual/os-headers) sys-libs/glibc: 2.33-r7::gentoo Repositories: gentoo location: /usr/portage sync-type: git sync-uri: git://github.com/gentoo-mirror/gentoo.git priority: -1000 audio-overlay location: /var/lib/layman/audio-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/audio-overlay.git masters: gentoo priority: 50 calculate location: /var/lib/layman/calculate masters: gentoo priority: 50 dlang location: /var/lib/layman/dlang masters: gentoo priority: 50 gentoo-zh location: /var/lib/layman/gentoo-zh masters: gentoo priority: 50 go-overlay location: /var/lib/layman/go-overlay masters: gentoo priority: 50 lto-overlay location: /var/lib/layman/lto-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/lto-overlay.git masters: gentoo mv priority: 50 mv location: /var/lib/layman/mv sync-type: git sync-uri: https://github.com/gentoo-mirror/mv.git masters: gentoo priority: 50 steam-overlay location: /var/lib/layman/steam-overlay masters: gentoo priority: 50 tlp location: /var/lib/layman/tlp masters: gentoo priority: 50 rugubara location: /var/lib/layman/rugubara masters: gentoo priority: 100 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA Vivaldi" CBUILD="x86_64-pc-linux-gnu" CC="clang" CFLAGS="-march=native -O3 -fno-semantic-interposition -fgraphite-identity -floop-nest-optimize -flto=12 -fuse-linker-plugin -falign-functions=32 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXX="clang++" CXXFLAGS="-march=native -O3 -fno-semantic-interposition -fgraphite-identity -floop-nest-optimize -flto=12 -fuse-linker-plugin -falign-functions=32 -pipe" DISTDIR="/usr/portage/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-march=native -O3 -fno-semantic-interposition -fgraphite-identity -floop-nest-optimize -flto=12 -fuse-linker-plugin -falign-functions=32 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-march=native -O3 -fno-semantic-interposition -fgraphite-identity -floop-nest-optimize -flto=12 -fuse-linker-plugin -falign-functions=32 -pipe" GENTOO_MIRRORS="http://gentoo.bloodhost.ru/ rsync://gentoo.bloodhost.ru/gentoo-distfiles http://ftp.ntua.gr/pub/linux/gentoo/" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j6" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 aac acl acpi aio alsa amd64 ap bash-completion bluetooth branding bzip2 cacert cairo caps cdda cdr cgroup-hybrid chromecast clang cli client colord crypt cups dbus djvu dri dri3 dts dvd dvdr eds egl emboss encode evo exif fat ffmpeg fftw flac fortran gdbm gif gimp gles2 gnome gnome-keyring gnome-online-accounts gpm graphite gstreamer gtk gtk3 gui heif iconv icu introspection io-uring ipv6 jack jpeg jpeg2k lcms libglvnd libnotify libsecret libtirpc libzfs lm_sensors lto lv2 mad mng mp3 mp4 mpeg multilib native-headset nautilus ncat ncurses networkmanager nfs nls nptl ntfs nvenc nvme ogg opencl opengl openmp opus p2p pam pango pcre pdf png policykit ppds pulseaudio qt5 raw readline sdl sdl2 seccomp smp sna sound spell spice split-usr ssl startup-notification svg synaptics sysprof systemd thunderbolt tiff tracker truetype udev udisks uefi unicode upower usb usbredir user-session vaapi vala vdpau virgl vlc vorbis vulkan wayland webdav wireguard wxwidgets x264 x265 xattr xcb xml xv xvid zeroconf zfs zlib" ABI_X86="64" ADA_TARGET="gnat_2019" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput wacom" KERNEL="linux" L10N="en ru" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_8 python3_9" RUBY_TARGETS="ruby26 ruby27 ruby27 ruby30" USERLAND="GNU" VIDEO_CARDS="intel i965 iris nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
Created attachment 748209 [details] build log
Also seeing this exact behavior. /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:724:2: error: expected expression char *args = flatten_args(argv); ^ /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:725:63: error: use of undeclared identifier 'args'; did you mean 'argv'? sb_eqawarn("Unable to trace static ELF: %s: %s\n", filename, args); ^~~~ argv /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:705:55: note: 'argv' declared here bool trace_possible(const char *filename, char *const argv[], const void *data) ^ /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:726:7: error: use of undeclared identifier 'args'; did you mean 'argv'? free(args); ^~~~ argv /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:705:55: note: 'argv' declared here bool trace_possible(const char *filename, char *const argv[], const void *data) ^ 3 errors generated. make[1]: *** [Makefile:2106: libsandbox/libsandbox_la-trace.lo] Error 1
Created attachment 748251 [details, diff] Proposed patch
I can also confirm the bug. My patch is a bit more readable: diff --git a/libsandbox/trace.c b/libsandbox/trace.c index f3390d9..10a31d8 100644 --- a/libsandbox/trace.c +++ b/libsandbox/trace.c @@ -705,6 +705,7 @@ static char *flatten_args(char *const argv[]) bool trace_possible(const char *filename, char *const argv[], const void *data) { /* If YAMA ptrace_scope is very high, then we can't trace at all. #771360 */ + char *args; int yama = trace_yama_level(); if (yama >= 2) { sb_eqawarn("YAMA ptrace_scope=%i\n", yama); @@ -721,7 +722,7 @@ bool trace_possible(const char *filename, char *const argv[], const void *data) } fail: - char *args = flatten_args(argv); + *args = flatten_args(argv); sb_eqawarn("Unable to trace static ELF: %s: %s\n", filename, args); free(args); return false;
Created attachment 748260 [details] build log with gcc-11.2.0 -Wpedantic FWIW, gcc can also catch this with -Wpedantic: /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c: In function ‘trace_possible’: /var/tmp/portage/sys-apps/sandbox-3.1/work/sandbox-3.1/libsandbox/trace.c:724:9: warning: a label can only be part of a statement and a declaration is not a statement [-Wpedantic] 724 | char *args = flatten_args(argv); | ^~~~
(In reply to Tee KOBAYASHI from comment #6) when i wrote the code, i had expected it to fail to compile due to decls after a label not in a new scope, but since it worked now, i assumed the compiler had improved things to make it work. maybe it's an optimization setting or something that makes it inconsistent.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=82f6d876660ba1132d75ccfef5c4301d123ea505 commit 82f6d876660ba1132d75ccfef5c4301d123ea505 Author: Mike Frysinger <vapier@gentoo.org> AuthorDate: 2021-11-03 16:25:10 +0000 Commit: Mike Frysinger <vapier@gentoo.org> CommitDate: 2021-11-03 16:25:10 +0000 libsandbox: tweak label/decl code for some compiler settings Looks like gcc is inconsistent in when it chokes on this code: > a label can only be part of a statement and a declaration is not a statement Hoist the decl up to the top of scope to avoid the issue. Bug: https://bugs.gentoo.org/821433 Signed-off-by: Mike Frysinger <vapier@gentoo.org> libsandbox/trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36d4dacd971f39bd0ecde7d93216de68c8efe31a commit 36d4dacd971f39bd0ecde7d93216de68c8efe31a Author: Mike Frysinger <vapier@gentoo.org> AuthorDate: 2021-11-03 16:42:47 +0000 Commit: Mike Frysinger <vapier@gentoo.org> CommitDate: 2021-11-03 16:42:59 +0000 sys-apps/sandbox: fix build failures in some compiler configurations #821433 Closes: https://bugs.gentoo.org/821433 Signed-off-by: Mike Frysinger <vapier@gentoo.org> .../sandbox/files/sandbox-3.1-label-decl.patch | 41 ++++++++++++++++++++++ sys-apps/sandbox/sandbox-3.1.ebuild | 4 +++ 2 files changed, 45 insertions(+)
*** Bug 821502 has been marked as a duplicate of this bug. ***
