Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 821247 - media-libs/opencolorio-2.1.0 openexr3 support patch
Summary: media-libs/opencolorio-2.1.0 openexr3 support patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: 820674
  Show dependency tree
 
Reported: 2021-11-01 18:58 UTC by Andrea Postiglione
Modified: 2022-02-24 22:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
openexr3 support patch (opencolorio-openexr3.patch,5.58 KB, patch)
2021-11-01 18:58 UTC, Andrea Postiglione
Details | Diff
Buiding media-libs/opencolorio-2.0.1-r2 again OpenEXR 3 (opencolorio-cumulative-OpenExr3.patch,5.84 KB, patch)
2022-02-11 19:50 UTC, Vladislav Mikhailikov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-02 20:11:01 UTC
Thanks! I'm wondering if we should leave this one as-is _for now_ though given we've got other stuff actually failing...
Comment 2 Bernd 2021-11-03 06:10:52 UTC
I agree with Sam to keep it as is for now. IMO we need to ensure that any package which supports OpenEXR along the dependency path of some big applications, like blender, has support for OpenEXR-3 and then switch to it in one go to avoid potential issues, with some packages using ilmbase/openexr-2 and others use imath/openexr-3.

From my understanding the patch probably isn't needed with current releases of OCIO. They have a cmake option, to choose between both versions, see https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/CMakeLists.txt#L149
Comment 3 Adam Stylinski 2021-11-04 20:39:30 UTC
Hmm, it seems like several dependent packages in ~amd64 are not building as a result of this API change with ilmbase/openexr.  OpenColorIO does not build, which is a direct dependency of Blender.  Any idea when these packages leveraging OpenEXR will be updated?
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-04 20:41:43 UTC
(In reply to Adam Stylinski from comment #3)
> Hmm, it seems like several dependent packages in ~amd64 are not building as
> a result of this API change with ilmbase/openexr.  OpenColorIO does not
> build, which is a direct dependency of Blender.  Any idea when these
> packages leveraging OpenEXR will be updated?

OpenColorIO _should_ (file a bug if they're not) work with older OpenEXR which is the route I'm going with until they're properly/fully supported upstream all together.

Working on bug 816264 atm.

But I don't know, maybe if I can't get far with that bug, we should try the other direction -- it's just not preferred because Blender doesn't support all of this new stuff yet anyway, so people will get conflicts.
Comment 5 Vladislav Mikhailikov 2022-02-11 19:49:12 UTC
I havea bit better solution since OpenEXR 3 using IMath-3/half.h that breaks the build. Cumulative patch tested with last gentoo portage tree and opencolorio-2.0.1-r2 works fine for me.
Comment 6 Vladislav Mikhailikov 2022-02-11 19:50:44 UTC
Created attachment 764845 [details, diff]
Buiding media-libs/opencolorio-2.0.1-r2 again OpenEXR 3

Working fix for openimageio + OpenEXR 3
Comment 7 Larry the Git Cow gentoo-dev 2022-02-12 03:55:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5792b47accb449ecb4a2aafe3b0d8a720b63e94

commit f5792b47accb449ecb4a2aafe3b0d8a720b63e94
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 02:13:20 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-12 03:55:32 +0000

    media-libs/opencolorio: flip over to OpenEXR 3
    
    Things are getting complicated with trying to keep Blender
    on OpenEXR 2. Blender needs to switch as a result, but
    so do its dependencies.
    
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/opencolorio-2.1.1-imath-openexr-3.patch  |  75 +++++++++++++++
 media-libs/opencolorio/opencolorio-2.1.1-r3.ebuild | 106 +++++++++++++++++++++
 2 files changed, 181 insertions(+)
Comment 8 Vladislav Mikhailikov 2022-02-12 10:36:37 UTC
(In reply to Larry the Git Cow from comment #7)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=f5792b47accb449ecb4a2aafe3b0d8a720b63e94
> 
> commit f5792b47accb449ecb4a2aafe3b0d8a720b63e94
> Author:     Sam James <sam@gentoo.org>
> AuthorDate: 2022-02-12 02:13:20 +0000
> Commit:     Sam James <sam@gentoo.org>
> CommitDate: 2022-02-12 03:55:32 +0000
> 
>     media-libs/opencolorio: flip over to OpenEXR 3
>     
>     Things are getting complicated with trying to keep Blender
>     on OpenEXR 2. Blender needs to switch as a result, but
>     so do its dependencies.
>     
>     Bug: https://bugs.gentoo.org/831357
>     Bug: https://bugs.gentoo.org/832862
>     Bug: https://bugs.gentoo.org/821247
>     Signed-off-by: Sam James <sam@gentoo.org>
> 
>  .../files/opencolorio-2.1.1-imath-openexr-3.patch  |  75 +++++++++++++++
>  media-libs/opencolorio/opencolorio-2.1.1-r3.ebuild | 106
> +++++++++++++++++++++
>  2 files changed, 181 insertions(+)

I managed to build blender with OpenEXR3 but get stuck with Alembic which still requires IlmBase-2.5.7. So far, OpenEXR3 is mentioned for update in blender 3.2 upstream but I jave no idea when they gonner do that.
Comment 9 Larry the Git Cow gentoo-dev 2022-02-12 15:01:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=218b141926c8556cc15736cb2dd0f17736583635

commit 218b141926c8556cc15736cb2dd0f17736583635
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 15:00:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-12 15:00:23 +0000

    media-gfx/blender: update dep bounds for OpenEXR 3 conversion (alembic)
    
    This helps to avoid pulling in versions which might've been linked
    against OpenEXR 2.
    
    Alembic is now adapted.
    
    Bug: https://bugs.gentoo.org/821247
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821202
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/blender/blender-2.93.8-r2.ebuild | 2 +-
 media-gfx/blender/blender-3.0.1-r3.ebuild  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 10 Larry the Git Cow gentoo-dev 2022-02-15 19:51:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5cf44c5ab2ca709df6fb7b90434d02487faed323

commit 5cf44c5ab2ca709df6fb7b90434d02487faed323
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 17:58:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-15 19:49:43 +0000

    media-libs/opencolorio: adjust to unslotted OpenEXR
    
    Bug: https://bugs.gentoo.org/833158
    Closes: https://bugs.gentoo.org/831357
    Closes: https://bugs.gentoo.org/832862
    Closes: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/opencolorio-2.1.1-imath-openexr-3.patch  | 75 ----------------------
 ...2.1.1-r3.ebuild => opencolorio-2.1.1-r4.ebuild} |  4 --
 2 files changed, 79 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=967d8224791b0c4f99b837c84f17a4bb8b34f6c8

commit 967d8224791b0c4f99b837c84f17a4bb8b34f6c8
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 18:15:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-15 19:49:57 +0000

    media-libs/osl: adjust to unslotted OpenEXR
    
    Bug: https://bugs.gentoo.org/833158
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 .../osl/files/osl-1.11.16.0-openexr-3-imath.patch  | 126 ---------------------
 .../osl/files/osl-1.12.4.1-openexr-3-imath.patch   | 126 ---------------------
 ...1.11.17.0-r1.ebuild => osl-1.11.17.0-r2.ebuild} |   6 +-
 3 files changed, 1 insertion(+), 257 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b54e19ec3c5870b59d1e18f2d430e72ddaacb009

commit b54e19ec3c5870b59d1e18f2d430e72ddaacb009
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 18:03:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-15 19:49:53 +0000

    media-gfx/openvdb: adjust to unslotted OpenEXR
    
    Bug: https://bugs.gentoo.org/833158
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 .../openvdb/files/openvdb-8.2.0-openexr-3-imath.patch    | 16 ----------------
 .../{openvdb-8.2.0-r1.ebuild => openvdb-8.2.0-r3.ebuild} |  7 ++-----
 .../{openvdb-8.2.0-r2.ebuild => openvdb-8.2.0-r4.ebuild} |  3 +--
 .../{openvdb-9.0.0.ebuild => openvdb-9.0.0-r1.ebuild}    | 12 ++----------
 4 files changed, 5 insertions(+), 33 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=22d23e6ab87569d482db5b5aad1f9e11d8c7c377

commit 22d23e6ab87569d482db5b5aad1f9e11d8c7c377
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 18:01:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-15 19:49:50 +0000

    media-gfx/blender: adjust to unslotted OpenEXR
    
    Bug: https://bugs.gentoo.org/833197
    Bug: https://bugs.gentoo.org/828441
    Bug: https://bugs.gentoo.org/833265
    Bug: https://bugs.gentoo.org/833196
    Bug: https://bugs.gentoo.org/833158
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/blender/blender-2.93.8-r2.ebuild         |   4 +-
 media-gfx/blender/blender-3.0.1-r3.ebuild          |   6 +-
 media-gfx/blender/blender-9999.ebuild              |   2 +-
 .../blender/files/blender-3.0.1-openexr.patch      | 161 +++++++++------------
 4 files changed, 75 insertions(+), 98 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=124b7f13127804fd8a22b55353ef23196798fe11

commit 124b7f13127804fd8a22b55353ef23196798fe11
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 17:59:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-15 19:49:47 +0000

    media-libs/ilmbase: adjust to unslotted OpenEXR
    
    Bug: https://bugs.gentoo.org/833158
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/ilmbase/{ilmbase-2.5.7.ebuild => ilmbase-2.5.7-r1.ebuild} | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e6dd2ea7633bea9d8b3ff8ab037db8fa8a03eac

commit 7e6dd2ea7633bea9d8b3ff8ab037db8fa8a03eac
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 17:58:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-15 19:49:37 +0000

    dev-libs/imath: unslot OpenEXR
    
    Bug: https://bugs.gentoo.org/833158
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 .../imath/{imath-3.1.4-r1.ebuild => imath-3.1.4-r2.ebuild}  | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=130798de3e0e6eb70956b32eb72d0ede71a0b3c1

commit 130798de3e0e6eb70956b32eb72d0ede71a0b3c1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-02-12 17:59:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-02-15 19:49:34 +0000

    media-libs/openexr: unslot
    
    We've tried hard to make this work but it can't, for two reasons:
    1. As time goes on, more and more packages port to OpenEXR 3 upstream,
    which means we have to fix more and more of them to use our special/different
    paths (e.g. OpenEXR-3, Imath-3);
    
    2. ABI breakage. We _must_ have everything (or a significant portion of the stack
    for e.g. Blender, including OIIO and OCIO) built against the same major versions,
    or we hit both runtime and build-time breakages (depending on the situation).
    
    I've tried to keep fixing the avalanche of build failures but it's brittle
    and ultimately doesn't end up solving all the problems anyway. Indeed, this
    effort to unslot started after I did a sprint to fix the remaining issues, and
    then more popped up in their place.
    
    Most packages now support OpenEXR 3.
    
    Bug: https://bugs.gentoo.org/833158
    Bug: https://bugs.gentoo.org/831357
    Bug: https://bugs.gentoo.org/832862
    Bug: https://bugs.gentoo.org/821247
    Signed-off-by: Sam James <sam@gentoo.org>

 media-libs/openexr/openexr-3.1.4-r1.ebuild | 74 ++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)