Bug 821160 – media-gfx/freecad-9999 needs C++17 but ebuild forces C++14

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michael Moon 2021-11-01 04:43:26 UTC]

See https://github.com/FreeCAD/FreeCAD/pull/5086#issuecomment-955922358 - "Yeah, that Gentoo ebuild is wrong -- it's explicitly asking for C++14, which is apparently overriding our cMake system's C++17 requirement."

Issue is at https://gitweb.gentoo.org/repo/gentoo.git/tree/media-gfx/freecad/freecad-9999.ebuild?id=4f73afb9524758e48b346b3f5608d94b49e86a3d#n171 - not sure if this line should be removed entirely or updated to C++17 though.

[Comment 1 Bernd 2021-11-01 14:36:24 UTC]

Yes this has been changed recently in FreeCAD. There's already a PR open to fix it.

[Comment 2 Sam James 2021-11-01 15:05:48 UTC]

(In reply to Bernd from comment #1)
> Yes this has been changed recently in FreeCAD. There's already a PR open to
> fix it.

Will check in a few, thank you!

[Comment 3 Larry the Git Cow 2021-11-02 10:04:52 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6499c130f97644defd3b71d86c4af3b3b5c96c2a

commit 6499c130f97644defd3b71d86c4af3b3b5c96c2a
Author:     Bernd Waibel <[e-mail]>
AuthorDate: 2021-10-17 19:55:29 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-11-02 10:04:37 +0000

    media-gfx/freecad: install freecad-thumbnailer
    
    Can be used by file-managers to show previews for FreeCAD's .fcstd
    files.
    
    Additional changes:
    - bump to EAPI 8
    - cleanup inherit statement
    - patch to build with boost-1.77.0
    - soften sci-libs/pcl dependency. pcl-1.12 supports vtk-9, so there's
            no longer any need to use live ebuild
    - clean optfeature statments from packages which are installed anyway
            or controlled by USE flags
    - use C++17
    
    Suggested-by: Michael Perlov <[e-mail]>
    Bug: https://github.com/waebbl/waebbl-gentoo/issues/341
    Closes: https://bugs.gentoo.org/821160
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Bernd Waibel <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 ...9999-Add-memory-header-for-std-shared_ptr.patch | 31 ++++++++++++++++++++++
 media-gfx/freecad/freecad-9999.ebuild              | 24 ++++++++---------
 2 files changed, 43 insertions(+), 12 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5851bd091fca1165c97a27e96232807548b5df84

commit 5851bd091fca1165c97a27e96232807548b5df84
Author:     Bernd Waibel <[e-mail]>
AuthorDate: 2021-10-18 04:53:51 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-11-02 10:04:38 +0000

    media-gfx/freecad: backport some changes from live ebuild
    
    - install freecad-thumbnailer
    - bump to EAPI 8
    - clean inherit statement
    - clean optfeature statements from packages which are installed anyway
            or controlled by use flags
    - use C++17
    
    Bug: https://bugs.gentoo.org/821160
    Package-Manager: Portage-3.0.28, Repoman-3.0.3
    Signed-off-by: Bernd Waibel <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 media-gfx/freecad/freecad-0.19.2-r4.ebuild | 357 +++++++++++++++++++++++++++++
 1 file changed, 357 insertions(+)

[Comment 4 Sam James 2021-11-02 10:34:30 UTC]

@waebbl, do we want to just drop that CXX standard line entirely?

[Comment 5 Bernd 2021-11-02 17:52:37 UTC]

@sam I think I need to test first, if this works. Earlier releases failed to build without this line.