Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 820077 - mail-mta/msmtp: add support for libtls (dev-libs/libretls)
Summary: mail-mta/msmtp: add support for libtls (dev-libs/libretls)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marek Szuba
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-10-24 23:21 UTC by Sam James
Modified: 2022-07-28 00:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch from PR (0001-mail-mta-msmtp-add-libtls-support.patch,1.54 KB, patch)
2021-12-26 23:14 UTC, Alec Moskvin
Details | Diff
Patch for msmtp-1.8.20 (0001-mail-mta-msmtp-add-libtls-support.patch,1.54 KB, patch)
2022-05-14 17:46 UTC, Alec Moskvin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-10-24 23:21:13 UTC
What do you reckon?
Comment 1 Alec Moskvin 2021-12-26 23:11:22 UTC
Here's a PR: https://github.com/gentoo/gentoo/pull/23533

I was not sure what's the best way to handle the USE flags here. But considering everyone has openssl and libretls is a small shim library around it, I think it makes sense to have it as the default and not have msmtp pull in the whole gnutls stack and do it similarly to how it was done in msmtp-1.6.x before openssl support was dropped.
Comment 2 Alec Moskvin 2021-12-26 23:14:52 UTC
Created attachment 760223 [details, diff]
Patch from PR

> mail-mta/msmtp: polynomial-c
> At least one of the listed packages is maintained entirely by non-GitHub developers!
Uploading the patch here as well
Comment 3 Alec Moskvin 2022-05-14 17:46:56 UTC
Created attachment 778832 [details, diff]
Patch for msmtp-1.8.20
Comment 4 Marek Szuba archtester gentoo-dev 2022-06-30 08:51:34 UTC
Looks good to me. Let's begin by trying to establish keyword parity between libretls and msmtp, I would prefer to avoid USE-masking this on arches for which the former lacks keywords if it could be helped.
Comment 5 Larry the Git Cow gentoo-dev 2022-07-28 00:47:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7ba7206d76de5a9efbe940982e497be9a06ff69b

commit 7ba7206d76de5a9efbe940982e497be9a06ff69b
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2022-07-28 00:45:34 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2022-07-28 00:45:34 +0000

    mail-mta/msmtp: allow linking against dev-libs/libretls
    
    Suggested-by: Alec Moskvin <alecm@gmx.com>
    Closes: https://bugs.gentoo.org/820077
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 mail-mta/msmtp/msmtp-1.8.20-r1.ebuild | 148 ++++++++++++++++++++++++++++++++++
 1 file changed, 148 insertions(+)