app-emulation/libguestfs-1.46.0-r1 fails to emerge. This is the excerpt of the build log: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -DCAML_NAME_SPACE -I. -I../.. -I../../gnulib/lib -I../../gnulib/lib -I../../common/ utils -I../../common/utils -I/usr/lib64/ocaml -pthread -Wall -fPIC -march=native -O2 -pipe -fno-strict-overflow -Wno-strict-overflow - c -o libmlpcre_a-pcre-c.o `test -f 'pcre-c.c' || echo './'`pcre-c.c ocamlfind ocamlc -g -annot -safe-string -warn-error CDEFLMPSUVYZX+52-3 -ccopt '-march=native -O2 -pipe -fno-strict-overflow -Wno-strict- overflow' -I ../../gnulib/lib/.libs -I ../../common/utils/.libs -I . -c PCRE.mli -o PCRE.cmi ocamlfind ocamlopt -g -annot -safe-string -warn-error CDEFLMPSUVYZX+52-3 -ccopt '-march=native -O2 -pipe -fno-strict-overflow -Wno-stric t-overflow' -I ../../gnulib/lib/.libs -I ../../common/utils/.libs -I . -c PCRE.ml -o PCRE.cmx pcre-c.c:47:1: error: static declaration of ‘caml_alloc_initialized_string’ follows non-static declaration 47 | caml_alloc_initialized_string (mlsize_t len, const char *p) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from pcre-c.c:31: /usr/lib64/ocaml/caml/alloc.h:38:18: note: previous declaration of ‘caml_alloc_initialized_string’ with type ‘value(mlsize_t, const cha r *)’ {aka ‘long int(long unsigned int, const char *)’} 38 | CAMLextern value caml_alloc_initialized_string (mlsize_t len, const char *); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reproducible: Always $ emerge -pqv '=app-emulation/libguestfs-1.46.0-r1::gentoo' [ebuild U ] app-emulation/libguestfs-1.46.0-r1 [1.44.1-r1] USE="fuse -doc -erlang -gtk -inspect-icons -introspection -libvirt -lua -ocaml -perl -python -ruby (-selinux) -static-libs -systemtap -test" LUA_SINGLE_TARGET="lua5-1" PYTHON_SINGLE_TARGET="python3_9 -python3_10% -python3_8" $ emerge --info '=app-emulation/libguestfs-1.46.0-r1::gentoo' Portage 3.0.20 (python 3.9.7-final-0, default/linux/amd64/17.1/systemd, gcc-11.2.0, glibc-2.33-r1, 5.10.73-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-5.10.73-gentoo-x86_64-AMD_Ryzen_9_3900XT_12-Core_Processor-with-glibc2.33 KiB Mem: 131839684 total, 73036660 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Sun, 24 Oct 2021 01:45:01 +0000 Head commit of repository gentoo: 463182d9027381286d3b57c354a098fdb0ff1794 Timestamp of repository pentoo: Sat, 23 Oct 2021 12:36:19 +0000 Head commit of repository pentoo: 29e5156108bd459ae391b6e73df825d37a471143 Timestamp of repository qownnotes-overlay: Wed, 20 Oct 2021 14:51:21 +0000 Head commit of repository qownnotes-overlay: fa7822b48ed49797e81833b20bdc5dfd44d5822e Timestamp of repository sage-on-gentoo: Tue, 19 Oct 2021 23:21:34 +0000 Head commit of repository sage-on-gentoo: 038ba9b8d018a4c27b6c1e7d963189c77c858cd2 Timestamp of repository steam-overlay: Mon, 18 Oct 2021 19:36:40 +0000 Head commit of repository steam-overlay: b284012ea06199d6ae23f3154ce18b18d5f65d93 sh bash 5.1_p8 ld GNU ld (Gentoo 2.37_p1 p0) 2.37 distcc 3.4 x86_64-pc-linux-gnu [disabled] app-shells/bash: 5.1_p8::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.34.0-r3::gentoo dev-lang/python: 3.9.7_p1::gentoo dev-lang/rust: 1.53.0::gentoo dev-util/cmake: 3.20.5::gentoo sys-apps/baselayout: 2.7::gentoo sys-apps/sandbox: 2.25::gentoo sys-devel/autoconf: 2.13-r1::gentoo, 2.71-r1::gentoo sys-devel/automake: 1.16.4::gentoo sys-devel/binutils: 2.37_p1::gentoo sys-devel/gcc: 10.3.0-r2::gentoo, 11.2.0::gentoo sys-devel/gcc-config: 2.4::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.13::gentoo (virtual/os-headers) sys-libs/glibc: 2.33-r1::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync2.ru.gentoo.org/gentoo-portage/ priority: -1000 sync-rsync-verify-max-age: 24 sync-rsync-extra-opts: sync-rsync-verify-jobs: 1 sync-rsync-verify-metamanifest: yes localrepo location: /var/db/repos/localrepo masters: gentoo pentoo location: /var/db/repos/pentoo sync-type: git sync-uri: https://github.com/gentoo-mirror/pentoo.git masters: gentoo qownnotes-overlay location: /var/db/repos/qownnotes-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/qownnotes-overlay.git masters: gentoo sage-on-gentoo location: /var/db/repos/sage-on-gentoo sync-type: git sync-uri: https://github.com/gentoo-mirror/sage-on-gentoo.git masters: gentoo steam-overlay location: /var/db/repos/steam-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/steam-overlay.git masters: gentoo Installed sets: @steam, @wgh-wayland ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.8/conf" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/var/cache/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-march=native -O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-march=native -O2 -pipe" GENTOO_MIRRORS="http://mirror.yandex.ru/gentoo-distfiles/" LANG="C.UTF8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j24" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" RUSTFLAGS="-C target-cpu=native" USE="acl amd64 bindist bzip2 cli crypt dri fortran gdbm iconv ipv6 libglvnd libtirpc multilib ncurses nls nptl openmp pam pcre readline seccomp split-usr ssl systemd tcpd udev unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2019" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt rdrand sha sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Created attachment 746526 [details] build.log
I think is this is because I disabled ocaml use flag. The build scripts actually check for existence of this function: https://github.com/libguestfs/libguestfs/blob/760d11ecfad1195ee3074bb999c17d086c5533a5/m4/guestfs-ocaml.m4#L216-L232 And if it's defined in ocaml headers, the static inline definition is not emitted: https://github.com/libguestfs/libguestfs-common/blob/19302b64c5f13a1c247ebbb5f9036e115f081675/mlpcre/pcre-c.c#L42-L53 However, if ocaml is disabled, this check is never run.
There's a patch for 1.44 in Gentoo that fixes exactly this: https://github.com/gentoo/gentoo/blob/master/app-emulation/libguestfs/files/1.44/0001-Check-for-caml_alloc_initialized_string-existence-ev.patch It wasn't ported to 1.46.0-r1 somehow.
Confirming same issue.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=89bd42f04001dfe739cc0b15d3d54b20704c4ce6 commit 89bd42f04001dfe739cc0b15d3d54b20704c4ce6 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-10-24 20:24:00 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-10-24 20:24:21 +0000 app-emulation/libguestfs: fix build failure in 1.46.0 Restore patch from 1.44.x branch. Closes: https://bugs.gentoo.org/820053 Signed-off-by: Sam James <sam@gentoo.org> app-emulation/libguestfs/libguestfs-1.46.0-r1.ebuild | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
(In reply to WGH from comment #3) > There's a patch for 1.44 in Gentoo that fixes exactly this: > https://github.com/gentoo/gentoo/blob/master/app-emulation/libguestfs/files/ > 1.44/0001-Check-for-caml_alloc_initialized_string-existence-ev.patch > > It wasn't ported to 1.46.0-r1 somehow. I naively thought it'd been fixed upstream, apologies
Upstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=2108425 Should be fixed in: https://github.com/libguestfs/libguestfs/commit/adfaf25a12b97b18f8a22d96803cd0920bfd25f7 (development branch) https://github.com/libguestfs/libguestfs/commit/f162e47ecfee711f2c3bcc761de17e502fe7ab5e (stable branch) Note that OCaml is required for building libguestfs. The ./configure --disable-ocaml option only disables the bindings (which is pretty pointless IMHO, but it's there in case you want it).
