make check-TESTS make[4]: Entering directory '/var/tmp/portage/net-im/pidgin-2.14.8/work/pidgin-2.14.8/libpurple/tests' make[5]: Entering directory '/var/tmp/portage/net-im/pidgin-2.14.8/work/pidgin-2.14.8/libpurple/tests' FAIL: check_libpurple =================================================== pidgin 2.14.8: libpurple/tests/test-suite.log =================================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: check_libpurple ===================== Running suite(s): Master Suite Cipher Suite Jabber Caps Functions Jabber SASL DIGEST-MD5 functions Jabber Utility Functions Jabber SASL SCRAM functions Utility Functions Utility Functions 98%: Checks: 86, Failures: 1, Errors: 0 test_util.c:175:F:Time:test_util_str_to_time:0: Assertion '1631512800 == purple_str_to_time("09-13-2021", TRUE, NULL, NULL, NULL)' failed FAIL check_libpurple (exit status: 1) ============================================================================ Testsuite summary for pidgin 2.14.8 ============================================================================ # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 ============================================================================ See libpurple/tests/test-suite.log Please report to devel@pidgin.im ============================================================================ Reproducible: Always
Created attachment 746352 [details] build.log.xz # emerge -pqv '=net-im/pidgin-2.14.8::gentoo' [ebuild U ] net-im/pidgin-2.14.8 [2.14.6-r1] USE="dbus gnutls gstreamer gtk idn networkmanager (pie) sasl xscreensaver (-aqua) -debug -doc -eds -gadu -groupwise -meanwhile -ncurses -nls -perl -prediction -python -spell -tcl -tk -zephyr -zeroconf" PYTHON_SINGLE_TARGET="python3_9 -python3_8" # emerge --info '=net-im/pidgin-2.14.8::gentoo' Portage 3.0.28 (python 3.9.7-final-0, default/linux/amd64/17.1/no-multilib/hardened, gcc-11.2.0, glibc-2.33-r7, 5.14.14 x86_64) ================================================================= System Settings ================================================================= System uname: Linux-5.14.14-x86_64-Intel-R-_Core-TM-_i7-4810MQ_CPU_@_2.80GHz-with-glibc2.33 KiB Mem: 16287208 total, 5504044 free KiB Swap: 20971516 total, 20971516 free Timestamp of repository gentoo: Sat, 23 Oct 2021 16:00:01 +0000 Head commit of repository gentoo: 1cfef34fc2f325d266459d2dc30c0674c925a4c0 sh bash 5.1_p8 ld GNU ld (Gentoo 2.37_p1 p0) 2.37 app-shells/bash: 5.1_p8::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.34.0-r3::gentoo dev-lang/python: 3.9.7_p1::gentoo, 3.10.0_p1::gentoo dev-lang/rust: 1.56.0-r1::gentoo dev-util/cmake: 3.21.3::gentoo sys-apps/baselayout: 2.8::gentoo sys-apps/openrc: 0.44.7::gentoo sys-apps/sandbox: 2.26::gentoo sys-devel/autoconf: 2.13-r1::gentoo, 2.71-r1::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.37_p1::gentoo sys-devel/gcc: 11.2.0::gentoo sys-devel/gcc-config: 2.4::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.14::gentoo (virtual/os-headers) sys-libs/glibc: 2.33-r7::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-metamanifest: yes sync-rsync-extra-opts: --new-compress sync-rsync-verify-jobs: 1 sync-rsync-verify-max-age: 24 local location: /var/lib/portage-local/local masters: gentoo priority: 0 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -mtune=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -mtune=native -O2 -pipe" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--with-bdeps=y" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance cgroup collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu" LINGUAS="" MAKEOPTS="-j8" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_EXTRA_OPTS="--new-compress" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 acl acpi alsa amd64 avx bzip2 cairo caps cdda cddb cdparanoia crypt cups dbus dri dts dvd elogind fam ffmpeg fftw flac fontconfig gif gimp gmp gnutls gtk hardened iconv icu idn ipv6 jpeg lame lcms libglvnd libnotify libtirpc lzma mad matroska mmap mmx mmxext mp3 mpeg ncurses networkmanager nptl ogg opengl openmp pam pcre pie png policykit ppds readline sasl sdl seccomp split-usr sse sse2 sse3 sse4 sse4_1 sse4_2 ssl ssp ssse3 startup-notification svg test theora threads tiff truetype udev udisks unicode upower vaapi verify-sig vorbis wayland x264 xattr xcb xinerama xml xtpax xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2019" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev synaptics" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_9" PYTHON_TARGETS="python3_9" RUBY_TARGETS="ruby26 ruby27" USERLAND="GNU" VIDEO_CARDS="i965 intel nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LANG, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, RUSTFLAGS
Created attachment 746355 [details] libpurple/tests/test-suite.log
I'm running into the same issue. Furthermore, the testcase appears to be at fault: test_util.c:175:F:Time:test_util_str_to_time:0: Assertion '1631512800 == purple_str_to_time("09-13-2021", TRUE, NULL, NULL, NULL)' failed 1. 1631512800 is the date for TZ=UTC+6: TZ=UTC+6 date -d '2021-09-13' +%s => 1631512800 2. the testcase does not set TZ in or before line 175, and has UTC=TRUE as parameter, so it is incorrect. A search also yields the following bug report on upstream: https://issues.imfreedom.org/issue/PIDGIN-17552 confirming an issue and including a patch and review which has apparently been accepted, and which is included in 2.14.8 - but as we can see, doesn't actually fully fix the test issue, and the reviewer apparently did not verify the correctness of the changes. I am unable to confirm whether the change in 2.14.8 actually fixes whatever new bugs were added by the purple_str_to_time() change introduced in 2.14.7; in any case, 2.14.6 is before those changes, so we might want to retain that version in the tree until upstream sorts out their handcrafted date/time code.
Upstream came up with a possible fix: https://reviews.imfreedom.org/r/1238/ Please test and report back your results if possible.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab140b6c50407b21f5ed3c91f41f4441c023bf09 commit ab140b6c50407b21f5ed3c91f41f4441c023bf09 Author: Lars Wendler <polynomial-c@gentoo.org> AuthorDate: 2022-01-18 09:21:59 +0000 Commit: Lars Wendler <polynomial-c@gentoo.org> CommitDate: 2022-01-18 09:22:24 +0000 net-im/pidgin: Fixed test suite Closes: https://bugs.gentoo.org/819774 Signed-off-by: Lars Wendler <polynomial-c@gentoo.org> .../files/pidgin-2.14.8-libpurple_test_fix.patch | 52 ++++++++++++++++++++++ net-im/pidgin/pidgin-2.14.8.ebuild | 3 +- 2 files changed, 54 insertions(+), 1 deletion(-)
