Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 819411 - sys-apps/sandbox (git): immediate "make -j check" broken (missing make-deps?)
Summary: sys-apps/sandbox (git): immediate "make -j check" broken (missing make-deps?)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Sandbox Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-22 06:58 UTC by Michał Górny
Modified: 2021-10-23 06:11 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
output from "make -j check" (check.log,4.12 KB, text/plain)
2021-10-22 06:58 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-10-22 06:58:07 UTC
Created attachment 746100 [details]
output from "make -j check"

The recent unreviewed changes to sandbox.git have broken the Makefile.  When executing "make -j check" without prior "make all", the build fails:

make[2]: *** No rule to make target '../libsbutil/libsbutil.la', needed by 'sb_printf_tst'.  Stop.
make[2]: *** Waiting for unfinished jobs....

(it's sufficient to run "make clean" on a worktree to reproduce)
Comment 1 SpanKY gentoo-dev 2021-10-22 08:50:05 UTC
sandbox has an alias -- please use it

i tried to get the check target to force a build of objects first, but couldn't get automake to play ball with most of the tree not being recursive now but tests/ still being.  plus it didn't seem super important, so just leaving it be for now.
Comment 2 Larry the Git Cow gentoo-dev 2021-10-23 06:10:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=8cda01a02f00f271050050823e6facae0a730da6

commit 8cda01a02f00f271050050823e6facae0a730da6
Author:     Mike Frysinger <vapier@gentoo.org>
AuthorDate: 2021-10-23 05:12:47 +0000
Commit:     Mike Frysinger <vapier@gentoo.org>
CommitDate: 2021-10-23 05:12:47 +0000

    tests: merge into top level makefile too
    
    This kills off recursive make entirely.
    
    Closes: https://bugs.gentoo.org/819411
    Signed-off-by: Mike Frysinger <vapier@gentoo.org>

 .gitignore        |   4 +-
 Makefile.am       |   9 ++--
 configure.ac      |   1 -
 tests/Makefile    |   4 ++
 tests/Makefile.am | 134 ---------------------------------------------------
 tests/local.mk    | 140 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
 6 files changed, 151 insertions(+), 141 deletions(-)
Comment 3 SpanKY gentoo-dev 2021-10-23 06:11:28 UTC
i wasn't keen on converting tests/ to non-recursive make as it'd be a bit more verbose with all the explicit prefixes, but so it goes