Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 816135 - sys-apps/xdg-desktop-portal-gtk version bump
Summary: sys-apps/xdg-desktop-portal-gtk version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on: 842459 842462
Blocks: 836295
  Show dependency tree
 
Reported: 2021-10-03 20:09 UTC by Adam
Modified: 2022-09-30 16:41 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for current xdg-desktop-portal-gnome (xdg-desktop-portal-gnome-41.1.ebuild,877 bytes, text/plain)
2022-01-28 07:26 UTC, Bernd Feige
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Adam 2021-10-03 20:09:47 UTC
please update this ebuild because there's already a corresponding sys-apps/xdg-desktop-portal ebuild in the gentoo repos.
Comment 1 Mart Raudsepp gentoo-dev 2021-10-03 21:54:42 UTC
There's also a xdg-desktop-portal-gnome these days, and I'm not sure if and when some things are moved away from -gtk to there, or still only duplicated. Basically if someone does this, please don't regress due to things having fully moved to xdg-desktop-portal-gnome instead without packaging it and doing necessary migration steps in consumers.
Comment 2 Adam 2021-10-04 19:10:17 UTC
oh I didn't know about xdg-desktop-portal-gnome. Maybe that's just xdg-desktop-portal-gtk with the flags described in the release notes? https://github.com/flatpak/xdg-desktop-portal-gtk/releases/tag/1.10.0
Comment 3 Adam 2021-10-04 19:12:36 UTC
nevermind, I see xdg-desktop-portal-gnome is a separate package that depends on 
xdg-desktop-portal-gtk and xdg-desktop-portal: https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome
Comment 4 Bernd Feige 2022-01-28 07:26:36 UTC
Created attachment 763775 [details]
ebuild for current xdg-desktop-portal-gnome

Hello - Yes, the screen sharing functionality was moved from xdg-desktop-portal-gtk  to xdg-desktop-portal-gnome in version 1.10. So together with current sys-apps/xdg-desktop-portal-gtk-1.12.0, the attached ebuild for xdg-desktop-portal-gnome is necessary and functional.
Comment 5 darkbasic 2022-02-24 11:28:07 UTC
How can I make sure that it's using xdg-desktop-portal-gnome and not xdg-desktop-portal-gtk?
Comment 6 Bernd Feige 2022-02-24 14:43:17 UTC
(In reply to darkbasic from comment #5)
> How can I make sure that it's using xdg-desktop-portal-gnome and not
> xdg-desktop-portal-gtk?

systemctl --user status xdg-desktop-portal-gnome.service

You'll have xdg-desktop-portal-gtk.service active as well - multiple portal services can be active simultaneously and the right one selected at runtime.

The way you actually see it is that screen sharing won't work with xdg-desktop-portal-gtk-1.12.0 (or 1.10) as it did with 1.8.0 - you'll need xdg-desktop-portal-gnome in addition if you're using gnome.
Comment 7 darkbasic 2022-02-24 21:27:40 UTC
Worked out very well without any efforts (even on ppc64le), that's why I was asking. This is a very important piece which should be mainlined ASAP IMO.
Comment 8 Matt Turner gentoo-dev 2022-05-04 02:36:49 UTC
Pacho bumped sys-apps/xdg-desktop-portal-gtk to 1.14.0 and added sys-apps/xdg-desktop-portal-gnome. They're both package.mask'd for testing (which would be much appreciated!)
Comment 9 Bernd Feige 2022-05-08 05:23:09 UTC
(In reply to Matt Turner from comment #8)
> Pacho bumped sys-apps/xdg-desktop-portal-gtk to 1.14.0 and added
> sys-apps/xdg-desktop-portal-gnome. They're both package.mask'd for testing
> (which would be much appreciated!)

Works nicely here - recorded a session with obs yesterday without a glitch...
Comment 10 Matt Turner gentoo-dev 2022-05-12 16:33:16 UTC
Pacho, what's left to do here? Your mask message says

> Waiting for keywording and adapting reverse deps. Bug #816135.

Keywording in bug 842459 isn't happening because the package is masked.

Is the flatpak bug (bug 842462) the only reverse dependency you had in mind? Or is there more than needs to be updated? Are you working on those other reverse dependencies?
Comment 11 Pacho Ramos gentoo-dev 2022-05-15 17:33:30 UTC
I only had flatpak in mind, for gnome-shell-42.x I would simply switch to the new sys-apps/xdg-desktop-portal-gnome
Comment 12 Pacho Ramos gentoo-dev 2022-05-15 17:36:01 UTC
(In reply to Pacho Ramos from comment #11)
> I only had flatpak in mind, for gnome-shell-42.x I would simply switch to
> the new sys-apps/xdg-desktop-portal-gnome

But, if xdg-desktop-portal-gnome is not keyworded before, we would need to re-keyword again the gnome-shell 42.x revision using xdg-desktop-portal-gnome :/ But I guess it will be the only route to go as I don't know any way to make nattka to proceed even with hardmasked packages
Comment 13 Larry the Git Cow gentoo-dev 2022-05-15 18:46:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fb5687185ca1be4a734652b3944dafb1323449e

commit 3fb5687185ca1be4a734652b3944dafb1323449e
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2022-05-15 18:43:46 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2022-05-15 18:45:36 +0000

    profiles/package.mask: unmask xdg-desktop-portal-{gnome,gtk}
    
    Bug: https://bugs.gentoo.org/816135
    Bug: https://bugs.gentoo.org/842459
    
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 profiles/package.mask | 5 -----
 1 file changed, 5 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8f71d18679e2bd1791f2fc5b23ef308723a28604

commit 8f71d18679e2bd1791f2fc5b23ef308723a28604
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2022-05-15 18:42:35 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2022-05-15 18:45:36 +0000

    gnome-base/gnome-shell: Allow and prefer xdg-desktop-portal-gnome
    
    Bug: https://bugs.gentoo.org/816135
    
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 gnome-base/gnome-shell/gnome-shell-42.1-r1.ebuild | 203 ++++++++++++++++++++++
 1 file changed, 203 insertions(+)
Comment 14 Matt Turner gentoo-dev 2022-09-24 16:43:29 UTC
I think we're done here?
Comment 15 Alexander Tsoy 2022-09-25 01:01:20 UTC
(In reply to Larry the Git Cow from comment #13)
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=8f71d18679e2bd1791f2fc5b23ef308723a28604
> 
> commit 8f71d18679e2bd1791f2fc5b23ef308723a28604
> Author:     Pacho Ramos <pacho@gentoo.org>
> AuthorDate: 2022-05-15 18:42:35 +0000
> Commit:     Pacho Ramos <pacho@gentoo.org>
> CommitDate: 2022-05-15 18:45:36 +0000
> 
>     gnome-base/gnome-shell: Allow and prefer xdg-desktop-portal-gnome

Note that portage fails to automatically pull in xdg-desktop-portal-gnome. My system stuck with sys-apps/xdg-desktop-portal-gtk-1.8.0 until I manually installed xdg-desktop-portal-gnome:

$ sudo eclean-dist -d
Пароль: 
 * Building file list for distfiles cleaning...
 * Your distfiles directory was already clean.

   The following unavailable installed packages were found
             sys-apps/xdg-desktop-portal-gtk-1.8.0

$ sudo emerge -aquDN --changed-deps @world

Nothing to merge; quitting.
Comment 16 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-25 01:06:27 UTC
(In reply to Alexander Tsoy from comment #15)
> (In reply to Larry the Git Cow from comment #13)
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/
> > ?id=8f71d18679e2bd1791f2fc5b23ef308723a28604
> > 
> > commit 8f71d18679e2bd1791f2fc5b23ef308723a28604
> > Author:     Pacho Ramos <pacho@gentoo.org>
> > AuthorDate: 2022-05-15 18:42:35 +0000
> > Commit:     Pacho Ramos <pacho@gentoo.org>
> > CommitDate: 2022-05-15 18:45:36 +0000
> > 
> >     gnome-base/gnome-shell: Allow and prefer xdg-desktop-portal-gnome
> 
> Note that portage fails to automatically pull in xdg-desktop-portal-gnome.
> My system stuck with sys-apps/xdg-desktop-portal-gtk-1.8.0 until I manually
> installed xdg-desktop-portal-gnome:
> 
> $ sudo eclean-dist -d
> Пароль: 
>  * Building file list for distfiles cleaning...
>  * Your distfiles directory was already clean.
> 
>    The following unavailable installed packages were found
>              sys-apps/xdg-desktop-portal-gtk-1.8.0
> 
> $ sudo emerge -aquDN --changed-deps @world
> 
> Nothing to merge; quitting.

That'd be bug 872227, I guess. I'd suggest just doing a new revision without the || ( ... ) if we don't want people to stay on the old one.
Comment 17 Larry the Git Cow gentoo-dev 2022-09-30 16:41:47 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca38c9d508d2a02f2c815600f664d0e17daf4fe5

commit ca38c9d508d2a02f2c815600f664d0e17daf4fe5
Author:     brahmajit das <listout@protonmail.com>
AuthorDate: 2022-09-29 17:48:14 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2022-09-30 16:41:39 +0000

    gnome-base/gnome-shell: Version bump to 42.5
    
    Closes: https://bugs.gentoo.org/816135
    Signed-off-by: brahmajit das <listout@protonmail.com>
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 gnome-base/gnome-shell/Manifest                |   1 +
 gnome-base/gnome-shell/gnome-shell-42.5.ebuild | 208 +++++++++++++++++++++++++
 2 files changed, 209 insertions(+)